From: Thierry Reding <thierry.reding@gmail.com>
To: Mikko Perttunen <cyndis@kapsi.fi>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Srikar Srimath Tirumala <srikars@nvidia.com>,
Mikko Perttunen <mperttunen@nvidia.com>,
Timo Alho <talho@nvidia.com>,
linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] thermal: tegra-bpmp: Handle offline zones
Date: Wed, 8 Feb 2023 17:05:05 +0100 [thread overview]
Message-ID: <Y+PIMc8PepsIPXN7@orome> (raw)
In-Reply-To: <706b3e2d-7097-356b-b96e-dd917ce048ea@kapsi.fi>
[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]
On Wed, Feb 08, 2023 at 05:35:48PM +0200, Mikko Perttunen wrote:
> On 2/8/23 12:31, Thierry Reding wrote:
> > On Tue, Feb 07, 2023 at 03:56:08PM +0200, Mikko Perttunen wrote:
> > > From: Mikko Perttunen <mperttunen@nvidia.com>
> > >
> > > Thermal zones located in power domains may not be accessible when
> > > the domain is powergated. In this situation, reading the temperature
> > > will return -BPMP_EFAULT and the temperature is considered to be
> > > -256C for calculating trips.
> >
> > Where's that -256C being set? I only see THERMAL_TEMP_INVALID being set
> > as the default for a zone, but that's not -274C, not -256C. If that's
> > the temperature that you're referring to, it might be better to state
> > that we rely on the default temperature rather than any specific number.
> >
> > Thierry
>
> It is based on BPMP's internal behavior.
Okay, maybe clarify that part of the sentence then. Could be something
like:
... will return -BPMP_EFAULT. When evaluating trips, BPMP will
internally use -256C as the temperature for offline zones.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-02-08 16:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 13:56 [PATCH 1/2] thermal: tegra-bpmp: Handle offline zones Mikko Perttunen
2023-02-07 13:56 ` [PATCH 2/2] thermal: tegra-bpmp: Always (re)program trip temperatures Mikko Perttunen
2023-02-08 10:43 ` Thierry Reding
2023-02-08 15:35 ` Mikko Perttunen
2023-02-08 16:02 ` Thierry Reding
2023-02-08 10:31 ` [PATCH 1/2] thermal: tegra-bpmp: Handle offline zones Thierry Reding
2023-02-08 15:35 ` Mikko Perttunen
2023-02-08 16:05 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+PIMc8PepsIPXN7@orome \
--to=thierry.reding@gmail.com \
--cc=amitk@kernel.org \
--cc=cyndis@kapsi.fi \
--cc=daniel.lezcano@linaro.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=srikars@nvidia.com \
--cc=talho@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).