* [PATCH 07/21] power: remove s3c adc battery driver
2022-10-21 20:22 [PATCH 00/21] ARM: s3c: clean out obsolete platforms Arnd Bergmann
@ 2022-10-21 20:27 ` Arnd Bergmann
2022-10-24 7:28 ` Lee Jones
` (2 more replies)
2022-10-21 20:27 ` [PATCH 15/21] cpufreq: remove s3c24xx drivers Arnd Bergmann
` (2 subsequent siblings)
3 siblings, 3 replies; 14+ messages in thread
From: Arnd Bergmann @ 2022-10-21 20:27 UTC (permalink / raw)
To: linux-arm-kernel, Krzysztof Kozlowski, Sebastian Reichel
Cc: linux-kernel, Ben Dooks, Simtec Linux Team, Arnd Bergmann,
Rob Herring, Greg Kroah-Hartman, Mauro Carvalho Chehab,
Lukas Bulwahn, Joe Perches, Hans de Goede, Linus Walleij,
Luca Ceresoli, Lee Jones, linux-pm
From: Arnd Bergmann <arnd@arndb.de>
The s3c-adc driver is removed along with the s3c24xx platform,
so the battery driver is no longer needed either.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
MAINTAINERS | 7 -
drivers/power/supply/Kconfig | 6 -
drivers/power/supply/Makefile | 1 -
drivers/power/supply/s3c_adc_battery.c | 453 -------------------------
include/linux/s3c_adc_battery.h | 39 ---
5 files changed, 506 deletions(-)
delete mode 100644 drivers/power/supply/s3c_adc_battery.c
delete mode 100644 include/linux/s3c_adc_battery.h
diff --git a/MAINTAINERS b/MAINTAINERS
index 071d64e2a7ca..2caf42b0328a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -17920,13 +17920,6 @@ S: Supported
W: http://www.ibm.com/developerworks/linux/linux390/
F: drivers/s390/scsi/zfcp_*
-S3C ADC BATTERY DRIVER
-M: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
-L: linux-samsung-soc@vger.kernel.org
-S: Odd Fixes
-F: drivers/power/supply/s3c_adc_battery.c
-F: include/linux/s3c_adc_battery.h
-
S3C24XX SD/MMC Driver
M: Ben Dooks <ben-linux@fluff.org>
L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
index 568b3ede993a..e2f8dfcdd2a9 100644
--- a/drivers/power/supply/Kconfig
+++ b/drivers/power/supply/Kconfig
@@ -406,12 +406,6 @@ config BATTERY_MAX1721X
Say Y here to enable support for the MAX17211/MAX17215 standalone
battery gas-gauge.
-config BATTERY_S3C_ADC
- tristate "Battery driver for Samsung ADC based monitoring"
- depends on S3C_ADC
- help
- Say Y here to enable support for iPAQ h1930/h1940/rx1950 battery
-
config BATTERY_TWL4030_MADC
tristate "TWL4030 MADC battery driver"
depends on TWL4030_MADC
diff --git a/drivers/power/supply/Makefile b/drivers/power/supply/Makefile
index af43866b3980..8cb3c7f5c111 100644
--- a/drivers/power/supply/Makefile
+++ b/drivers/power/supply/Makefile
@@ -54,7 +54,6 @@ obj-$(CONFIG_BATTERY_MAX17042) += max17042_battery.o
obj-$(CONFIG_BATTERY_MAX1721X) += max1721x_battery.o
obj-$(CONFIG_BATTERY_RT5033) += rt5033_battery.o
obj-$(CONFIG_CHARGER_RT9455) += rt9455_charger.o
-obj-$(CONFIG_BATTERY_S3C_ADC) += s3c_adc_battery.o
obj-$(CONFIG_BATTERY_TWL4030_MADC) += twl4030_madc_battery.o
obj-$(CONFIG_CHARGER_88PM860X) += 88pm860x_charger.o
obj-$(CONFIG_CHARGER_PCF50633) += pcf50633-charger.o
diff --git a/drivers/power/supply/s3c_adc_battery.c b/drivers/power/supply/s3c_adc_battery.c
deleted file mode 100644
index 68d31a3bee48..000000000000
diff --git a/include/linux/s3c_adc_battery.h b/include/linux/s3c_adc_battery.h
deleted file mode 100644
index 57f982c375f8..000000000000
--
2.29.2
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 07/21] power: remove s3c adc battery driver
2022-10-21 20:27 ` [PATCH 07/21] power: remove s3c adc battery driver Arnd Bergmann
@ 2022-10-24 7:28 ` Lee Jones
2022-10-24 7:42 ` Arnd Bergmann
2022-10-24 12:31 ` Krzysztof Kozlowski
2022-10-28 14:18 ` Sebastian Reichel
2 siblings, 1 reply; 14+ messages in thread
From: Lee Jones @ 2022-10-24 7:28 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-arm-kernel, Krzysztof Kozlowski, Sebastian Reichel,
linux-kernel, Ben Dooks, Simtec Linux Team, Arnd Bergmann,
Rob Herring, Greg Kroah-Hartman, Mauro Carvalho Chehab,
Lukas Bulwahn, Joe Perches, Hans de Goede, Linus Walleij,
Luca Ceresoli, linux-pm
On Fri, 21 Oct 2022, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The s3c-adc driver is removed along with the s3c24xx platform,
> so the battery driver is no longer needed either.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> MAINTAINERS | 7 -
> drivers/power/supply/Kconfig | 6 -
> drivers/power/supply/Makefile | 1 -
> drivers/power/supply/s3c_adc_battery.c | 453 -------------------------
> include/linux/s3c_adc_battery.h | 39 ---
> 5 files changed, 506 deletions(-)
> delete mode 100644 drivers/power/supply/s3c_adc_battery.c
> delete mode 100644 include/linux/s3c_adc_battery.h
Any idea why I was Cc'ed on this (and only this) patch?
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 07/21] power: remove s3c adc battery driver
2022-10-24 7:28 ` Lee Jones
@ 2022-10-24 7:42 ` Arnd Bergmann
2022-10-24 7:57 ` Lee Jones
0 siblings, 1 reply; 14+ messages in thread
From: Arnd Bergmann @ 2022-10-24 7:42 UTC (permalink / raw)
To: Lee Jones, Arnd Bergmann
Cc: linux-arm-kernel, Krzysztof Kozlowski, Sebastian Reichel,
linux-kernel, Ben Dooks, Simtec Linux Team, Rob Herring,
Greg Kroah-Hartman, Mauro Carvalho Chehab, Lukas Bulwahn,
Joe Perches, Hans de Goede, Linus Walleij, Luca Ceresoli,
linux-pm
On Mon, Oct 24, 2022, at 09:28, Lee Jones wrote:
> On Fri, 21 Oct 2022, Arnd Bergmann wrote:
>
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> The s3c-adc driver is removed along with the s3c24xx platform,
>> so the battery driver is no longer needed either.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>> MAINTAINERS | 7 -
>> drivers/power/supply/Kconfig | 6 -
>> drivers/power/supply/Makefile | 1 -
>> drivers/power/supply/s3c_adc_battery.c | 453 -------------------------
>> include/linux/s3c_adc_battery.h | 39 ---
>> 5 files changed, 506 deletions(-)
>> delete mode 100644 drivers/power/supply/s3c_adc_battery.c
>> delete mode 100644 include/linux/s3c_adc_battery.h
>
> Any idea why I was Cc'ed on this (and only this) patch?
Not sure. I use "get_maintainer.pl -i" to generate the list
and try to prune it manually to avoid adding too many
people to Cc. It appears that for this patch I accidentally
included everyone who showed up in the git history for the
maintainers file, rather than the people who touched the
actual driver.
Arnd
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 07/21] power: remove s3c adc battery driver
2022-10-24 7:42 ` Arnd Bergmann
@ 2022-10-24 7:57 ` Lee Jones
0 siblings, 0 replies; 14+ messages in thread
From: Lee Jones @ 2022-10-24 7:57 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Arnd Bergmann, linux-arm-kernel, Krzysztof Kozlowski,
Sebastian Reichel, linux-kernel, Ben Dooks, Simtec Linux Team,
Rob Herring, Greg Kroah-Hartman, Mauro Carvalho Chehab,
Lukas Bulwahn, Joe Perches, Hans de Goede, Linus Walleij,
Luca Ceresoli, linux-pm
On Mon, 24 Oct 2022, Arnd Bergmann wrote:
> On Mon, Oct 24, 2022, at 09:28, Lee Jones wrote:
> > On Fri, 21 Oct 2022, Arnd Bergmann wrote:
> >
> >> From: Arnd Bergmann <arnd@arndb.de>
> >>
> >> The s3c-adc driver is removed along with the s3c24xx platform,
> >> so the battery driver is no longer needed either.
> >>
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >> ---
> >> MAINTAINERS | 7 -
> >> drivers/power/supply/Kconfig | 6 -
> >> drivers/power/supply/Makefile | 1 -
> >> drivers/power/supply/s3c_adc_battery.c | 453 -------------------------
> >> include/linux/s3c_adc_battery.h | 39 ---
> >> 5 files changed, 506 deletions(-)
> >> delete mode 100644 drivers/power/supply/s3c_adc_battery.c
> >> delete mode 100644 include/linux/s3c_adc_battery.h
> >
> > Any idea why I was Cc'ed on this (and only this) patch?
>
> Not sure. I use "get_maintainer.pl -i" to generate the list
> and try to prune it manually to avoid adding too many
> people to Cc. It appears that for this patch I accidentally
> included everyone who showed up in the git history for the
> maintainers file, rather than the people who touched the
> actual driver.
Understood. Thanks for the explanation.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 07/21] power: remove s3c adc battery driver
2022-10-21 20:27 ` [PATCH 07/21] power: remove s3c adc battery driver Arnd Bergmann
2022-10-24 7:28 ` Lee Jones
@ 2022-10-24 12:31 ` Krzysztof Kozlowski
2022-10-28 14:18 ` Sebastian Reichel
2 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-24 12:31 UTC (permalink / raw)
To: Arnd Bergmann, linux-arm-kernel, Sebastian Reichel
Cc: linux-kernel, Ben Dooks, Simtec Linux Team, Arnd Bergmann,
Rob Herring, Greg Kroah-Hartman, Mauro Carvalho Chehab,
Lukas Bulwahn, Joe Perches, Hans de Goede, Linus Walleij,
Luca Ceresoli, Lee Jones, linux-pm
On 21/10/2022 16:27, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The s3c-adc driver is removed along with the s3c24xx platform,
> so the battery driver is no longer needed either.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 07/21] power: remove s3c adc battery driver
2022-10-21 20:27 ` [PATCH 07/21] power: remove s3c adc battery driver Arnd Bergmann
2022-10-24 7:28 ` Lee Jones
2022-10-24 12:31 ` Krzysztof Kozlowski
@ 2022-10-28 14:18 ` Sebastian Reichel
2 siblings, 0 replies; 14+ messages in thread
From: Sebastian Reichel @ 2022-10-28 14:18 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-arm-kernel, Krzysztof Kozlowski, linux-kernel, Ben Dooks,
Simtec Linux Team, Arnd Bergmann, Rob Herring, Greg Kroah-Hartman,
Mauro Carvalho Chehab, Lukas Bulwahn, Joe Perches, Hans de Goede,
Linus Walleij, Luca Ceresoli, Lee Jones, linux-pm
[-- Attachment #1: Type: text/plain, Size: 3310 bytes --]
Hi,
On Fri, Oct 21, 2022 at 10:27:40PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The s3c-adc driver is removed along with the s3c24xx platform,
> so the battery driver is no longer needed either.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
I suppose queuing this via power-supply will result in temporary
build failures because the header is included in s3c24xx arch code.
So better to merge via the same tree that is killing the arch code:
Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com>
-- Sebastian
> MAINTAINERS | 7 -
> drivers/power/supply/Kconfig | 6 -
> drivers/power/supply/Makefile | 1 -
> drivers/power/supply/s3c_adc_battery.c | 453 -------------------------
> include/linux/s3c_adc_battery.h | 39 ---
> 5 files changed, 506 deletions(-)
> delete mode 100644 drivers/power/supply/s3c_adc_battery.c
> delete mode 100644 include/linux/s3c_adc_battery.h
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 071d64e2a7ca..2caf42b0328a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -17920,13 +17920,6 @@ S: Supported
> W: http://www.ibm.com/developerworks/linux/linux390/
> F: drivers/s390/scsi/zfcp_*
>
> -S3C ADC BATTERY DRIVER
> -M: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> -L: linux-samsung-soc@vger.kernel.org
> -S: Odd Fixes
> -F: drivers/power/supply/s3c_adc_battery.c
> -F: include/linux/s3c_adc_battery.h
> -
> S3C24XX SD/MMC Driver
> M: Ben Dooks <ben-linux@fluff.org>
> L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
> index 568b3ede993a..e2f8dfcdd2a9 100644
> --- a/drivers/power/supply/Kconfig
> +++ b/drivers/power/supply/Kconfig
> @@ -406,12 +406,6 @@ config BATTERY_MAX1721X
> Say Y here to enable support for the MAX17211/MAX17215 standalone
> battery gas-gauge.
>
> -config BATTERY_S3C_ADC
> - tristate "Battery driver for Samsung ADC based monitoring"
> - depends on S3C_ADC
> - help
> - Say Y here to enable support for iPAQ h1930/h1940/rx1950 battery
> -
> config BATTERY_TWL4030_MADC
> tristate "TWL4030 MADC battery driver"
> depends on TWL4030_MADC
> diff --git a/drivers/power/supply/Makefile b/drivers/power/supply/Makefile
> index af43866b3980..8cb3c7f5c111 100644
> --- a/drivers/power/supply/Makefile
> +++ b/drivers/power/supply/Makefile
> @@ -54,7 +54,6 @@ obj-$(CONFIG_BATTERY_MAX17042) += max17042_battery.o
> obj-$(CONFIG_BATTERY_MAX1721X) += max1721x_battery.o
> obj-$(CONFIG_BATTERY_RT5033) += rt5033_battery.o
> obj-$(CONFIG_CHARGER_RT9455) += rt9455_charger.o
> -obj-$(CONFIG_BATTERY_S3C_ADC) += s3c_adc_battery.o
> obj-$(CONFIG_BATTERY_TWL4030_MADC) += twl4030_madc_battery.o
> obj-$(CONFIG_CHARGER_88PM860X) += 88pm860x_charger.o
> obj-$(CONFIG_CHARGER_PCF50633) += pcf50633-charger.o
> diff --git a/drivers/power/supply/s3c_adc_battery.c b/drivers/power/supply/s3c_adc_battery.c
> deleted file mode 100644
> index 68d31a3bee48..000000000000
> diff --git a/include/linux/s3c_adc_battery.h b/include/linux/s3c_adc_battery.h
> deleted file mode 100644
> index 57f982c375f8..000000000000
> --
> 2.29.2
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 15/21] cpufreq: remove s3c24xx drivers
2022-10-21 20:22 [PATCH 00/21] ARM: s3c: clean out obsolete platforms Arnd Bergmann
2022-10-21 20:27 ` [PATCH 07/21] power: remove s3c adc battery driver Arnd Bergmann
@ 2022-10-21 20:27 ` Arnd Bergmann
2022-10-24 12:40 ` Krzysztof Kozlowski
2022-10-25 5:19 ` Viresh Kumar
2022-10-22 15:18 ` [PATCH 00/21] ARM: s3c: clean out obsolete platforms Krzysztof Kozlowski
2022-10-24 13:00 ` Rob Herring
3 siblings, 2 replies; 14+ messages in thread
From: Arnd Bergmann @ 2022-10-21 20:27 UTC (permalink / raw)
To: linux-arm-kernel, Krzysztof Kozlowski, Rafael J. Wysocki,
Viresh Kumar
Cc: linux-kernel, Ben Dooks, Simtec Linux Team, Arnd Bergmann,
Alim Akhtar, linux-pm, linux-samsung-soc
From: Arnd Bergmann <arnd@arndb.de>
All s3c24xx platforms were removed, so these five drivers are all
obsolete now.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/cpufreq/Kconfig.arm | 78 ---
drivers/cpufreq/Makefile | 6 -
drivers/cpufreq/s3c2410-cpufreq.c | 155 -----
drivers/cpufreq/s3c2412-cpufreq.c | 240 -------
drivers/cpufreq/s3c2416-cpufreq.c | 492 --------------
drivers/cpufreq/s3c2440-cpufreq.c | 321 ---------
drivers/cpufreq/s3c24xx-cpufreq-debugfs.c | 163 -----
drivers/cpufreq/s3c24xx-cpufreq.c | 648 -------------------
include/linux/soc/samsung/s3c-cpufreq-core.h | 299 ---------
9 files changed, 2402 deletions(-)
delete mode 100644 drivers/cpufreq/s3c2410-cpufreq.c
delete mode 100644 drivers/cpufreq/s3c2412-cpufreq.c
delete mode 100644 drivers/cpufreq/s3c2416-cpufreq.c
delete mode 100644 drivers/cpufreq/s3c2440-cpufreq.c
delete mode 100644 drivers/cpufreq/s3c24xx-cpufreq-debugfs.c
delete mode 100644 drivers/cpufreq/s3c24xx-cpufreq.c
delete mode 100644 include/linux/soc/samsung/s3c-cpufreq-core.h
diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
index 8f7a1065f344..e3e0367305ec 100644
--- a/drivers/cpufreq/Kconfig.arm
+++ b/drivers/cpufreq/Kconfig.arm
@@ -180,84 +180,6 @@ config ARM_RASPBERRYPI_CPUFREQ
If in doubt, say N.
-config ARM_S3C_CPUFREQ
- bool
- help
- Internal configuration node for common cpufreq on Samsung SoC
-
-config ARM_S3C24XX_CPUFREQ
- bool "CPUfreq driver for Samsung S3C24XX series CPUs (EXPERIMENTAL)"
- depends on ARCH_S3C24XX
- select ARM_S3C_CPUFREQ
- help
- This enables the CPUfreq driver for the Samsung S3C24XX family
- of CPUs.
-
- For details, take a look at <file:Documentation/cpu-freq>.
-
- If in doubt, say N.
-
-config ARM_S3C24XX_CPUFREQ_DEBUG
- bool "Debug CPUfreq Samsung driver core"
- depends on ARM_S3C24XX_CPUFREQ
- help
- Enable s3c_freq_dbg for the Samsung S3C CPUfreq core
-
-config ARM_S3C24XX_CPUFREQ_IODEBUG
- bool "Debug CPUfreq Samsung driver IO timing"
- depends on ARM_S3C24XX_CPUFREQ
- help
- Enable s3c_freq_iodbg for the Samsung S3C CPUfreq core
-
-config ARM_S3C24XX_CPUFREQ_DEBUGFS
- bool "Export debugfs for CPUFreq"
- depends on ARM_S3C24XX_CPUFREQ && DEBUG_FS
- help
- Export status information via debugfs.
-
-config ARM_S3C2410_CPUFREQ
- bool
- depends on ARM_S3C24XX_CPUFREQ && CPU_S3C2410
- help
- CPU Frequency scaling support for S3C2410
-
-config ARM_S3C2412_CPUFREQ
- bool
- depends on ARM_S3C24XX_CPUFREQ && CPU_S3C2412
- default y
- select S3C2412_IOTIMING
- help
- CPU Frequency scaling support for S3C2412 and S3C2413 SoC CPUs.
-
-config ARM_S3C2416_CPUFREQ
- bool "S3C2416 CPU Frequency scaling support"
- depends on CPU_S3C2416
- help
- This adds the CPUFreq driver for the Samsung S3C2416 and
- S3C2450 SoC. The S3C2416 supports changing the rate of the
- armdiv clock source and also entering a so called dynamic
- voltage scaling mode in which it is possible to reduce the
- core voltage of the CPU.
-
- If in doubt, say N.
-
-config ARM_S3C2416_CPUFREQ_VCORESCALE
- bool "Allow voltage scaling for S3C2416 arm core"
- depends on ARM_S3C2416_CPUFREQ && REGULATOR
- help
- Enable CPU voltage scaling when entering the dvs mode.
- It uses information gathered through existing hardware and
- tests but not documented in any datasheet.
-
- If in doubt, say N.
-
-config ARM_S3C2440_CPUFREQ
- bool "S3C2440/S3C2442 CPU Frequency scaling support"
- depends on ARM_S3C24XX_CPUFREQ && (CPU_S3C2440 || CPU_S3C2442)
- default y
- help
- CPU Frequency scaling support for S3C2440 and S3C2442 SoC CPUs.
-
config ARM_S3C64XX_CPUFREQ
bool "Samsung S3C64XX"
depends on CPU_S3C6410
diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
index 8de99b213146..692c16e4ee55 100644
--- a/drivers/cpufreq/Makefile
+++ b/drivers/cpufreq/Makefile
@@ -70,13 +70,7 @@ obj-$(CONFIG_PXA3xx) += pxa3xx-cpufreq.o
obj-$(CONFIG_ARM_QCOM_CPUFREQ_HW) += qcom-cpufreq-hw.o
obj-$(CONFIG_ARM_QCOM_CPUFREQ_NVMEM) += qcom-cpufreq-nvmem.o
obj-$(CONFIG_ARM_RASPBERRYPI_CPUFREQ) += raspberrypi-cpufreq.o
-obj-$(CONFIG_ARM_S3C2410_CPUFREQ) += s3c2410-cpufreq.o
-obj-$(CONFIG_ARM_S3C2412_CPUFREQ) += s3c2412-cpufreq.o
-obj-$(CONFIG_ARM_S3C2416_CPUFREQ) += s3c2416-cpufreq.o
-obj-$(CONFIG_ARM_S3C2440_CPUFREQ) += s3c2440-cpufreq.o
obj-$(CONFIG_ARM_S3C64XX_CPUFREQ) += s3c64xx-cpufreq.o
-obj-$(CONFIG_ARM_S3C24XX_CPUFREQ) += s3c24xx-cpufreq.o
-obj-$(CONFIG_ARM_S3C24XX_CPUFREQ_DEBUGFS) += s3c24xx-cpufreq-debugfs.o
obj-$(CONFIG_ARM_S5PV210_CPUFREQ) += s5pv210-cpufreq.o
obj-$(CONFIG_ARM_SA1110_CPUFREQ) += sa1110-cpufreq.o
obj-$(CONFIG_ARM_SCMI_CPUFREQ) += scmi-cpufreq.o
diff --git a/drivers/cpufreq/s3c2410-cpufreq.c b/drivers/cpufreq/s3c2410-cpufreq.c
deleted file mode 100644
index 5dcfbf0bfb74..000000000000
diff --git a/drivers/cpufreq/s3c2412-cpufreq.c b/drivers/cpufreq/s3c2412-cpufreq.c
deleted file mode 100644
index 5945945ead7c..000000000000
diff --git a/drivers/cpufreq/s3c2416-cpufreq.c b/drivers/cpufreq/s3c2416-cpufreq.c
deleted file mode 100644
index 5c221bc90210..000000000000
diff --git a/drivers/cpufreq/s3c2440-cpufreq.c b/drivers/cpufreq/s3c2440-cpufreq.c
deleted file mode 100644
index 2011fb9c03a4..000000000000
diff --git a/drivers/cpufreq/s3c24xx-cpufreq-debugfs.c b/drivers/cpufreq/s3c24xx-cpufreq-debugfs.c
deleted file mode 100644
index 93971dfe7c75..000000000000
diff --git a/drivers/cpufreq/s3c24xx-cpufreq.c b/drivers/cpufreq/s3c24xx-cpufreq.c
deleted file mode 100644
index 7380c32b238e..000000000000
diff --git a/include/linux/soc/samsung/s3c-cpufreq-core.h b/include/linux/soc/samsung/s3c-cpufreq-core.h
deleted file mode 100644
index 3b278afb769b..000000000000
--
2.29.2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 15/21] cpufreq: remove s3c24xx drivers
2022-10-21 20:27 ` [PATCH 15/21] cpufreq: remove s3c24xx drivers Arnd Bergmann
@ 2022-10-24 12:40 ` Krzysztof Kozlowski
2022-10-25 5:19 ` Viresh Kumar
1 sibling, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-24 12:40 UTC (permalink / raw)
To: Arnd Bergmann, linux-arm-kernel, Rafael J. Wysocki, Viresh Kumar
Cc: linux-kernel, Ben Dooks, Simtec Linux Team, Arnd Bergmann,
Alim Akhtar, linux-pm, linux-samsung-soc
On 21/10/2022 16:27, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> All s3c24xx platforms were removed, so these five drivers are all
> obsolete now.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 15/21] cpufreq: remove s3c24xx drivers
2022-10-21 20:27 ` [PATCH 15/21] cpufreq: remove s3c24xx drivers Arnd Bergmann
2022-10-24 12:40 ` Krzysztof Kozlowski
@ 2022-10-25 5:19 ` Viresh Kumar
1 sibling, 0 replies; 14+ messages in thread
From: Viresh Kumar @ 2022-10-25 5:19 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-arm-kernel, Krzysztof Kozlowski, Rafael J. Wysocki,
linux-kernel, Ben Dooks, Simtec Linux Team, Arnd Bergmann,
Alim Akhtar, linux-pm, linux-samsung-soc
On 21-10-22, 22:27, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> All s3c24xx platforms were removed, so these five drivers are all
> obsolete now.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/cpufreq/Kconfig.arm | 78 ---
> drivers/cpufreq/Makefile | 6 -
> drivers/cpufreq/s3c2410-cpufreq.c | 155 -----
> drivers/cpufreq/s3c2412-cpufreq.c | 240 -------
> drivers/cpufreq/s3c2416-cpufreq.c | 492 --------------
> drivers/cpufreq/s3c2440-cpufreq.c | 321 ---------
> drivers/cpufreq/s3c24xx-cpufreq-debugfs.c | 163 -----
> drivers/cpufreq/s3c24xx-cpufreq.c | 648 -------------------
> include/linux/soc/samsung/s3c-cpufreq-core.h | 299 ---------
> 9 files changed, 2402 deletions(-)
> delete mode 100644 drivers/cpufreq/s3c2410-cpufreq.c
> delete mode 100644 drivers/cpufreq/s3c2412-cpufreq.c
> delete mode 100644 drivers/cpufreq/s3c2416-cpufreq.c
> delete mode 100644 drivers/cpufreq/s3c2440-cpufreq.c
> delete mode 100644 drivers/cpufreq/s3c24xx-cpufreq-debugfs.c
> delete mode 100644 drivers/cpufreq/s3c24xx-cpufreq.c
> delete mode 100644 include/linux/soc/samsung/s3c-cpufreq-core.h
>
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index 8f7a1065f344..e3e0367305ec 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -180,84 +180,6 @@ config ARM_RASPBERRYPI_CPUFREQ
>
> If in doubt, say N.
>
> -config ARM_S3C_CPUFREQ
> - bool
> - help
> - Internal configuration node for common cpufreq on Samsung SoC
> -
> -config ARM_S3C24XX_CPUFREQ
> - bool "CPUfreq driver for Samsung S3C24XX series CPUs (EXPERIMENTAL)"
> - depends on ARCH_S3C24XX
> - select ARM_S3C_CPUFREQ
> - help
> - This enables the CPUfreq driver for the Samsung S3C24XX family
> - of CPUs.
> -
> - For details, take a look at <file:Documentation/cpu-freq>.
> -
> - If in doubt, say N.
> -
> -config ARM_S3C24XX_CPUFREQ_DEBUG
> - bool "Debug CPUfreq Samsung driver core"
> - depends on ARM_S3C24XX_CPUFREQ
> - help
> - Enable s3c_freq_dbg for the Samsung S3C CPUfreq core
> -
> -config ARM_S3C24XX_CPUFREQ_IODEBUG
> - bool "Debug CPUfreq Samsung driver IO timing"
> - depends on ARM_S3C24XX_CPUFREQ
> - help
> - Enable s3c_freq_iodbg for the Samsung S3C CPUfreq core
> -
> -config ARM_S3C24XX_CPUFREQ_DEBUGFS
> - bool "Export debugfs for CPUFreq"
> - depends on ARM_S3C24XX_CPUFREQ && DEBUG_FS
> - help
> - Export status information via debugfs.
> -
> -config ARM_S3C2410_CPUFREQ
> - bool
> - depends on ARM_S3C24XX_CPUFREQ && CPU_S3C2410
> - help
> - CPU Frequency scaling support for S3C2410
> -
> -config ARM_S3C2412_CPUFREQ
> - bool
> - depends on ARM_S3C24XX_CPUFREQ && CPU_S3C2412
> - default y
> - select S3C2412_IOTIMING
> - help
> - CPU Frequency scaling support for S3C2412 and S3C2413 SoC CPUs.
> -
> -config ARM_S3C2416_CPUFREQ
> - bool "S3C2416 CPU Frequency scaling support"
> - depends on CPU_S3C2416
> - help
> - This adds the CPUFreq driver for the Samsung S3C2416 and
> - S3C2450 SoC. The S3C2416 supports changing the rate of the
> - armdiv clock source and also entering a so called dynamic
> - voltage scaling mode in which it is possible to reduce the
> - core voltage of the CPU.
> -
> - If in doubt, say N.
> -
> -config ARM_S3C2416_CPUFREQ_VCORESCALE
> - bool "Allow voltage scaling for S3C2416 arm core"
> - depends on ARM_S3C2416_CPUFREQ && REGULATOR
> - help
> - Enable CPU voltage scaling when entering the dvs mode.
> - It uses information gathered through existing hardware and
> - tests but not documented in any datasheet.
> -
> - If in doubt, say N.
> -
> -config ARM_S3C2440_CPUFREQ
> - bool "S3C2440/S3C2442 CPU Frequency scaling support"
> - depends on ARM_S3C24XX_CPUFREQ && (CPU_S3C2440 || CPU_S3C2442)
> - default y
> - help
> - CPU Frequency scaling support for S3C2440 and S3C2442 SoC CPUs.
> -
> config ARM_S3C64XX_CPUFREQ
> bool "Samsung S3C64XX"
> depends on CPU_S3C6410
> diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
> index 8de99b213146..692c16e4ee55 100644
> --- a/drivers/cpufreq/Makefile
> +++ b/drivers/cpufreq/Makefile
> @@ -70,13 +70,7 @@ obj-$(CONFIG_PXA3xx) += pxa3xx-cpufreq.o
> obj-$(CONFIG_ARM_QCOM_CPUFREQ_HW) += qcom-cpufreq-hw.o
> obj-$(CONFIG_ARM_QCOM_CPUFREQ_NVMEM) += qcom-cpufreq-nvmem.o
> obj-$(CONFIG_ARM_RASPBERRYPI_CPUFREQ) += raspberrypi-cpufreq.o
> -obj-$(CONFIG_ARM_S3C2410_CPUFREQ) += s3c2410-cpufreq.o
> -obj-$(CONFIG_ARM_S3C2412_CPUFREQ) += s3c2412-cpufreq.o
> -obj-$(CONFIG_ARM_S3C2416_CPUFREQ) += s3c2416-cpufreq.o
> -obj-$(CONFIG_ARM_S3C2440_CPUFREQ) += s3c2440-cpufreq.o
> obj-$(CONFIG_ARM_S3C64XX_CPUFREQ) += s3c64xx-cpufreq.o
> -obj-$(CONFIG_ARM_S3C24XX_CPUFREQ) += s3c24xx-cpufreq.o
> -obj-$(CONFIG_ARM_S3C24XX_CPUFREQ_DEBUGFS) += s3c24xx-cpufreq-debugfs.o
> obj-$(CONFIG_ARM_S5PV210_CPUFREQ) += s5pv210-cpufreq.o
> obj-$(CONFIG_ARM_SA1110_CPUFREQ) += sa1110-cpufreq.o
> obj-$(CONFIG_ARM_SCMI_CPUFREQ) += scmi-cpufreq.o
> diff --git a/drivers/cpufreq/s3c2410-cpufreq.c b/drivers/cpufreq/s3c2410-cpufreq.c
> deleted file mode 100644
> index 5dcfbf0bfb74..000000000000
> diff --git a/drivers/cpufreq/s3c2412-cpufreq.c b/drivers/cpufreq/s3c2412-cpufreq.c
> deleted file mode 100644
> index 5945945ead7c..000000000000
> diff --git a/drivers/cpufreq/s3c2416-cpufreq.c b/drivers/cpufreq/s3c2416-cpufreq.c
> deleted file mode 100644
> index 5c221bc90210..000000000000
> diff --git a/drivers/cpufreq/s3c2440-cpufreq.c b/drivers/cpufreq/s3c2440-cpufreq.c
> deleted file mode 100644
> index 2011fb9c03a4..000000000000
> diff --git a/drivers/cpufreq/s3c24xx-cpufreq-debugfs.c b/drivers/cpufreq/s3c24xx-cpufreq-debugfs.c
> deleted file mode 100644
> index 93971dfe7c75..000000000000
> diff --git a/drivers/cpufreq/s3c24xx-cpufreq.c b/drivers/cpufreq/s3c24xx-cpufreq.c
> deleted file mode 100644
> index 7380c32b238e..000000000000
> diff --git a/include/linux/soc/samsung/s3c-cpufreq-core.h b/include/linux/soc/samsung/s3c-cpufreq-core.h
> deleted file mode 100644
> index 3b278afb769b..000000000000
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 00/21] ARM: s3c: clean out obsolete platforms
2022-10-21 20:22 [PATCH 00/21] ARM: s3c: clean out obsolete platforms Arnd Bergmann
2022-10-21 20:27 ` [PATCH 07/21] power: remove s3c adc battery driver Arnd Bergmann
2022-10-21 20:27 ` [PATCH 15/21] cpufreq: remove s3c24xx drivers Arnd Bergmann
@ 2022-10-22 15:18 ` Krzysztof Kozlowski
2022-10-22 19:48 ` Arnd Bergmann
2022-10-24 13:00 ` Rob Herring
3 siblings, 1 reply; 14+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-22 15:18 UTC (permalink / raw)
To: Arnd Bergmann, linux-arm-kernel
Cc: linux-kernel, Ben Dooks, Simtec Linux Team, Arnd Bergmann,
linux-doc, linux-samsung-soc, devicetree, patches, linux-stm32,
linux-ide, linux-clk, linux-pm, dmaengine, linux-hwmon, linux-i2c,
linux-iio, linux-input, linux-leds, linux-media, linux-mmc,
linux-mtd, linux-gpio, linux-rtc, linux-spi, linux-serial,
linux-usb, linux-fbdev, dri-devel, linux-watchdog, alsa-devel,
linux-pwm
On 21/10/2022 16:22, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The s3c24xx platform was marked as deprecated a while ago,
> and for the s3c64xx platform, we marked all except one legacy
> board file as unused.
>
> This series removes all of those, leaving only s3c64xx support
> for DT based boots as well as the cragg6410 board file.
>
> About half of the s3c specific drivers were only used on
> the now removed machines, so these drivers can be retired
> as well. I can either merge the driver removal patches through
> the soc tree along with the board file patches, or subsystem
> maintainers can pick them up into their own trees, whichever
> they prefer.
Just to be sure - do you expect me to ack the series, or rather as usual
pick them up?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 00/21] ARM: s3c: clean out obsolete platforms
2022-10-22 15:18 ` [PATCH 00/21] ARM: s3c: clean out obsolete platforms Krzysztof Kozlowski
@ 2022-10-22 19:48 ` Arnd Bergmann
0 siblings, 0 replies; 14+ messages in thread
From: Arnd Bergmann @ 2022-10-22 19:48 UTC (permalink / raw)
To: Krzysztof Kozlowski, Arnd Bergmann, linux-arm-kernel
Cc: linux-kernel, Ben Dooks, Simtec Linux Team, linux-doc,
linux-samsung-soc, devicetree, patches, linux-stm32, linux-ide,
linux-clk, linux-pm, dmaengine, linux-hwmon, linux-i2c, linux-iio,
linux-input, linux-leds, linux-media,
linux-mmc @ vger . kernel . org, linux-mtd,
open list:GPIO SUBSYSTEM, linux-rtc, linux-spi, linux-serial,
linux-usb, linux-fbdev, dri-devel, linux-watchdog, alsa-devel,
linux-pwm
On Sat, Oct 22, 2022, at 17:18, Krzysztof Kozlowski wrote:
> On 21/10/2022 16:22, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> The s3c24xx platform was marked as deprecated a while ago,
>> and for the s3c64xx platform, we marked all except one legacy
>> board file as unused.
>>
>> This series removes all of those, leaving only s3c64xx support
>> for DT based boots as well as the cragg6410 board file.
>>
>> About half of the s3c specific drivers were only used on
>> the now removed machines, so these drivers can be retired
>> as well. I can either merge the driver removal patches through
>> the soc tree along with the board file patches, or subsystem
>> maintainers can pick them up into their own trees, whichever
>> they prefer.
>
> Just to be sure - do you expect me to ack the series, or rather as usual
> pick them up?
I think in this case it is easier if I pick them up with your
Ack along with the other platforms I posted, as there are
some minor conflicts between Makefile/Kconfig changes where
I remove adjacent lines.
Arnd
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 00/21] ARM: s3c: clean out obsolete platforms
2022-10-21 20:22 [PATCH 00/21] ARM: s3c: clean out obsolete platforms Arnd Bergmann
` (2 preceding siblings ...)
2022-10-22 15:18 ` [PATCH 00/21] ARM: s3c: clean out obsolete platforms Krzysztof Kozlowski
@ 2022-10-24 13:00 ` Rob Herring
2022-10-24 13:18 ` Arnd Bergmann
3 siblings, 1 reply; 14+ messages in thread
From: Rob Herring @ 2022-10-24 13:00 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-arm-kernel, Krzysztof Kozlowski, linux-kernel, Ben Dooks,
Simtec Linux Team, Arnd Bergmann, linux-doc, linux-samsung-soc,
devicetree, patches, linux-stm32, linux-ide, linux-clk, linux-pm,
dmaengine, linux-hwmon, linux-i2c, linux-iio, linux-input,
linux-leds, linux-media, linux-mmc, linux-mtd, linux-gpio,
linux-rtc, linux-spi, linux-serial, linux-usb, linux-fbdev,
dri-devel, linux-watchdog, alsa-devel, linux-pwm
On Fri, Oct 21, 2022 at 10:22:28PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The s3c24xx platform was marked as deprecated a while ago,
> and for the s3c64xx platform, we marked all except one legacy
> board file as unused.
>
> This series removes all of those, leaving only s3c64xx support
> for DT based boots as well as the cragg6410 board file.
>
> About half of the s3c specific drivers were only used on
> the now removed machines, so these drivers can be retired
> as well. I can either merge the driver removal patches through
> the soc tree along with the board file patches, or subsystem
> maintainers can pick them up into their own trees, whichever
> they prefer.
[...]
> Documentation/arm/index.rst | 1 -
> Documentation/arm/samsung-s3c24xx/cpufreq.rst | 77 -
> .../arm/samsung-s3c24xx/eb2410itx.rst | 59 -
> Documentation/arm/samsung-s3c24xx/gpio.rst | 172 --
> Documentation/arm/samsung-s3c24xx/h1940.rst | 41 -
> Documentation/arm/samsung-s3c24xx/index.rst | 20 -
> Documentation/arm/samsung-s3c24xx/nand.rst | 30 -
> .../arm/samsung-s3c24xx/overview.rst | 311 ---
> Documentation/arm/samsung-s3c24xx/s3c2412.rst | 121 -
> Documentation/arm/samsung-s3c24xx/s3c2413.rst | 22 -
> .../arm/samsung-s3c24xx/smdk2440.rst | 57 -
> Documentation/arm/samsung-s3c24xx/suspend.rst | 137 --
> .../arm/samsung-s3c24xx/usb-host.rst | 91 -
> Documentation/arm/samsung/overview.rst | 13 -
What about?:
Documentation/devicetree/bindings/clock/samsung,s3c2410-clock.txt
Documentation/devicetree/bindings/interrupt-controller/samsung,s3c24xx-irq.txt
Documentation/devicetree/bindings/mmc/samsung,s3cmci.txt
Documentation/devicetree/bindings/mtd/samsung-s3c2410.txt
Documentation/devicetree/bindings/usb/s3c2410-usb.txt
Rob
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 00/21] ARM: s3c: clean out obsolete platforms
2022-10-24 13:00 ` Rob Herring
@ 2022-10-24 13:18 ` Arnd Bergmann
0 siblings, 0 replies; 14+ messages in thread
From: Arnd Bergmann @ 2022-10-24 13:18 UTC (permalink / raw)
To: Rob Herring, Arnd Bergmann
Cc: linux-arm-kernel, Krzysztof Kozlowski, linux-kernel, Ben Dooks,
Simtec Linux Team, linux-doc, linux-samsung-soc, devicetree,
patches, linux-stm32, linux-ide, linux-clk, linux-pm, dmaengine,
linux-hwmon, linux-i2c, linux-iio, linux-input, linux-leds,
linux-media, linux-mmc @ vger . kernel . org, linux-mtd,
open list:GPIO SUBSYSTEM, linux-rtc, linux-spi, linux-serial,
linux-usb, linux-fbdev, dri-devel, linux-watchdog, alsa-devel,
linux-pwm
On Mon, Oct 24, 2022, at 15:00, Rob Herring wrote:
> On Fri, Oct 21, 2022 at 10:22:28PM +0200, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> The s3c24xx platform was marked as deprecated a while ago,
>> and for the s3c64xx platform, we marked all except one legacy
>> board file as unused.
>>
>> This series removes all of those, leaving only s3c64xx support
>> for DT based boots as well as the cragg6410 board file.
>>
>> About half of the s3c specific drivers were only used on
>> the now removed machines, so these drivers can be retired
>> as well. I can either merge the driver removal patches through
>> the soc tree along with the board file patches, or subsystem
>> maintainers can pick them up into their own trees, whichever
>> they prefer.
>
> [...]
>
>> Documentation/arm/index.rst | 1 -
>> Documentation/arm/samsung-s3c24xx/cpufreq.rst | 77 -
>> .../arm/samsung-s3c24xx/eb2410itx.rst | 59 -
>> Documentation/arm/samsung-s3c24xx/gpio.rst | 172 --
>> Documentation/arm/samsung-s3c24xx/h1940.rst | 41 -
>> Documentation/arm/samsung-s3c24xx/index.rst | 20 -
>> Documentation/arm/samsung-s3c24xx/nand.rst | 30 -
>> .../arm/samsung-s3c24xx/overview.rst | 311 ---
>> Documentation/arm/samsung-s3c24xx/s3c2412.rst | 121 -
>> Documentation/arm/samsung-s3c24xx/s3c2413.rst | 22 -
>> .../arm/samsung-s3c24xx/smdk2440.rst | 57 -
>> Documentation/arm/samsung-s3c24xx/suspend.rst | 137 --
>> .../arm/samsung-s3c24xx/usb-host.rst | 91 -
>> Documentation/arm/samsung/overview.rst | 13 -
>
> What about?:
>
> Documentation/devicetree/bindings/clock/samsung,s3c2410-clock.txt
> Documentation/devicetree/bindings/interrupt-controller/samsung,s3c24xx-irq.txt
> Documentation/devicetree/bindings/mmc/samsung,s3cmci.txt
Good catch!
I've removed these three now and and will add the removal to
the same patch, also the related
samsung,s3c2412-clock.txt and samsung,s3c2443-clock.txt
files.
> Documentation/devicetree/bindings/mtd/samsung-s3c2410.txt
samsung,s3c2412-nand is apparently still used on s3c6400,
and the driver is selectable on that platform, so I think
that should remain in there until we remove s3c64xx in 2024,
even if it is not referenced by the dts files in the kernel.
> Documentation/devicetree/bindings/usb/s3c2410-usb.txt
Similarly, the driver is used on the crag6410 board
(without DT), and probably just works with the DT based
boards if one adds a node to s3c64xx.dtsi.
I've also checked if any of the other removed drivers
matches of_device_id[] strings to see if there are more
bindings to kill off, but I don't see any that have
now become obsolete. It did point me to pxa2xx_ac97_dt_ids,
which Robert already complained about, this apparently
is still used with dts files outside of mainline.
Arnd
^ permalink raw reply [flat|nested] 14+ messages in thread