* [PATCH] ina3221: Fix shunt sum critical calculation
@ 2022-11-08 4:45 Ninad Malwade
2022-11-08 13:25 ` Thierry Reding
2022-11-11 16:27 ` Guenter Roeck
0 siblings, 2 replies; 3+ messages in thread
From: Ninad Malwade @ 2022-11-08 4:45 UTC (permalink / raw)
To: nmalwade, treding, jonathanh, linux, jdelvare, nicolinc,
rkasirajan
Cc: linux-hwmon, linux-kernel, linux-pm
The shunt sum critical limit register value should be left shifted
by one bit as its LSB-0 is a reserved bit.
Signed-off-by: Ninad Malwade <nmalwade@nvidia.com>
---
drivers/hwmon/ina3221.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hwmon/ina3221.c b/drivers/hwmon/ina3221.c
index 2a57f4b60c29..e06186986444 100644
--- a/drivers/hwmon/ina3221.c
+++ b/drivers/hwmon/ina3221.c
@@ -228,7 +228,7 @@ static int ina3221_read_value(struct ina3221_data *ina, unsigned int reg,
* Shunt Voltage Sum register has 14-bit value with 1-bit shift
* Other Shunt Voltage registers have 12 bits with 3-bit shift
*/
- if (reg == INA3221_SHUNT_SUM)
+ if (reg == INA3221_SHUNT_SUM || reg == INA3221_CRIT_SUM)
*val = sign_extend32(regval >> 1, 14);
else
*val = sign_extend32(regval >> 3, 12);
@@ -465,7 +465,7 @@ static int ina3221_write_curr(struct device *dev, u32 attr,
* SHUNT_SUM: (1 / 40uV) << 1 = 1 / 20uV
* SHUNT[1-3]: (1 / 40uV) << 3 = 1 / 5uV
*/
- if (reg == INA3221_SHUNT_SUM)
+ if (reg == INA3221_SHUNT_SUM || reg == INA3221_CRIT_SUM)
regval = DIV_ROUND_CLOSEST(voltage_uv, 20) & 0xfffe;
else
regval = DIV_ROUND_CLOSEST(voltage_uv, 5) & 0xfff8;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ina3221: Fix shunt sum critical calculation
2022-11-08 4:45 [PATCH] ina3221: Fix shunt sum critical calculation Ninad Malwade
@ 2022-11-08 13:25 ` Thierry Reding
2022-11-11 16:27 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2022-11-08 13:25 UTC (permalink / raw)
To: Ninad Malwade
Cc: jonathanh, linux, jdelvare, nicolinc, rkasirajan, linux-hwmon,
linux-kernel, linux-pm
[-- Attachment #1: Type: text/plain, Size: 404 bytes --]
On Tue, Nov 08, 2022 at 12:45:08PM +0800, Ninad Malwade wrote:
> The shunt sum critical limit register value should be left shifted
> by one bit as its LSB-0 is a reserved bit.
>
> Signed-off-by: Ninad Malwade <nmalwade@nvidia.com>
> ---
> drivers/hwmon/ina3221.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Looks correct:
Reviewed-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ina3221: Fix shunt sum critical calculation
2022-11-08 4:45 [PATCH] ina3221: Fix shunt sum critical calculation Ninad Malwade
2022-11-08 13:25 ` Thierry Reding
@ 2022-11-11 16:27 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2022-11-11 16:27 UTC (permalink / raw)
To: Ninad Malwade
Cc: treding, jonathanh, jdelvare, nicolinc, rkasirajan, linux-hwmon,
linux-kernel, linux-pm
On Tue, Nov 08, 2022 at 12:45:08PM +0800, Ninad Malwade wrote:
> The shunt sum critical limit register value should be left shifted
> by one bit as its LSB-0 is a reserved bit.
>
> Signed-off-by: Ninad Malwade <nmalwade@nvidia.com>
> Reviewed-by: Thierry Reding <treding@nvidia.com>
Applied.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-11 16:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-08 4:45 [PATCH] ina3221: Fix shunt sum critical calculation Ninad Malwade
2022-11-08 13:25 ` Thierry Reding
2022-11-11 16:27 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox