From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C664EC4332F for ; Tue, 15 Nov 2022 13:50:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238553AbiKONu5 (ORCPT ); Tue, 15 Nov 2022 08:50:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238558AbiKONu2 (ORCPT ); Tue, 15 Nov 2022 08:50:28 -0500 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E200D24962; Tue, 15 Nov 2022 05:49:52 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id E83D780E0; Tue, 15 Nov 2022 13:39:51 +0000 (UTC) Date: Tue, 15 Nov 2022 15:49:50 +0200 From: Tony Lindgren To: Ivaylo Dimitrov Cc: Sebastian Reichel , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, philipp@uvos.xyz, Pavel Machek Subject: Re: [PATCH 2/3] power: supply: cpcap-battery: Fix battery identification Message-ID: References: <1667647544-12945-1-git-send-email-ivo.g.dimitrov.75@gmail.com> <1667647544-12945-3-git-send-email-ivo.g.dimitrov.75@gmail.com> <20221110160559.bsvzr4txum5ed2qz@mercury.elektranox.org> <715a60b5-2f3c-caf7-2b24-61ec92bda9be@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <715a60b5-2f3c-caf7-2b24-61ec92bda9be@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi, * Ivaylo Dimitrov [221110 16:40]: > On 10.11.22 г. 18:05 ч., Sebastian Reichel wrote: > > Why do we care? > > > Because if we know the battery is genuine (or at least pretends to be :) ), > then we can read battery parameters from nvram, see patch 3/3. This will > allow us to charge HV LiPo batteries to 4.35V, using the full capacity. Let's not enable charge voltages above 4.2V automatically at all unless the user chooses to set a higher charge voltage via sysfs manually. We have had reports of bloated batteries if left connected to the charger at higher voltage than 4.2V. This seems to happen after connected for some weeks or months. AFAIK this happens both with Android and mainline kernel at higher voltages. For more information, please see commit d4ee021c410f ("power: supply: cpcap-charger: Limit voltage to 4.2V for battery"). No objections for using the NVRAM to detect the battery max voltages though. That is as long as the default charge voltage does not go above 4.2V. Regards, Tony