From: Petr Mladek <pmladek@suse.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: "Linux PM" <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Thomas Weißschuh" <linux@weissschuh.net>,
"Lukas Bulwahn" <lukas.bulwahn@gmail.com>,
"Joe Perches" <joe@perches.com>,
"Todd Brandt" <todd.e.brandt@linux.intel.com>
Subject: Re: [PATCH v1 0/2] PM: sleep: Avoid using pr_cont() in tasks freezing code
Date: Tue, 6 Dec 2022 09:22:14 +0100 [thread overview]
Message-ID: <Y477tlqofSqUpd8M@alley> (raw)
In-Reply-To: <4441789.LvFx2qVVIh@kreacher>
On Thu 2022-12-01 19:31:59, Rafael J. Wysocki wrote:
> Hi All,
>
> The first patch in this series rearranges the tasks freezing code used during
> system-wide suspend and hibernation to avoid printing continuation messages
> with pr_cont() which is problematic.
>
> The second patch refines one more message in that code on top of the first one.
Both patches seems to do what they are supposed to do. Feel free to use:
Reviewed-by: Petr Mladek <pmladek@suse.com>
That said, I am not familiar with the freezer code. For example, I was
not aware of linux-pm/tools/power/pm-graph/sleepgraph.py. Anyway,
both changes make perfect sense and I do not see any problem.
Best Regards,
Petr
prev parent reply other threads:[~2022-12-06 8:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 18:31 [PATCH v1 0/2] PM: sleep: Avoid using pr_cont() in tasks freezing code Rafael J. Wysocki
2022-12-01 18:33 ` [PATCH v1 1/2] PM: sleep: Avoid using pr_cont() in the " Rafael J. Wysocki
2022-12-01 18:34 ` [PATCH v1 2/2] PM: sleep: Refine error message in try_to_freeze_tasks() Rafael J. Wysocki
2022-12-06 8:22 ` Petr Mladek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y477tlqofSqUpd8M@alley \
--to=pmladek@suse.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=lukas.bulwahn@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=todd.e.brandt@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).