From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B91BEC352A1 for ; Tue, 6 Dec 2022 10:20:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230233AbiLFKUJ (ORCPT ); Tue, 6 Dec 2022 05:20:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229867AbiLFKUJ (ORCPT ); Tue, 6 Dec 2022 05:20:09 -0500 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2312B658A; Tue, 6 Dec 2022 02:20:08 -0800 (PST) Received: from zn.tnic (p200300ea9733e7ff329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e7ff:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id B64801EC064F; Tue, 6 Dec 2022 11:20:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1670322006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=sl4e+RriZSOsyS4K085UmZxwSNVZxIS3S1lRJkgBgQI=; b=pRzA9pRiF2c0RJHu4ytcZU/OtYCGeVKjbSufHl9zu/Lg71N/HsKRNiuffGaoMtBDDvkU9u YbafEcQpF4Bf7Py9x2Zf9Gd+zb51B/OEz+Y4VZu0NBC/dexDiNV2n2bL/n+tsJm7ejqw07 mSxtk4lJXpoLJFMrWc1iPcG24Y1TPYs= Date: Tue, 6 Dec 2022 11:20:02 +0100 From: Borislav Petkov To: stuart hayes Cc: "Rafael J . Wysocki" , Viresh Kumar , Kyle Meyer , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cpufreq: acpi: Only set boost MSRs on supported CPUs Message-ID: References: <20221205175744.9746-1-stuart.w.hayes@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Mon, Dec 05, 2022 at 12:07:05PM -0600, stuart hayes wrote: > > > On 12/5/2022 11:57 AM, Stuart Hayes wrote: > > Stop trying to set boost MSRs on CPUs that don't support boost. > > > > This corrects a bug in the recent patch "Defer setting boost MSRs". > > > > Signed-off-by: Stuart Hayes > > --- > > drivers/cpufreq/acpi-cpufreq.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c > > index bb58175a8d40..a7c5e312340e 100644 > > --- a/drivers/cpufreq/acpi-cpufreq.c > > +++ b/drivers/cpufreq/acpi-cpufreq.c > > @@ -888,7 +888,8 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy) > > if (perf->states[0].core_frequency * 1000 != freq_table[0].frequency) > > pr_warn(FW_WARN "P-state 0 is not max freq\n"); > > - set_boost(policy, acpi_cpufreq_driver.boost_enabled); > > + if (acpi_cpufreq_driver.set_boost) > > + set_boost(policy, acpi_cpufreq_driver.boost_enabled); > > return result; > > My apologies--adding Boris, I forgot to put him on the "to" list. Yap, that does it. Reported-by: Borislav Petkov (AMD) Tested-by: Borislav Petkov (AMD) Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette