From: Borislav Petkov <bp@alien8.de>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Kishon Vijay Abraham I <kvijayab@amd.com>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Santosh Shukla <santosh.shukla@amd.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Borislav Petkov <bpetkov@amd.com>, Leo Duran <leo.duran@amd.com>
Subject: Re: [PATCH v2] x86/acpi/boot: Do not register processors that cannot be onlined for x2apic
Date: Thu, 5 Jan 2023 23:22:04 +0100 [thread overview]
Message-ID: <Y7dNjHXJJwzCtYOY@zn.tnic> (raw)
In-Reply-To: <CAJZ5v0g1Mu8ip68one_gsAR3xmyua+6m1uJqb3n92xxYWeR+FA@mail.gmail.com>
On Thu, Jan 05, 2023 at 06:09:59PM +0100, Rafael J. Wysocki wrote:
> On Thu, Jan 5, 2023 at 5:11 AM Kishon Vijay Abraham I <kvijayab@amd.com> wrote:
> >
> > Section 5.2.12.12 Processor Local x2APIC Structure in the ACPI v6.5
> > spec mandates that both "enabled" and "online capable" Local APIC Flags
> > should be used to determine if the processor is usable or not.
> >
> > However, Linux doesn't use the "online capable" flag for x2APIC to
> > determine if the processor is usable. As a result, cpu_possible_mask has
> > incorrect value and results in more memory getting allocated for per_cpu
> > variables than it is going to be used.
> >
> > Make sure Linux parses both "enabled" and "online capable" flags for
> > x2APIC to correctly determine if the processor is usable.
> >
> > Fixes: aa06e20f1be6 ("x86/ACPI: Don't add CPUs that are not online capable")
> > Reviewed-by: Borislav Petkov (AMD) <bp@alien8.de>
> > Reported-by: Leo Duran <leo.duran@amd.com>
> > Signed-off-by: Kishon Vijay Abraham I <kvijayab@amd.com>
>
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Are you saying, I should take it through tip?
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2023-01-05 22:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 4:10 [PATCH v2] x86/acpi/boot: Do not register processors that cannot be onlined for x2apic Kishon Vijay Abraham I
2023-01-05 17:09 ` Rafael J. Wysocki
2023-01-05 22:22 ` Borislav Petkov [this message]
2023-01-10 13:03 ` Rafael J. Wysocki
2023-01-10 18:23 ` Borislav Petkov
2023-01-06 0:57 ` Zhang, Rui
2023-04-02 10:41 ` Guy Durrieu
2023-04-02 10:57 ` Borislav Petkov
2023-04-02 13:13 ` Guy Durrieu
2023-04-02 15:18 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7dNjHXJJwzCtYOY@zn.tnic \
--to=bp@alien8.de \
--cc=bpetkov@amd.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kvijayab@amd.com \
--cc=len.brown@intel.com \
--cc=leo.duran@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=santosh.shukla@amd.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox