From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 192A0C3DA7A for ; Thu, 5 Jan 2023 22:22:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230264AbjAEWWO (ORCPT ); Thu, 5 Jan 2023 17:22:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235813AbjAEWWN (ORCPT ); Thu, 5 Jan 2023 17:22:13 -0500 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D9FE6951E; Thu, 5 Jan 2023 14:22:10 -0800 (PST) Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 377401EC068E; Thu, 5 Jan 2023 23:22:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1672957329; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=czOsQmD34pjViax7atABy4fDrkAQPndgTpUtqjimrFc=; b=dwRsEjjz/U8PKiJy/nHt/KsevM+xMAesCHF5IaybVIbL1Cz7WLi8TMwrCmwxEQYapsSxte nssirL3xUjhN8lkbuVAhpi+HwnDg6NCPanriRkM39q9fF1dzN5bS9XKi0s0T3m38wDQf5o zmOQS5MeXyyLCoXAX2fYHJwVdWb+dzY= Date: Thu, 5 Jan 2023 23:22:04 +0100 From: Borislav Petkov To: "Rafael J. Wysocki" Cc: Kishon Vijay Abraham I , Len Brown , Pavel Machek , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Santosh Shukla , Suravee Suthikulpanit , Borislav Petkov , Leo Duran Subject: Re: [PATCH v2] x86/acpi/boot: Do not register processors that cannot be onlined for x2apic Message-ID: References: <20230105041059.39366-1-kvijayab@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Thu, Jan 05, 2023 at 06:09:59PM +0100, Rafael J. Wysocki wrote: > On Thu, Jan 5, 2023 at 5:11 AM Kishon Vijay Abraham I wrote: > > > > Section 5.2.12.12 Processor Local x2APIC Structure in the ACPI v6.5 > > spec mandates that both "enabled" and "online capable" Local APIC Flags > > should be used to determine if the processor is usable or not. > > > > However, Linux doesn't use the "online capable" flag for x2APIC to > > determine if the processor is usable. As a result, cpu_possible_mask has > > incorrect value and results in more memory getting allocated for per_cpu > > variables than it is going to be used. > > > > Make sure Linux parses both "enabled" and "online capable" flags for > > x2APIC to correctly determine if the processor is usable. > > > > Fixes: aa06e20f1be6 ("x86/ACPI: Don't add CPUs that are not online capable") > > Reviewed-by: Borislav Petkov (AMD) > > Reported-by: Leo Duran > > Signed-off-by: Kishon Vijay Abraham I > > Acked-by: Rafael J. Wysocki Are you saying, I should take it through tip? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette