From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: mingo@kernel.org, will@kernel.org, boqun.feng@gmail.com,
mark.rutland@arm.com, tglx@linutronix.de, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
seanjc@google.com, pbonzini@redhat.com, jgross@suse.com,
srivatsa@csail.mit.edu, amakhalov@vmware.com,
pv-drivers@vmware.com, mhiramat@kernel.org,
wanpengli@tencent.com, vkuznets@redhat.com,
boris.ostrovsky@oracle.com, rafael@kernel.org,
daniel.lezcano@linaro.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
vschneid@redhat.com, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
linux-trace-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 3/6] ftrace/x86: Warn and ignore graph tracing when RCU is disabled
Date: Tue, 24 Jan 2023 15:44:35 +0100 [thread overview]
Message-ID: <Y8/u00WHGElMDjoo@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20230123170753.7ac9419e@gandalf.local.home>
On Mon, Jan 23, 2023 at 05:07:53PM -0500, Steven Rostedt wrote:
> Actually, perhaps we can just add this, and all you need to do is create
> and set CONFIG_NO_RCU_TRACING (or some other name).
Elsewhere I've used CONFIG_ARCH_WANTS_NO_INSTR for this.
Anyway, I took it for a spin and it .... doesn't seems to do the job.
With my patch the first splat is
"RCU not on for: cpuidle_poll_time+0x0/0x70"
While with yours I seems to get the endless:
"WARNING: suspicious RCU usage"
thing. Let me see if I can figure out where it goes side-ways.
next prev parent reply other threads:[~2023-01-24 14:45 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 20:50 [PATCH 0/6] A few cpuidle vs rcu fixes Peter Zijlstra
2023-01-23 20:50 ` [PATCH 1/6] x86: Always inline arch_atomic64 Peter Zijlstra
2023-01-23 20:50 ` [PATCH 2/6] x86/pvclock: improve atomic update of last_value in pvclock_clocksource_read Peter Zijlstra
2023-01-23 20:50 ` [PATCH 3/6] ftrace/x86: Warn and ignore graph tracing when RCU is disabled Peter Zijlstra
2023-01-23 21:53 ` Steven Rostedt
2023-01-23 22:07 ` Steven Rostedt
2023-01-24 14:44 ` Peter Zijlstra [this message]
2023-01-24 17:12 ` Mark Rutland
2023-01-25 9:37 ` Peter Zijlstra
2023-01-25 10:47 ` Peter Zijlstra
2023-01-25 11:32 ` Mark Rutland
2023-01-25 18:46 ` Paul E. McKenney
2023-01-26 9:28 ` Peter Zijlstra
2023-01-28 19:12 ` Paul E. McKenney
2023-01-23 20:50 ` [PATCH 4/6] x86: Mark sched_clock() noinstr Peter Zijlstra
2023-01-23 20:50 ` [PATCH 5/6] sched/clock: Make local_clock() noinstr Peter Zijlstra
2023-01-23 20:50 ` [PATCH 6/6] cpuidle: Fix poll_idle() noinstr annotation Peter Zijlstra
2023-01-24 14:24 ` Rafael J. Wysocki
2023-01-24 16:34 ` [PATCH 0/6] A few cpuidle vs rcu fixes Mark Rutland
2023-01-24 17:30 ` Mark Rutland
2023-01-24 18:39 ` Mark Rutland
2023-01-25 9:35 ` Peter Zijlstra
2023-01-25 9:40 ` Peter Zijlstra
2023-01-25 10:23 ` Mark Rutland
2023-01-25 9:31 ` Peter Zijlstra
2023-01-25 9:36 ` Mark Rutland
2023-01-25 15:20 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8/u00WHGElMDjoo@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=amakhalov@vmware.com \
--cc=boqun.feng@gmail.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=daniel.lezcano@linaro.org \
--cc=dave.hansen@linux.intel.com \
--cc=dietmar.eggemann@arm.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=juri.lelli@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mgorman@suse.de \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=pbonzini@redhat.com \
--cc=pv-drivers@vmware.com \
--cc=rafael@kernel.org \
--cc=rostedt@goodmis.org \
--cc=seanjc@google.com \
--cc=srivatsa@csail.mit.edu \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=vkuznets@redhat.com \
--cc=vschneid@redhat.com \
--cc=wanpengli@tencent.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).