From: Stephan Gerhold <stephan@gerhold.net>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, djakov@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, benl@squareup.com,
shawn.guo@linaro.org, fabien.parent@linaro.org,
leo.yan@linaro.org, dmitry.baryshkov@linaro.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v3 1/8] dt-bindings: arm: qcom: Document MSM8939 SoC binding
Date: Wed, 18 Jan 2023 09:47:28 +0100 [thread overview]
Message-ID: <Y8eyIO8BqKzvulbB@gerhold.net> (raw)
In-Reply-To: <20230117024846.1367794-2-bryan.odonoghue@linaro.org>
On Tue, Jan 17, 2023 at 02:48:39AM +0000, Bryan O'Donoghue wrote:
> Document the MSM8939 and supported boards in upstream Sony "Tulip" M4 Aqua
> and Square APQ8039 T2.
>
> MSM8939 is one of the older SoCs so we need to expand the list of
> qcom,board-ids to allow for the bootloader DTS board-id matching
> dependency.
>
The original LK bootloaders cannot boot your msm8939.dtsi correctly,
because a spin-table implementation is required to get the other CPU
cores up. This means that a modified bootloader is always needed from
the upstream point of view, since I doubt anyone wants to use these
devices with a single core only. lk2nd (as the primary spin-table
implementation right now) has never required qcom,board-ids and any
custom LK would be easy to patch to ignore these.
Do you already have a bootloader with spin-table support deployed in the
field that can be no longer easily modified to ignore the qcom,board-id?
If not, and you're planning to keep using the downstream patches to
bring the CPU cores up without spin-table/PSCI then you might as well
add the qcom,board-id as downstream patch as well.
If we don't support the original bootloaders in a usable way upstream
then we should not add MSM8939 to the allow list of broken bootloaders
either, in my opinion.
Thanks,
Stephan
next prev parent reply other threads:[~2023-01-18 9:28 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 2:48 [PATCH v3 0/8] Add MSM8939 SoC support with two devices Bryan O'Donoghue
2023-01-17 2:48 ` [PATCH v3 1/8] dt-bindings: arm: qcom: Document MSM8939 SoC binding Bryan O'Donoghue
2023-01-18 8:47 ` Stephan Gerhold [this message]
2023-01-18 12:05 ` Bryan O'Donoghue
2023-01-18 15:43 ` Stephan Gerhold
2023-01-19 0:32 ` Bryan O'Donoghue
2023-01-17 2:48 ` [PATCH v3 2/8] dt-bindings: soc: qcom: smd-rpm: Exclude MSM8936 from glink-channels Bryan O'Donoghue
2023-01-17 2:48 ` [PATCH v3 3/8] dt-bindings: interconnect: Exclude all non msm8939 from snoc-mm Bryan O'Donoghue
2023-01-17 11:04 ` Krzysztof Kozlowski
2023-01-17 2:48 ` [PATCH v3 4/8] clk: qcom: smd-rpm: msm8936: Add PMIC gated RPM_SMD_XO_* Bryan O'Donoghue
2023-01-18 13:49 ` Konrad Dybcio
2023-01-17 2:48 ` [PATCH v3 5/8] arm64: dts: qcom: Add msm8939 SoC Bryan O'Donoghue
2023-01-17 20:58 ` Bjorn Andersson
2023-01-17 22:48 ` Bryan O'Donoghue
2023-01-18 5:09 ` Bjorn Andersson
2023-01-20 0:40 ` Bryan O'Donoghue
2023-01-20 0:42 ` Bryan O'Donoghue
2023-01-20 0:45 ` Bryan O'Donoghue
2023-01-18 9:59 ` Stephan Gerhold
2023-01-18 11:50 ` Bryan O'Donoghue
2023-01-18 12:50 ` Bryan O'Donoghue
2023-01-18 17:33 ` Stephan Gerhold
2023-01-19 0:53 ` Bryan O'Donoghue
2023-01-21 22:57 ` Bryan O'Donoghue
2023-01-17 2:48 ` [PATCH v3 6/8] arm64: dts: qcom: Add msm8939-pm8916.dtsi include Bryan O'Donoghue
2023-01-18 13:49 ` Konrad Dybcio
2023-01-17 2:48 ` [PATCH v3 7/8] arm64: dts: qcom: Add Square apq8039-t2 board Bryan O'Donoghue
2023-01-17 21:06 ` Bjorn Andersson
2023-01-17 2:48 ` [PATCH v3 8/8] arm64: dts: qcom: Add msm8939 Sony Xperia M4 Aqua Bryan O'Donoghue
2023-01-18 14:42 ` Konrad Dybcio
2023-01-18 15:11 ` Bryan O'Donoghue
2023-01-18 22:50 ` (subset) [PATCH v3 0/8] Add MSM8939 SoC support with two devices Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8eyIO8BqKzvulbB@gerhold.net \
--to=stephan@gerhold.net \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=benl@squareup.com \
--cc=bryan.odonoghue@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=fabien.parent@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox