From: Abel Vesa <abel.vesa@linaro.org>
To: Peng Fan <peng.fan@nxp.com>, djakov@kernel.org
Cc: Mike Tipton <quic_mdtipton@quicinc.com>,
Vivek Aknurwar <quic_viveka@quicinc.com>,
djakov@kernel.org, quic_okukatla@quicinc.com,
linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
"abel >> Philipp Zabel" <p.zabel@pengutronix.de>,
abelvesa@kernel.org,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Subject: Re: [PATCH] interconnect: Skip call into provider if initial bw is zero
Date: Mon, 30 Jan 2023 16:53:28 +0200 [thread overview]
Message-ID: <Y9fZ6GUzWsCMXzba@linaro.org> (raw)
In-Reply-To: <742ff9cd-e7be-11b8-3805-5b60aba6b2f1@linaro.org>
On 23-01-23 22:58:49, Bryan O'Donoghue wrote:
> On 23/01/2023 20:37, Mike Tipton wrote:
> >
> > This isn't actually changing it for all providers. Only for those that
> > define the get_bw() callback. Right now that's only qcom/msm8974 and
> > imx/imx. If get_bw() isn't defined, then icc_node_add() defaults to
> > INT_MAX. So, the logical behavior in that case is unchanged. Which means
> > this isn't even changing the behavior for rpmh yet, either.
>
> Yes that adds up.
>
> Looking at the commit for get_bw() for the 8974, I think this change would
> be OK with the intent of this commit
>
> commit 9caf2d956cfa254c6d89c5f4d7b3f8235d75b28f
> Author: Georgi Djakov <georgi.djakov@linaro.org>
> Date: Mon Nov 9 14:45:12 2020 +0200
>
> @Abel what effect will skipping pre->aggregation() have on i.MX ?
I don't think there is any impact on i.MX platforms.
Peng, any input?
>
> ---
> bod
next prev parent reply other threads:[~2023-01-30 14:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 22:07 [PATCH] interconnect: Skip call into provider if initial bw is zero Vivek Aknurwar
2023-01-14 1:24 ` Bryan O'Donoghue
2023-01-14 1:40 ` Bryan O'Donoghue
2023-01-19 22:18 ` Vivek Aknurwar
2023-01-19 23:56 ` Bryan O'Donoghue
2023-01-23 20:37 ` Mike Tipton
2023-01-23 22:58 ` Bryan O'Donoghue
2023-01-30 14:53 ` Abel Vesa [this message]
2023-01-30 21:55 ` Mike Tipton
2023-02-12 10:56 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9fZ6GUzWsCMXzba@linaro.org \
--to=abel.vesa@linaro.org \
--cc=abelvesa@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=djakov@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=peng.fan@nxp.com \
--cc=quic_mdtipton@quicinc.com \
--cc=quic_okukatla@quicinc.com \
--cc=quic_viveka@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).