linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	lukasz.luba@arm.com, rafael@kernel.org
Subject: Re: [PATCH v5 2/5] powercap/drivers/dtpm: Create a registering system
Date: Wed, 31 Mar 2021 20:06:46 +0200	[thread overview]
Message-ID: <YGS6NraFr6+qvzda@kroah.com> (raw)
In-Reply-To: <20210331110048.24956-2-daniel.lezcano@linaro.org>

On Wed, Mar 31, 2021 at 01:00:45PM +0200, Daniel Lezcano wrote:
> +struct dtpm *dtpm_lookup(const char *name);
> +
> +int dtpm_add(const char *name, struct dtpm *dtpm);
> +
> +void dtpm_del(const char *name);

You can not add new kernel apis that have no user.  How do you know if
they actually work or not?  We have no idea as we do not see anyone
using them :(

So no need to add things with no user, feel free to just drop this patch
until you have one.

thanks,

greg k-h

  parent reply	other threads:[~2021-03-31 18:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-31 11:00 [PATCH v5 1/5] powercap/drivers/dtpm: Encapsulate even more the code Daniel Lezcano
2021-03-31 11:00 ` [PATCH v5 2/5] powercap/drivers/dtpm: Create a registering system Daniel Lezcano
2021-03-31 18:04   ` Greg KH
2021-03-31 18:06   ` Greg KH [this message]
2021-03-31 20:46     ` Daniel Lezcano
2021-04-01  6:02       ` Greg KH
2021-04-01  7:01         ` Daniel Lezcano
2021-03-31 11:00 ` [PATCH v5 3/5] powercap/drivers/dtpm: Simplify the dtpm table Daniel Lezcano
2021-03-31 11:00 ` [PATCH v5 4/5] powercap/drivers/dtpm: Use container_of instead of a private data field Daniel Lezcano
2021-03-31 11:00 ` [PATCH v5 5/5] powercap/drivers/dtpm: Scale the power with the load Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YGS6NraFr6+qvzda@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).