From: Ingo Molnar <mingo@kernel.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
the arch/x86 maintainers <x86@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Linux PM <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/acpi: Switch to pr_xxx log functions
Date: Fri, 14 May 2021 12:20:22 +0200 [thread overview]
Message-ID: <YJ5O5gytKMDOCnFz@gmail.com> (raw)
In-Reply-To: <CAJZ5v0h0Z3pfwpL2SsJ53=SfqE2d+7PrG+nt0PXjYrqeAkc27g@mail.gmail.com>
* Rafael J. Wysocki <rafael@kernel.org> wrote:
> On Fri, May 14, 2021 at 9:07 AM Ingo Molnar <mingo@kernel.org> wrote:
> >
> >
> > * Heiner Kallweit <hkallweit1@gmail.com> wrote:
> >
> > > Switching to pr_debug et al has two benefits:
> > > - We don't have to add PREFIX to each log statement
> > > - Debug output is suppressed except DEBUG is defined or dynamic
> > > debugging is enabled for the respective code piece.
> > >
> > > In addition ensure that longer messages aren't split to multiple lines
> > > in source code, checkpatch complains otherwise.
> > >
> > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> > > ---
> > > arch/x86/kernel/acpi/boot.c | 118 ++++++++++++++----------------------
> > > 1 file changed, 47 insertions(+), 71 deletions(-)
> >
> > Reviewed-by: Ingo Molnar <mingo@kernel.org>
>
> So I'm going to take this through the ACPI tree if that's OK.
Sure!
Thanks,
Ingo
next prev parent reply other threads:[~2021-05-14 10:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 13:33 [PATCH] x86/acpi: Switch to pr_xxx log functions Heiner Kallweit
2021-05-13 16:01 ` Pavel Machek
2021-05-14 7:07 ` Ingo Molnar
2021-05-14 10:11 ` Rafael J. Wysocki
2021-05-14 10:20 ` Ingo Molnar [this message]
2021-05-17 15:31 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJ5O5gytKMDOCnFz@gmail.com \
--to=mingo@kernel.org \
--cc=bp@alien8.de \
--cc=hkallweit1@gmail.com \
--cc=hpa@zytor.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).