* [PATCH] PM / wakeirq: move to use request_irq by IRQF_NO_AUTOEN flag
@ 2021-05-20 7:34 Tian Tao
2021-05-21 16:57 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Tian Tao @ 2021-05-20 7:34 UTC (permalink / raw)
To: rjw, len.brown, pavel, gregkh; +Cc: linux-pm, Tian Tao
request_irq() after setting IRQ_NOAUTOEN as below
irq_set_status_flags(irq, IRQ_NOAUTOEN);
request_irq(dev, irq...);
can be replaced by request_irq() with IRQF_NO_AUTOEN flag.
this change is just to simplify the code, no actual functional changes.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/base/power/wakeirq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/base/power/wakeirq.c b/drivers/base/power/wakeirq.c
index 8e02108..3bad326 100644
--- a/drivers/base/power/wakeirq.c
+++ b/drivers/base/power/wakeirq.c
@@ -182,7 +182,6 @@ int dev_pm_set_dedicated_wake_irq(struct device *dev, int irq)
wirq->dev = dev;
wirq->irq = irq;
- irq_set_status_flags(irq, IRQ_NOAUTOEN);
/* Prevent deferred spurious wakeirqs with disable_irq_nosync() */
irq_set_status_flags(irq, IRQ_DISABLE_UNLAZY);
@@ -192,7 +191,8 @@ int dev_pm_set_dedicated_wake_irq(struct device *dev, int irq)
* so we use a threaded irq.
*/
err = request_threaded_irq(irq, NULL, handle_threaded_wake_irq,
- IRQF_ONESHOT, wirq->name, wirq);
+ IRQF_ONESHOT | IRQF_NO_AUTOEN,
+ wirq->name, wirq);
if (err)
goto err_free_name;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] PM / wakeirq: move to use request_irq by IRQF_NO_AUTOEN flag
2021-05-20 7:34 [PATCH] PM / wakeirq: move to use request_irq by IRQF_NO_AUTOEN flag Tian Tao
@ 2021-05-21 16:57 ` Rafael J. Wysocki
2021-05-21 18:09 ` Tony Lindgren
0 siblings, 1 reply; 4+ messages in thread
From: Rafael J. Wysocki @ 2021-05-21 16:57 UTC (permalink / raw)
To: Tian Tao, Tony Lindgren
Cc: Rafael J. Wysocki, Len Brown, Pavel Machek, Greg Kroah-Hartman,
Linux PM
On Thu, May 20, 2021 at 9:35 AM Tian Tao <tiantao6@hisilicon.com> wrote:
>
> request_irq() after setting IRQ_NOAUTOEN as below
> irq_set_status_flags(irq, IRQ_NOAUTOEN);
> request_irq(dev, irq...);
> can be replaced by request_irq() with IRQF_NO_AUTOEN flag.
>
> this change is just to simplify the code, no actual functional changes.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Tony, what do you think?
> ---
> drivers/base/power/wakeirq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/base/power/wakeirq.c b/drivers/base/power/wakeirq.c
> index 8e02108..3bad326 100644
> --- a/drivers/base/power/wakeirq.c
> +++ b/drivers/base/power/wakeirq.c
> @@ -182,7 +182,6 @@ int dev_pm_set_dedicated_wake_irq(struct device *dev, int irq)
>
> wirq->dev = dev;
> wirq->irq = irq;
> - irq_set_status_flags(irq, IRQ_NOAUTOEN);
>
> /* Prevent deferred spurious wakeirqs with disable_irq_nosync() */
> irq_set_status_flags(irq, IRQ_DISABLE_UNLAZY);
> @@ -192,7 +191,8 @@ int dev_pm_set_dedicated_wake_irq(struct device *dev, int irq)
> * so we use a threaded irq.
> */
> err = request_threaded_irq(irq, NULL, handle_threaded_wake_irq,
> - IRQF_ONESHOT, wirq->name, wirq);
> + IRQF_ONESHOT | IRQF_NO_AUTOEN,
> + wirq->name, wirq);
> if (err)
> goto err_free_name;
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PM / wakeirq: move to use request_irq by IRQF_NO_AUTOEN flag
2021-05-21 16:57 ` Rafael J. Wysocki
@ 2021-05-21 18:09 ` Tony Lindgren
2021-05-24 14:07 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Tony Lindgren @ 2021-05-21 18:09 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Tian Tao, Rafael J. Wysocki, Len Brown, Pavel Machek,
Greg Kroah-Hartman, Linux PM
* Rafael J. Wysocki <rafael@kernel.org> [210521 16:57]:
> On Thu, May 20, 2021 at 9:35 AM Tian Tao <tiantao6@hisilicon.com> wrote:
> >
> > request_irq() after setting IRQ_NOAUTOEN as below
> > irq_set_status_flags(irq, IRQ_NOAUTOEN);
> > request_irq(dev, irq...);
> > can be replaced by request_irq() with IRQF_NO_AUTOEN flag.
> >
> > this change is just to simplify the code, no actual functional changes.
> >
> > Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
>
> Tony, what do you think?
Sounds good to me:
Reviewed-by: Tony Lindgren <tony@atomide.com>
> > ---
> > drivers/base/power/wakeirq.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/base/power/wakeirq.c b/drivers/base/power/wakeirq.c
> > index 8e02108..3bad326 100644
> > --- a/drivers/base/power/wakeirq.c
> > +++ b/drivers/base/power/wakeirq.c
> > @@ -182,7 +182,6 @@ int dev_pm_set_dedicated_wake_irq(struct device *dev, int irq)
> >
> > wirq->dev = dev;
> > wirq->irq = irq;
> > - irq_set_status_flags(irq, IRQ_NOAUTOEN);
> >
> > /* Prevent deferred spurious wakeirqs with disable_irq_nosync() */
> > irq_set_status_flags(irq, IRQ_DISABLE_UNLAZY);
> > @@ -192,7 +191,8 @@ int dev_pm_set_dedicated_wake_irq(struct device *dev, int irq)
> > * so we use a threaded irq.
> > */
> > err = request_threaded_irq(irq, NULL, handle_threaded_wake_irq,
> > - IRQF_ONESHOT, wirq->name, wirq);
> > + IRQF_ONESHOT | IRQF_NO_AUTOEN,
> > + wirq->name, wirq);
> > if (err)
> > goto err_free_name;
> >
> > --
> > 2.7.4
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PM / wakeirq: move to use request_irq by IRQF_NO_AUTOEN flag
2021-05-21 18:09 ` Tony Lindgren
@ 2021-05-24 14:07 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2021-05-24 14:07 UTC (permalink / raw)
To: Tony Lindgren, Tian Tao
Cc: Rafael J. Wysocki, Rafael J. Wysocki, Len Brown, Pavel Machek,
Greg Kroah-Hartman, Linux PM
On Fri, May 21, 2021 at 8:09 PM Tony Lindgren <tony@atomide.com> wrote:
>
> * Rafael J. Wysocki <rafael@kernel.org> [210521 16:57]:
> > On Thu, May 20, 2021 at 9:35 AM Tian Tao <tiantao6@hisilicon.com> wrote:
> > >
> > > request_irq() after setting IRQ_NOAUTOEN as below
> > > irq_set_status_flags(irq, IRQ_NOAUTOEN);
> > > request_irq(dev, irq...);
> > > can be replaced by request_irq() with IRQF_NO_AUTOEN flag.
> > >
> > > this change is just to simplify the code, no actual functional changes.
> > >
> > > Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> >
> > Tony, what do you think?
>
> Sounds good to me:
>
> Reviewed-by: Tony Lindgren <tony@atomide.com>
Applied as 5.14 material, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-24 14:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-20 7:34 [PATCH] PM / wakeirq: move to use request_irq by IRQF_NO_AUTOEN flag Tian Tao
2021-05-21 16:57 ` Rafael J. Wysocki
2021-05-21 18:09 ` Tony Lindgren
2021-05-24 14:07 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox