From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58755C47076 for ; Fri, 21 May 2021 18:09:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2EC56613DB for ; Fri, 21 May 2021 18:09:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230335AbhEUSLN (ORCPT ); Fri, 21 May 2021 14:11:13 -0400 Received: from muru.com ([72.249.23.125]:58594 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230168AbhEUSLN (ORCPT ); Fri, 21 May 2021 14:11:13 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 9CEF880C0; Fri, 21 May 2021 18:09:53 +0000 (UTC) Date: Fri, 21 May 2021 21:09:45 +0300 From: Tony Lindgren To: "Rafael J. Wysocki" Cc: Tian Tao , "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Linux PM Subject: Re: [PATCH] PM / wakeirq: move to use request_irq by IRQF_NO_AUTOEN flag Message-ID: References: <1621496098-50271-1-git-send-email-tiantao6@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org * Rafael J. Wysocki [210521 16:57]: > On Thu, May 20, 2021 at 9:35 AM Tian Tao wrote: > > > > request_irq() after setting IRQ_NOAUTOEN as below > > irq_set_status_flags(irq, IRQ_NOAUTOEN); > > request_irq(dev, irq...); > > can be replaced by request_irq() with IRQF_NO_AUTOEN flag. > > > > this change is just to simplify the code, no actual functional changes. > > > > Signed-off-by: Tian Tao > > Tony, what do you think? Sounds good to me: Reviewed-by: Tony Lindgren > > --- > > drivers/base/power/wakeirq.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/base/power/wakeirq.c b/drivers/base/power/wakeirq.c > > index 8e02108..3bad326 100644 > > --- a/drivers/base/power/wakeirq.c > > +++ b/drivers/base/power/wakeirq.c > > @@ -182,7 +182,6 @@ int dev_pm_set_dedicated_wake_irq(struct device *dev, int irq) > > > > wirq->dev = dev; > > wirq->irq = irq; > > - irq_set_status_flags(irq, IRQ_NOAUTOEN); > > > > /* Prevent deferred spurious wakeirqs with disable_irq_nosync() */ > > irq_set_status_flags(irq, IRQ_DISABLE_UNLAZY); > > @@ -192,7 +191,8 @@ int dev_pm_set_dedicated_wake_irq(struct device *dev, int irq) > > * so we use a threaded irq. > > */ > > err = request_threaded_irq(irq, NULL, handle_threaded_wake_irq, > > - IRQF_ONESHOT, wirq->name, wirq); > > + IRQF_ONESHOT | IRQF_NO_AUTOEN, > > + wirq->name, wirq); > > if (err) > > goto err_free_name; > > > > -- > > 2.7.4 > >