From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13092C4743D for ; Fri, 11 Jun 2021 07:38:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EED4C613AE for ; Fri, 11 Jun 2021 07:38:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231250AbhFKHkb (ORCPT ); Fri, 11 Jun 2021 03:40:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230188AbhFKHka (ORCPT ); Fri, 11 Jun 2021 03:40:30 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA9AEC061574; Fri, 11 Jun 2021 00:38:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=d+ZiczX7/nBR1jMhSfL1TaMj90+rVYq9+YaMIRDOsZE=; b=DpbRdQxX7AHqEpiFo8nq82GbOM PGuW69uCPEf2CcxctkEUO4jHZbgI8RbIj18OvWnpt3qJllBw/BMnliIALO+iIPy2Rp9w8f6mriOm2 rY5nGTB3D2j8cd6PniRszOoXdM1kW6ZsFpXAeEojncXy+KDHRmkxJnK1grdoM8DKk8IT3V88EDsle Xoc9mjCC6IxNA7P0UVPO8Ko0+rGn8XbaIvi/sfWbfCgXFXursU1RFH5+oSRKLeHVS7vO9cLGhLJfu t84+dGJB2ZcrIfIfKNlStbY+ds+wGccjqiKGp4w9BZXA8wUyleuSK0HrbkkMulUV/5HjIRlz/KkB/ y+mOEOiA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lrbjN-002Vyn-67; Fri, 11 Jun 2021 07:37:32 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 9B8CC30008D; Fri, 11 Jun 2021 09:37:27 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 546502BCF392F; Fri, 11 Jun 2021 09:37:27 +0200 (CEST) Date: Fri, 11 Jun 2021 09:37:27 +0200 From: Peter Zijlstra To: Viresh Kumar Cc: Rafael Wysocki , Qian Cai , Sudeep Holla , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Ionela Voinescu , linux-pm@vger.kernel.org, "Rafael J. Wysocki" , linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] Revert "cpufreq: CPPC: Add support for frequency invariance" Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Fri, Jun 11, 2021 at 08:48:02AM +0530, Viresh Kumar wrote: > This reverts commit 4c38f2df71c8e33c0b64865992d693f5022eeaad. > > There are few races in the frequency invariance support for CPPC driver, > namely the driver doesn't stop the kthread_work and irq_work on policy > exit during suspend/resume or CPU hotplug. > > A proper fix won't be possible for the 5.13-rc, as it requires a lot of > changes. Lets revert the patch instead for now. > > Fixes: 4c38f2df71c8 ("cpufreq: CPPC: Add support for frequency invariance") > Reported-by: Qian Cai > Signed-off-by: Viresh Kumar > --- > V2: Revert the original patch instead of marking it broken. > > drivers/cpufreq/Kconfig.arm | 10 -- > drivers/cpufreq/cppc_cpufreq.c | 245 ++------------------------------- > include/linux/arch_topology.h | 1 - > kernel/sched/core.c | 1 - > 4 files changed, 12 insertions(+), 245 deletions(-) > > diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm > index a5c5f70acfc9..e65e0a43be64 100644 > --- a/drivers/cpufreq/Kconfig.arm > +++ b/drivers/cpufreq/Kconfig.arm > @@ -19,16 +19,6 @@ config ACPI_CPPC_CPUFREQ > > If in doubt, say N. > > -config ACPI_CPPC_CPUFREQ_FIE > - bool "Frequency Invariance support for CPPC cpufreq driver" > - depends on ACPI_CPPC_CPUFREQ && GENERIC_ARCH_TOPOLOGY > - default y > - help > - This extends frequency invariance support in the CPPC cpufreq driver, > - by using CPPC delivered and reference performance counters. > - > - If in doubt, say N. > - Alternatively: "depends on BROKEN" ?