* [PATCH 14/39] arm64: dts: qcom: sdm630: Add TSENS node [not found] <20210728222542.54269-1-konrad.dybcio@somainline.org> @ 2021-07-28 22:25 ` Konrad Dybcio 2021-07-29 10:50 ` Thara Gopinath 2021-08-02 22:39 ` Rob Herring 0 siblings, 2 replies; 9+ messages in thread From: Konrad Dybcio @ 2021-07-28 22:25 UTC (permalink / raw) To: ~postmarketos/upstreaming Cc: martin.botka, angelogioacchino.delregno, marijn.suijten, jamipkettunen, Konrad Dybcio, Andy Gross, Bjorn Andersson, Amit Kucheria, Thara Gopinath, Zhang Rui, Daniel Lezcano, Rob Herring, linux-arm-msm, linux-pm, devicetree, linux-kernel This will enable temperature reporting for various SoC components. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org> --- .../devicetree/bindings/thermal/qcom-tsens.yaml | 1 + arch/arm64/boot/dts/qcom/sdm630.dtsi | 11 +++++++++++ 2 files changed, 12 insertions(+) diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml index 4a2eaf28e3fd..d3b9e9b600a2 100644 --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml @@ -48,6 +48,7 @@ properties: - qcom,sc7180-tsens - qcom,sc7280-tsens - qcom,sc8180x-tsens + - qcom,sdm630-tsens - qcom,sdm845-tsens - qcom,sm8150-tsens - qcom,sm8250-tsens diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi index 1e54828817d5..7e9c80e35fba 100644 --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi @@ -627,6 +627,17 @@ mnoc: interconnect@1745000 { <&mmcc AHB_CLK_SRC>; }; + tsens: thermal-sensor@10ae000 { + compatible = "qcom,sdm630-tsens", "qcom,tsens-v2"; + reg = <0x010ae000 0x1000>, /* TM */ + <0x010ad000 0x1000>; /* SROT */ + #qcom,sensors = <12>; + interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 430 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "uplow", "critical"; + #thermal-sensor-cells = <1>; + }; + tcsr_mutex_regs: syscon@1f40000 { compatible = "syscon"; reg = <0x01f40000 0x20000>; -- 2.32.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 14/39] arm64: dts: qcom: sdm630: Add TSENS node 2021-07-28 22:25 ` [PATCH 14/39] arm64: dts: qcom: sdm630: Add TSENS node Konrad Dybcio @ 2021-07-29 10:50 ` Thara Gopinath 2021-07-29 10:52 ` Konrad Dybcio 2021-08-02 22:39 ` Rob Herring 1 sibling, 1 reply; 9+ messages in thread From: Thara Gopinath @ 2021-07-29 10:50 UTC (permalink / raw) To: Konrad Dybcio, ~postmarketos/upstreaming Cc: martin.botka, angelogioacchino.delregno, marijn.suijten, jamipkettunen, Andy Gross, Bjorn Andersson, Amit Kucheria, Zhang Rui, Daniel Lezcano, Rob Herring, linux-arm-msm, linux-pm, devicetree, linux-kernel Hi Konrad, On 7/28/21 6:25 PM, Konrad Dybcio wrote: > This will enable temperature reporting for various SoC > components. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> > Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org> > --- > .../devicetree/bindings/thermal/qcom-tsens.yaml | 1 + > arch/arm64/boot/dts/qcom/sdm630.dtsi | 11 +++++++++++ > 2 files changed, 12 insertions(+) > > diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > index 4a2eaf28e3fd..d3b9e9b600a2 100644 > --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > @@ -48,6 +48,7 @@ properties: > - qcom,sc7180-tsens > - qcom,sc7280-tsens > - qcom,sc8180x-tsens > + - qcom,sdm630-tsens > - qcom,sdm845-tsens > - qcom,sm8150-tsens > - qcom,sm8250-tsens > diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi > index 1e54828817d5..7e9c80e35fba 100644 > --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi > @@ -627,6 +627,17 @@ mnoc: interconnect@1745000 { > <&mmcc AHB_CLK_SRC>; > }; > > + tsens: thermal-sensor@10ae000 { > + compatible = "qcom,sdm630-tsens", "qcom,tsens-v2"; > + reg = <0x010ae000 0x1000>, /* TM */ > + <0x010ad000 0x1000>; /* SROT */ > + #qcom,sensors = <12>; Are all 12 sensors used ? I see that in a later patch "arm64: dts: qcom: sdm630: Add thermal-zones configuration" only 9 are used. > + interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 430 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "uplow", "critical"; > + #thermal-sensor-cells = <1>; > + }; > + > tcsr_mutex_regs: syscon@1f40000 { > compatible = "syscon"; > reg = <0x01f40000 0x20000>; > -- Warm Regards Thara (She/Her/Hers) ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 14/39] arm64: dts: qcom: sdm630: Add TSENS node 2021-07-29 10:50 ` Thara Gopinath @ 2021-07-29 10:52 ` Konrad Dybcio 2021-07-29 10:54 ` Thara Gopinath 0 siblings, 1 reply; 9+ messages in thread From: Konrad Dybcio @ 2021-07-29 10:52 UTC (permalink / raw) To: Thara Gopinath, ~postmarketos/upstreaming Cc: martin.botka, angelogioacchino.delregno, marijn.suijten, jamipkettunen, Andy Gross, Bjorn Andersson, Amit Kucheria, Zhang Rui, Daniel Lezcano, Rob Herring, linux-arm-msm, linux-pm, devicetree, linux-kernel On 29.07.2021 12:50, Thara Gopinath wrote: > Hi Konrad, > > On 7/28/21 6:25 PM, Konrad Dybcio wrote: >> This will enable temperature reporting for various SoC >> components. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org> >> --- >> .../devicetree/bindings/thermal/qcom-tsens.yaml | 1 + >> arch/arm64/boot/dts/qcom/sdm630.dtsi | 11 +++++++++++ >> 2 files changed, 12 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >> index 4a2eaf28e3fd..d3b9e9b600a2 100644 >> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >> @@ -48,6 +48,7 @@ properties: >> - qcom,sc7180-tsens >> - qcom,sc7280-tsens >> - qcom,sc8180x-tsens >> + - qcom,sdm630-tsens >> - qcom,sdm845-tsens >> - qcom,sm8150-tsens >> - qcom,sm8250-tsens >> diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi >> index 1e54828817d5..7e9c80e35fba 100644 >> --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi >> @@ -627,6 +627,17 @@ mnoc: interconnect@1745000 { >> <&mmcc AHB_CLK_SRC>; >> }; >> + tsens: thermal-sensor@10ae000 { >> + compatible = "qcom,sdm630-tsens", "qcom,tsens-v2"; >> + reg = <0x010ae000 0x1000>, /* TM */ >> + <0x010ad000 0x1000>; /* SROT */ >> + #qcom,sensors = <12>; > > Are all 12 sensors used ? I see that in a later patch "arm64: dts: qcom: sdm630: Add thermal-zones configuration" only 9 are used. Hi, if I recall correctly, they all give output but not all of the mappings were documented in the downstream sources and we have no documentation whatsoever :( Konrad ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 14/39] arm64: dts: qcom: sdm630: Add TSENS node 2021-07-29 10:52 ` Konrad Dybcio @ 2021-07-29 10:54 ` Thara Gopinath 2021-07-29 10:55 ` Konrad Dybcio 0 siblings, 1 reply; 9+ messages in thread From: Thara Gopinath @ 2021-07-29 10:54 UTC (permalink / raw) To: Konrad Dybcio, ~postmarketos/upstreaming Cc: martin.botka, angelogioacchino.delregno, marijn.suijten, jamipkettunen, Andy Gross, Bjorn Andersson, Amit Kucheria, Zhang Rui, Daniel Lezcano, Rob Herring, linux-arm-msm, linux-pm, devicetree, linux-kernel On 7/29/21 6:52 AM, Konrad Dybcio wrote: > > On 29.07.2021 12:50, Thara Gopinath wrote: >> Hi Konrad, >> >> On 7/28/21 6:25 PM, Konrad Dybcio wrote: >>> This will enable temperature reporting for various SoC >>> components. >>> >>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> >>> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org> >>> --- >>> .../devicetree/bindings/thermal/qcom-tsens.yaml | 1 + >>> arch/arm64/boot/dts/qcom/sdm630.dtsi | 11 +++++++++++ >>> 2 files changed, 12 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >>> index 4a2eaf28e3fd..d3b9e9b600a2 100644 >>> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >>> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >>> @@ -48,6 +48,7 @@ properties: >>> - qcom,sc7180-tsens >>> - qcom,sc7280-tsens >>> - qcom,sc8180x-tsens >>> + - qcom,sdm630-tsens >>> - qcom,sdm845-tsens >>> - qcom,sm8150-tsens >>> - qcom,sm8250-tsens >>> diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi >>> index 1e54828817d5..7e9c80e35fba 100644 >>> --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi >>> @@ -627,6 +627,17 @@ mnoc: interconnect@1745000 { >>> <&mmcc AHB_CLK_SRC>; >>> }; >>> + tsens: thermal-sensor@10ae000 { >>> + compatible = "qcom,sdm630-tsens", "qcom,tsens-v2"; >>> + reg = <0x010ae000 0x1000>, /* TM */ >>> + <0x010ad000 0x1000>; /* SROT */ >>> + #qcom,sensors = <12>; >> >> Are all 12 sensors used ? I see that in a later patch "arm64: dts: qcom: sdm630: Add thermal-zones configuration" only 9 are used. > > Hi, > > if I recall correctly, they all give output but not all of the mappings were documented in the downstream sources and we have no documentation whatsoever :( Right. In that case, why not change #qcom,sensors to 9 and add rest of the sensors if and when needed ? > > > Konrad > -- Warm Regards Thara (She/Her/Hers) ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 14/39] arm64: dts: qcom: sdm630: Add TSENS node 2021-07-29 10:54 ` Thara Gopinath @ 2021-07-29 10:55 ` Konrad Dybcio 2021-07-29 11:14 ` Thara Gopinath 0 siblings, 1 reply; 9+ messages in thread From: Konrad Dybcio @ 2021-07-29 10:55 UTC (permalink / raw) To: Thara Gopinath, ~postmarketos/upstreaming Cc: martin.botka, angelogioacchino.delregno, marijn.suijten, jamipkettunen, Andy Gross, Bjorn Andersson, Amit Kucheria, Zhang Rui, Daniel Lezcano, Rob Herring, linux-arm-msm, linux-pm, devicetree, linux-kernel On 29.07.2021 12:54, Thara Gopinath wrote: > > > On 7/29/21 6:52 AM, Konrad Dybcio wrote: >> >> On 29.07.2021 12:50, Thara Gopinath wrote: >>> Hi Konrad, >>> >>> On 7/28/21 6:25 PM, Konrad Dybcio wrote: >>>> This will enable temperature reporting for various SoC >>>> components. >>>> >>>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> >>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org> >>>> --- >>>> .../devicetree/bindings/thermal/qcom-tsens.yaml | 1 + >>>> arch/arm64/boot/dts/qcom/sdm630.dtsi | 11 +++++++++++ >>>> 2 files changed, 12 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >>>> index 4a2eaf28e3fd..d3b9e9b600a2 100644 >>>> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >>>> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >>>> @@ -48,6 +48,7 @@ properties: >>>> - qcom,sc7180-tsens >>>> - qcom,sc7280-tsens >>>> - qcom,sc8180x-tsens >>>> + - qcom,sdm630-tsens >>>> - qcom,sdm845-tsens >>>> - qcom,sm8150-tsens >>>> - qcom,sm8250-tsens >>>> diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi >>>> index 1e54828817d5..7e9c80e35fba 100644 >>>> --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi >>>> @@ -627,6 +627,17 @@ mnoc: interconnect@1745000 { >>>> <&mmcc AHB_CLK_SRC>; >>>> }; >>>> + tsens: thermal-sensor@10ae000 { >>>> + compatible = "qcom,sdm630-tsens", "qcom,tsens-v2"; >>>> + reg = <0x010ae000 0x1000>, /* TM */ >>>> + <0x010ad000 0x1000>; /* SROT */ >>>> + #qcom,sensors = <12>; >>> >>> Are all 12 sensors used ? I see that in a later patch "arm64: dts: qcom: sdm630: Add thermal-zones configuration" only 9 are used. >> >> Hi, >> >> if I recall correctly, they all give output but not all of the mappings were documented in the downstream sources and we have no documentation whatsoever :( > > Right. In that case, why not change #qcom,sensors to 9 and add rest of the sensors if and when needed ? > I don't think it makes sense to describe the hardware incorrectly, even if some of it is unused. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 14/39] arm64: dts: qcom: sdm630: Add TSENS node 2021-07-29 10:55 ` Konrad Dybcio @ 2021-07-29 11:14 ` Thara Gopinath 2021-07-29 13:48 ` AngeloGioacchino Del Regno 0 siblings, 1 reply; 9+ messages in thread From: Thara Gopinath @ 2021-07-29 11:14 UTC (permalink / raw) To: Konrad Dybcio, ~postmarketos/upstreaming Cc: martin.botka, angelogioacchino.delregno, marijn.suijten, jamipkettunen, Andy Gross, Bjorn Andersson, Amit Kucheria, Zhang Rui, Daniel Lezcano, Rob Herring, linux-arm-msm, linux-pm, devicetree, linux-kernel On 7/29/21 6:55 AM, Konrad Dybcio wrote: > > On 29.07.2021 12:54, Thara Gopinath wrote: >> >> >> On 7/29/21 6:52 AM, Konrad Dybcio wrote: >>> >>> On 29.07.2021 12:50, Thara Gopinath wrote: >>>> Hi Konrad, >>>> >>>> On 7/28/21 6:25 PM, Konrad Dybcio wrote: >>>>> This will enable temperature reporting for various SoC >>>>> components. >>>>> >>>>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> >>>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org> >>>>> --- >>>>> .../devicetree/bindings/thermal/qcom-tsens.yaml | 1 + >>>>> arch/arm64/boot/dts/qcom/sdm630.dtsi | 11 +++++++++++ >>>>> 2 files changed, 12 insertions(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >>>>> index 4a2eaf28e3fd..d3b9e9b600a2 100644 >>>>> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >>>>> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >>>>> @@ -48,6 +48,7 @@ properties: >>>>> - qcom,sc7180-tsens >>>>> - qcom,sc7280-tsens >>>>> - qcom,sc8180x-tsens >>>>> + - qcom,sdm630-tsens >>>>> - qcom,sdm845-tsens >>>>> - qcom,sm8150-tsens >>>>> - qcom,sm8250-tsens >>>>> diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi >>>>> index 1e54828817d5..7e9c80e35fba 100644 >>>>> --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi >>>>> +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi >>>>> @@ -627,6 +627,17 @@ mnoc: interconnect@1745000 { >>>>> <&mmcc AHB_CLK_SRC>; >>>>> }; >>>>> + tsens: thermal-sensor@10ae000 { >>>>> + compatible = "qcom,sdm630-tsens", "qcom,tsens-v2"; >>>>> + reg = <0x010ae000 0x1000>, /* TM */ >>>>> + <0x010ad000 0x1000>; /* SROT */ >>>>> + #qcom,sensors = <12>; >>>> >>>> Are all 12 sensors used ? I see that in a later patch "arm64: dts: qcom: sdm630: Add thermal-zones configuration" only 9 are used. >>> >>> Hi, >>> >>> if I recall correctly, they all give output but not all of the mappings were documented in the downstream sources and we have no documentation whatsoever :( >> >> Right. In that case, why not change #qcom,sensors to 9 and add rest of the sensors if and when needed ? >> > I don't think it makes sense to describe the hardware incorrectly, even if some of it is unused. My thinking was more along the lines of don't expose unused h/w bits. > > > -- Warm Regards Thara (She/Her/Hers) ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 14/39] arm64: dts: qcom: sdm630: Add TSENS node 2021-07-29 11:14 ` Thara Gopinath @ 2021-07-29 13:48 ` AngeloGioacchino Del Regno 2021-08-24 15:16 ` Bjorn Andersson 0 siblings, 1 reply; 9+ messages in thread From: AngeloGioacchino Del Regno @ 2021-07-29 13:48 UTC (permalink / raw) To: Thara Gopinath, Konrad Dybcio, ~postmarketos/upstreaming Cc: martin.botka, marijn.suijten, jamipkettunen, Andy Gross, Bjorn Andersson, Amit Kucheria, Zhang Rui, Daniel Lezcano, Rob Herring, linux-arm-msm, linux-pm, devicetree, linux-kernel Il 29/07/21 13:14, Thara Gopinath ha scritto: > > > On 7/29/21 6:55 AM, Konrad Dybcio wrote: >> >> On 29.07.2021 12:54, Thara Gopinath wrote: >>> >>> >>> On 7/29/21 6:52 AM, Konrad Dybcio wrote: >>>> >>>> On 29.07.2021 12:50, Thara Gopinath wrote: >>>>> Hi Konrad, >>>>> >>>>> On 7/28/21 6:25 PM, Konrad Dybcio wrote: >>>>>> This will enable temperature reporting for various SoC >>>>>> components. >>>>>> >>>>>> Signed-off-by: AngeloGioacchino Del Regno >>>>>> <angelogioacchino.delregno@somainline.org> >>>>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org> >>>>>> --- >>>>>> .../devicetree/bindings/thermal/qcom-tsens.yaml | 1 + >>>>>> arch/arm64/boot/dts/qcom/sdm630.dtsi | 11 +++++++++++ >>>>>> 2 files changed, 12 insertions(+) >>>>>> >>>>>> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >>>>>> b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >>>>>> index 4a2eaf28e3fd..d3b9e9b600a2 100644 >>>>>> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >>>>>> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >>>>>> @@ -48,6 +48,7 @@ properties: >>>>>> - qcom,sc7180-tsens >>>>>> - qcom,sc7280-tsens >>>>>> - qcom,sc8180x-tsens >>>>>> + - qcom,sdm630-tsens >>>>>> - qcom,sdm845-tsens >>>>>> - qcom,sm8150-tsens >>>>>> - qcom,sm8250-tsens >>>>>> diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi >>>>>> b/arch/arm64/boot/dts/qcom/sdm630.dtsi >>>>>> index 1e54828817d5..7e9c80e35fba 100644 >>>>>> --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi >>>>>> +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi >>>>>> @@ -627,6 +627,17 @@ mnoc: interconnect@1745000 { >>>>>> <&mmcc AHB_CLK_SRC>; >>>>>> }; >>>>>> + tsens: thermal-sensor@10ae000 { >>>>>> + compatible = "qcom,sdm630-tsens", "qcom,tsens-v2"; >>>>>> + reg = <0x010ae000 0x1000>, /* TM */ >>>>>> + <0x010ad000 0x1000>; /* SROT */ >>>>>> + #qcom,sensors = <12>; >>>>> >>>>> Are all 12 sensors used ? I see that in a later patch "arm64: dts: qcom: >>>>> sdm630: Add thermal-zones configuration" only 9 are used. >>>> >>>> Hi, >>>> >>>> if I recall correctly, they all give output but not all of the mappings were >>>> documented in the downstream sources and we have no documentation whatsoever :( >>> >>> Right. In that case, why not change #qcom,sensors to 9 and add rest of the >>> sensors if and when needed ? >>> >> I don't think it makes sense to describe the hardware incorrectly, even if some >> of it is unused. > > My thinking was more along the lines of don't expose unused h/w bits. > You're right about not exposing unused HW bits, but even PC x86 motherboards (I mean the smbus/i2c drivers for the big holy management/sensors chips) do have such a "base" configuration, where some lines are read as 0 because they are effectively not connected by hardware. In order to avoid confusion to other developers, in my personal opinion, it would be good go for the current value of 12 (which isn't incorrect, as that's what the SoC supports)... I don't think that anyone would be confused by seeing zero readings on some sensors (if their device don't support such sensor), as I think that everyone is used to that anyway, even if that's in other circumstances... In any case, luckily that's also safe, because there's no firmware that restricts the readings to a subset of sensors in this domain (nobody is going to get a hypervisor fault for that). I would also, in case, propose to see how things go: I would expect other developers to push device trees for many SDM630/636/660 devices, including but not limited to smartphones and SBCs.. so perhaps if we find out that really nobody uses the 12 sensors, or if the very vast majority uses a different amount, perhaps we may just transfer the value to device-specific configurations in one go, as to avoid unnecessary noise... I think :))) >> >> >> > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 14/39] arm64: dts: qcom: sdm630: Add TSENS node 2021-07-29 13:48 ` AngeloGioacchino Del Regno @ 2021-08-24 15:16 ` Bjorn Andersson 0 siblings, 0 replies; 9+ messages in thread From: Bjorn Andersson @ 2021-08-24 15:16 UTC (permalink / raw) To: AngeloGioacchino Del Regno Cc: Thara Gopinath, Konrad Dybcio, ~postmarketos/upstreaming, martin.botka, marijn.suijten, jamipkettunen, Andy Gross, Amit Kucheria, Zhang Rui, Daniel Lezcano, Rob Herring, linux-arm-msm, linux-pm, devicetree, linux-kernel On Thu 29 Jul 06:48 PDT 2021, AngeloGioacchino Del Regno wrote: > Il 29/07/21 13:14, Thara Gopinath ha scritto: > > > > > > On 7/29/21 6:55 AM, Konrad Dybcio wrote: > > > > > > On 29.07.2021 12:54, Thara Gopinath wrote: > > > > > > > > > > > > On 7/29/21 6:52 AM, Konrad Dybcio wrote: > > > > > > > > > > On 29.07.2021 12:50, Thara Gopinath wrote: > > > > > > Hi Konrad, > > > > > > > > > > > > On 7/28/21 6:25 PM, Konrad Dybcio wrote: > > > > > > > This will enable temperature reporting for various SoC > > > > > > > components. > > > > > > > > > > > > > > Signed-off-by: AngeloGioacchino Del Regno > > > > > > > <angelogioacchino.delregno@somainline.org> > > > > > > > Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org> > > > > > > > --- > > > > > > > .../devicetree/bindings/thermal/qcom-tsens.yaml | 1 + > > > > > > > arch/arm64/boot/dts/qcom/sdm630.dtsi | 11 +++++++++++ > > > > > > > 2 files changed, 12 insertions(+) > > > > > > > > > > > > > > diff --git > > > > > > > a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > > > > > > > b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > > > > > > > index 4a2eaf28e3fd..d3b9e9b600a2 100644 > > > > > > > --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > > > > > > > +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > > > > > > > @@ -48,6 +48,7 @@ properties: > > > > > > > - qcom,sc7180-tsens > > > > > > > - qcom,sc7280-tsens > > > > > > > - qcom,sc8180x-tsens > > > > > > > + - qcom,sdm630-tsens > > > > > > > - qcom,sdm845-tsens > > > > > > > - qcom,sm8150-tsens > > > > > > > - qcom,sm8250-tsens > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi > > > > > > > b/arch/arm64/boot/dts/qcom/sdm630.dtsi > > > > > > > index 1e54828817d5..7e9c80e35fba 100644 > > > > > > > --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi > > > > > > > +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi > > > > > > > @@ -627,6 +627,17 @@ mnoc: interconnect@1745000 { > > > > > > > <&mmcc AHB_CLK_SRC>; > > > > > > > }; > > > > > > > + tsens: thermal-sensor@10ae000 { > > > > > > > + compatible = "qcom,sdm630-tsens", "qcom,tsens-v2"; > > > > > > > + reg = <0x010ae000 0x1000>, /* TM */ > > > > > > > + <0x010ad000 0x1000>; /* SROT */ > > > > > > > + #qcom,sensors = <12>; > > > > > > > > > > > > Are all 12 sensors used ? I see that in a later patch > > > > > > "arm64: dts: qcom: sdm630: Add thermal-zones > > > > > > configuration" only 9 are used. > > > > > > > > > > Hi, > > > > > > > > > > if I recall correctly, they all give output but not all of > > > > > the mappings were documented in the downstream sources and > > > > > we have no documentation whatsoever :( > > > > > > > > Right. In that case, why not change #qcom,sensors to 9 and add > > > > rest of the sensors if and when needed ? > > > > > > > I don't think it makes sense to describe the hardware incorrectly, > > > even if some of it is unused. > > > > My thinking was more along the lines of don't expose unused h/w bits. > > > > You're right about not exposing unused HW bits, but even PC x86 motherboards > (I mean the smbus/i2c drivers for the big holy management/sensors chips) do > have such a "base" configuration, where some lines are read as 0 because they > are effectively not connected by hardware. > > In order to avoid confusion to other developers, in my personal opinion, it would > be good go for the current value of 12 (which isn't incorrect, as that's what the > SoC supports)... I don't think that anyone would be confused by seeing zero > readings on some sensors (if their device don't support such sensor), as I think > that everyone is used to that anyway, even if that's in other circumstances... > > In any case, luckily that's also safe, because there's no firmware that restricts > the readings to a subset of sensors in this domain (nobody is going to get a > hypervisor fault for that). > > I would also, in case, propose to see how things go: I would expect other > developers to push device trees for many SDM630/636/660 devices, including but > not limited to smartphones and SBCs.. so perhaps if we find out that really > nobody uses the 12 sensors, or if the very vast majority uses a different amount, > perhaps we may just transfer the value to device-specific configurations in one > go, as to avoid unnecessary noise... I think :))) > If the SoC has 12 sensors I think it makes sense to define that, similar to how a SoC might have 200 GPIOs, even though only a handful is actually used. Regards, Bjorn ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 14/39] arm64: dts: qcom: sdm630: Add TSENS node 2021-07-28 22:25 ` [PATCH 14/39] arm64: dts: qcom: sdm630: Add TSENS node Konrad Dybcio 2021-07-29 10:50 ` Thara Gopinath @ 2021-08-02 22:39 ` Rob Herring 1 sibling, 0 replies; 9+ messages in thread From: Rob Herring @ 2021-08-02 22:39 UTC (permalink / raw) To: Konrad Dybcio Cc: martin.botka, marijn.suijten, Andy Gross, Amit Kucheria, Thara Gopinath, Zhang Rui, Rob Herring, devicetree, angelogioacchino.delregno, ~postmarketos/upstreaming, jamipkettunen, Bjorn Andersson, linux-kernel, linux-pm, linux-arm-msm, Daniel Lezcano On Thu, 29 Jul 2021 00:25:17 +0200, Konrad Dybcio wrote: > This will enable temperature reporting for various SoC > components. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> > Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org> > --- > .../devicetree/bindings/thermal/qcom-tsens.yaml | 1 + > arch/arm64/boot/dts/qcom/sdm630.dtsi | 11 +++++++++++ > 2 files changed, 12 insertions(+) > Acked-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-08-24 15:15 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210728222542.54269-1-konrad.dybcio@somainline.org>
2021-07-28 22:25 ` [PATCH 14/39] arm64: dts: qcom: sdm630: Add TSENS node Konrad Dybcio
2021-07-29 10:50 ` Thara Gopinath
2021-07-29 10:52 ` Konrad Dybcio
2021-07-29 10:54 ` Thara Gopinath
2021-07-29 10:55 ` Konrad Dybcio
2021-07-29 11:14 ` Thara Gopinath
2021-07-29 13:48 ` AngeloGioacchino Del Regno
2021-08-24 15:16 ` Bjorn Andersson
2021-08-02 22:39 ` Rob Herring
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).