From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C02BC432BE for ; Wed, 4 Aug 2021 22:59:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2AB1160E96 for ; Wed, 4 Aug 2021 22:59:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229963AbhHDW7Y (ORCPT ); Wed, 4 Aug 2021 18:59:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229729AbhHDW7V (ORCPT ); Wed, 4 Aug 2021 18:59:21 -0400 Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73E0EC06179A for ; Wed, 4 Aug 2021 15:59:07 -0700 (PDT) Received: by mail-ot1-x333.google.com with SMTP id r16-20020a0568304190b02904f26cead745so2851980otu.10 for ; Wed, 04 Aug 2021 15:59:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=p25eSLQlVjyRc2NZ0Izc6Hdj6o33HTjBNdPpz6h3kcg=; b=NFhEaKerz15qkkVoAe3XrnzZP4xOcO9yx05s/WdF2UYcxeE7lvK30id62xqjJ88D1b 4JkWVy0tYOrVXMt/gslUyrOkFQkdWTpmBoDC5EvgBBAmTzTnzCTRswLIE7JB2QTB95nY qlVAooPBbF8QXi4aufOGQ7VcV+Mz5diSEorMiFi0RU+1AC/UafmbYfqwT+YRH1Jzc7YD H+eRCe2DbMbSy547mks3U3NoEIj4OygK1Q9KgPk9OnAqC835uHxFtuhfS2GWrgj9cVbM 5yQ3yOzQv+bZRf/NihBmm+mcGNddzdWGIDugTQZwnGfKwBI5Ry5Ft2cj9S5/O5tT8/Q2 dfmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=p25eSLQlVjyRc2NZ0Izc6Hdj6o33HTjBNdPpz6h3kcg=; b=OK0gTm3oN5UaX1FukZv8YnrlgL3T5dTYvyKT0r+9e8z/W39k9j+/4NH47GSjT/w3JO sdk6xelM+r8wgzyepk9h8RYQmLcsrqopYNE3LLHO2dn3QG7eIKATX4d4Wl9V39cdlWrD FMz+JxrGim5Z6OzzEbp0yapwxNZXijYP1eOjTQPuvOpfMsO4ab9zu/W7iwkgJSbit8Zu JR2kYMADJmOPTnARdkjsebl69o0NJNt/aLM9azrIv0s4RKSKeGbvaInTNckLpHohpu/0 nxFhTdVOQmd4YajADNP7NWW3d0FBy/9wFiLArYGvfLNXA1d+YlZSpl9C+8w08MniNclW m8dA== X-Gm-Message-State: AOAM5326QkiuiEFgrF3y1Ap+xRJBhwuKz/a7mt+6LBe/gzcJfDM7vypt fxHckZlAZqbHDJaS387HEKPrRA== X-Google-Smtp-Source: ABdhPJwhJi3GMY+mER3yqcICMoFsOJG8itB6UE9pbw2isGaQgQDBcvY36EFueGX9HR7DUFsTGqaeSg== X-Received: by 2002:a05:6830:4186:: with SMTP id r6mr1411307otu.136.1628117946685; Wed, 04 Aug 2021 15:59:06 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id r137sm11334oie.17.2021.08.04.15.59.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Aug 2021 15:59:06 -0700 (PDT) Date: Wed, 4 Aug 2021 17:59:04 -0500 From: Bjorn Andersson To: Sibi Sankar Cc: sboyd@kernel.org, robh+dt@kernel.org, mka@chromium.org, viresh.kumar@linaro.org, agross@kernel.org, rjw@rjwysocki.net, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, dianders@chromium.org, tdas@codeaurora.org Subject: Re: [PATCH 4/4] arm64: dts: qcom: sm8350: Fixup the cpufreq node Message-ID: References: <1627581885-32165-1-git-send-email-sibis@codeaurora.org> <1627581885-32165-5-git-send-email-sibis@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1627581885-32165-5-git-send-email-sibis@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Thu 29 Jul 13:04 CDT 2021, Sibi Sankar wrote: > Fixup the register regions used by the cpufreq node on SM8350 SoC to > support per core L3 DCVS. > That sounds good, but why are you dropping the platform-specific compatible? Regards, Bjorn > Signed-off-by: Sibi Sankar > --- > arch/arm64/boot/dts/qcom/sm8350.dtsi | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi > index a631d58166b1..d0a5a5568602 100644 > --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi > @@ -967,11 +967,10 @@ > }; > > cpufreq_hw: cpufreq@18591000 { > - compatible = "qcom,sm8350-cpufreq-epss", "qcom,cpufreq-epss"; > - reg = <0 0x18591000 0 0x1000>, > - <0 0x18592000 0 0x1000>, > - <0 0x18593000 0 0x1000>; > - reg-names = "freq-domain0", "freq-domain1", "freq-domain2"; > + compatible = "qcom,cpufreq-epss"; > + reg = <0 0x18591100 0 0x900>, > + <0 0x18592100 0 0x900>, > + <0 0x18593100 0 0x900>; > > clocks = <&rpmhcc RPMH_CXO_CLK>, <&gcc GCC_GPLL0>; > clock-names = "xo", "alternate"; > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >