Re: [PATCH 04/19] cpufreq: amd: introduce a new amd pstate driver to support future processors

Huang Rui
2021-09-13T08:11:47Z

On Thu, Sep 09, 2021 at 11:01:41PM +0800, Peter Zijlstra wrote:
> On Wed, Sep 08, 2021 at 10:59:46PM +0800, Huang Rui wrote:
>
> > +struct amd_pstate_perf_funcs {
> > + int (*enable)(bool enable);
> > + int (*init_perf)(struct amd_cpudata *cpudata);
> > + void (*update_perf)(struct amd_cpudata *cpudata,
> > + u32 min_perf, u32 des_perf,
> > + u32 max_perf, bool fast_switch);
> > +};
>
> > +static int
> > +amd_pstate_enable(struct amd_pstate_perf_funcs *funcs, bool enable)
> > +{
> > + if (!funcs)
> > + return -EINVAL;
> > +
> > + return funcs->enable(enable);
> > +}
>
> > +static int amd_pstate_init_perf(struct amd_cpudata *cpudata)
> > +{
> > + struct amd_pstate_perf_funcs *funcs = cpufreq_get_driver_data();
> > +
> > + if (!funcs)
> > + return -EINVAL;
> > +
> > + return funcs->init_perf(cpudata);
> > +}
>
> > +static int
> > +amd_pstate_update_perf(struct amd_cpudata *cpudata, u32 min_perf,
> > + u32 des_perf, u32 max_perf, bool fast_switch)
> > +{
> > + struct amd_pstate_perf_funcs *funcs = cpufreq_get_driver_data();
> > +
> > + if (!funcs)
> > + return -EINVAL;
> > +
> > + funcs->update_perf(cpudata, min_perf, des_perf,
> > + max_perf, fast_switch);
> > +
> > + return 0;
> > +}
>
> > +static struct amd_pstate_perf_funcs pstate_funcs = {
> > + .enable = pstate_enable,
> > + .init_perf = pstate_init_perf,
> > + .update_perf = pstate_update_perf,
> > +};
>
> > +static int __init amd_pstate_init(void)
> > +{
> > + int ret;
> > + struct amd_pstate_perf_funcs *funcs;
>
> > +
> > + funcs = &pstate_funcs;
>
> What is the purpose of this seemingly pointless indirection? Showing off
> how good AMD hardware is at doing retpolines or something?

Hi Petter,

Thanks to look at our codes again. We adopt your suggestion which raised
about two year ago that using the kernel governors such as schedutil to
manage frequency control for new cpufreq driver.

We will have two approaches (it depends on different AMD processor
hardware) to implement the amd-pstate driver. (Please see details in Patch
19)

1) Full MSR Support
If current hardware has the full MSR support, we register "pstate_funcs"
callback functions to implement the MSR operations to control the clocks.

The reason that we use the separated way is that we can implement the
fast_switch or adjust_perf functions for schedutil and other governors. The
fast switch function can provide the better performance and lower latency
during frequency control.

2) Shared Memory Support
If current hardware doesn't have the full MSR support, that means it only
provides share memory support. We will leverage APIs in cppc_acpi libs with
"cppc_funcs" to implement the target function for the frequency control.

The mainly reasons that we proposed a new amd-pstate driver, not use the
existing acpi-freq or cppc-cpufreq driver are below:

1. As mentioned above, amd-pstate driver can implement
fast_switch/adjust_perf function with full MSR operations that have better
performance for schedutil and other governors.

2. We will implement the AMD specific features such as Energy Performance
Preference, Preferred Core, and etc. in the amd-pstate driver next step.

3. acpi-cpufreq and cppc-cpufreq are absolutely very good drivers which
provide the general solution for ACPI standards. However,
- if add amd-pstate similar support in acpi-cpufreq driver, it will
impact the legacy P-States function on old Intel and AMD processors.
- <ii> if add amd-pstate similar the support in cppc-cpufreq driver, that
will make this driver bring a lot of x86 specific or AMD specific changes
(quirks or AMD specific handling) in the cppc-cpufreq driver, then the
cppc-cpufreq driver won't be general anymore and will impact the existing
ARM SOCs. And Rafael also didn't want me to add the x86/amd specific
things in cppc-acpi before.

4. AMD will do the performance and power tunning or profiling on each AMD
CPU chip in future, different types of chips will have different policies.
For example, mobile chip and performance desktop problably have the
different frequency control policies.

5. We can maintain amd-pstate driver and handle the bugs which are reported
from community. Make sure it validated on each future and previous AMD CPU
processor, it can reduce the upstream maintenance work load. :-)

Best Regards,
Ray