From: Lee Jones <lee.jones@linaro.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Jonathan Corbet <corbet@lwn.net>,
linux-kernel@vger.kernel.org, Paul Burton <paul.burton@mips.com>,
Sebastian Reichel <sre@kernel.org>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/9] Remove unused headers <linux/jz4740-adc.h> and <linux/power/jz4740-battery.h>
Date: Wed, 3 Nov 2021 10:13:57 +0000 [thread overview]
Message-ID: <YYJg5WaO+Ogd3chz@google.com> (raw)
In-Reply-To: <8YOZ1R.5Y4XRHLJDAGS@crapouillou.net>
On Wed, 03 Nov 2021, Paul Cercueil wrote:
> Hi Lee,
>
> Le mer., nov. 3 2021 at 07:43:51 +0000, Lee Jones <lee.jones@linaro.org> a
> écrit :
> > On Tue, 02 Nov 2021, Jonathan Corbet wrote:
> >
> > > Commit ff71266aa490 ("mfd: Drop obsolete JZ4740 driver") removed
> > > the last
> > > file to include <linux/jz4740-adc.h> but left the header file itself
> > > behind. Nothing uses it, remove it now.
> > >
> > > Similarly, aea12071d6fc ("power/supply: Drop obsolete JZ4740
> > > driver")
> > > deleted the last use of <linux/power/jz4740-battery.h>, so remove
> > > that one
> > > too.
> > >
> > > Cc: Paul Cercueil <paul@crapouillou.net>
> > > Cc: Lee Jones <lee.jones@linaro.org>
> > > Cc: Paul Burton <paul.burton@mips.com>
> > > Cc: Sebastian Reichel <sre@kernel.org>
> > > Cc: linux-pm@vger.kernel.org
> > > Signed-off-by: Jonathan Corbet <corbet@lwn.net>
> > > ---
> > > include/linux/jz4740-adc.h | 33
> > > ----------------------------
> > > include/linux/power/jz4740-battery.h | 15 -------------
> >
> > It appears as though there are still references to both of these
> > *devices* in the kernel tree. Should those be removed also?
>
> These files were for older drivers that were since then replaced by newer
> drivers; JZ47xx SoCs are still officially supported and maintained.
Okay, great.
Thanks for the explanation Paul.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-11-03 10:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211102220203.940290-1-corbet@lwn.net>
2021-11-02 22:01 ` [PATCH 1/9] Remove unused headers <linux/jz4740-adc.h> and <linux/power/jz4740-battery.h> Jonathan Corbet
2021-11-02 22:19 ` Paul Cercueil
2021-11-03 7:43 ` Lee Jones
2021-11-03 9:27 ` Paul Cercueil
2021-11-03 10:13 ` Lee Jones [this message]
2021-11-03 12:40 ` Sebastian Reichel
2021-11-04 8:30 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYJg5WaO+Ogd3chz@google.com \
--to=lee.jones@linaro.org \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=paul.burton@mips.com \
--cc=paul@crapouillou.net \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).