Re: [PATCH 09/13] power: supply: bq25890: Add bq25890_set_otg_cfg() helper

Hans de Goede
2021-11-08T15:59:26Z

Hi,

On 10/31/21 00:10, Andy Shevchenko wrote:
> On Sat, Oct 30, 2021 at 9:28 PM Hans de Goede <hdegoede@redhat.com> wrote:
>>
>> Add a bq25890_set_otg_cfg() helper function, this is a preparation
>> patch for adding regulator support.
>
> ...
>
>> switch (bq->usb_event) {
>> case USB_EVENT_ID:
>> /* Enable boost mode */
>> - ret = bq25890_field_write(bq, F_OTG_CFG, 1);
>> - if (ret < 0)
>> - goto error;
>> + bq25890_set_otg_cfg(bq, 1);
>> break;
>>
>> case USB_EVENT_NONE:
>> /* Disable boost mode */
>> - ret = bq25890_field_write(bq, F_OTG_CFG, 0);
>> - if (ret < 0)
>> - goto error;
>> -
>> - power_supply_changed(bq->charger);
>> + ret = bq25890_set_otg_cfg(bq, 0);
>> + if (ret == 0)
>> + power_supply_changed(bq->charger);
>> break;
>> }
>
> While at it,
>
> default:
> break;

bq->usb_event is not an enum, so there is no need for this.

Regards,

Hans