Re: [PATCH 09/13] power: supply: bq25890: Add bq25890_set_otg_cfg() helper

Andy Shevchenko
2021-10-30T22:10:46Z

On Sat, Oct 30, 2021 at 9:28 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Add a bq25890_set_otg_cfg() helper function, this is a preparation
> patch for adding regulator support.

...

> switch (bq->usb_event) {
> case USB_EVENT_ID:
> /* Enable boost mode */
> - ret = bq25890_field_write(bq, F_OTG_CFG, 1);
> - if (ret < 0)
> - goto error;
> + bq25890_set_otg_cfg(bq, 1);
> break;
>
> case USB_EVENT_NONE:
> /* Disable boost mode */
> - ret = bq25890_field_write(bq, F_OTG_CFG, 0);
> - if (ret < 0)
> - goto error;
> -
> - power_supply_changed(bq->charger);
> + ret = bq25890_set_otg_cfg(bq, 0);
> + if (ret == 0)
> + power_supply_changed(bq->charger);
> break;
> }

While at it,

default:
break;

?

--
With Best Regards,
Andy Shevchenko