From: Huang Rui <ray.huang@amd.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Shuah Khan <skhan@linuxfoundation.org>,
Borislav Petkov <bp@suse.de>, Ingo Molnar <mingo@kernel.org>,
Giovanni Gherdovich <ggherdovich@suse.cz>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"Sharma, Deepak" <Deepak.Sharma@amd.com>,
"Deucher, Alexander" <Alexander.Deucher@amd.com>,
"Limonciello, Mario" <Mario.Limonciello@amd.com>,
Steven Noonan <steven@valvesoftware.com>,
"Fontenot, Nathan" <Nathan.Fontenot@amd.com>,
"Su, Jinzhou (Joe)" <Jinzhou.Su@amd.com>,
"Du, Xiaojian" <Xiaojian.Du@amd.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH v4 06/22] cpufreq: amd: introduce a new amd pstate driver to support future processors
Date: Fri, 19 Nov 2021 19:16:05 +0800 [thread overview]
Message-ID: <YZeHdVexjhXN45qn@hr-amd> (raw)
In-Reply-To: <YZeAohkzXVQ7Nd2Z@hirez.programming.kicks-ass.net>
On Fri, Nov 19, 2021 at 06:46:58PM +0800, Peter Zijlstra wrote:
> On Fri, Nov 19, 2021 at 06:30:46PM +0800, Huang Rui wrote:
> > +static inline int pstate_enable(bool enable)
> > +{
> > + return wrmsrl_safe(MSR_AMD_CPPC_ENABLE, enable ? 1 : 0);
>
> Strictly speaking that ?: is superfluous, a _Bool when cast to scalar
> type will have exactly that value.
Right. Will update it to "wrmsrl_safe(MSR_AMD_CPPC_ENABLE, enable)".
Thanks,
Ray
next prev parent reply other threads:[~2021-11-19 11:16 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 10:30 [PATCH v4 00/22] cpufreq: introduce a new AMD CPU frequency control mechanism Huang Rui
2021-11-19 10:30 ` [PATCH v4 01/22] x86/cpufreatures: add AMD Collaborative Processor Performance Control feature flag Huang Rui
2021-11-19 10:30 ` [PATCH v4 02/22] x86/msr: add AMD CPPC MSR definitions Huang Rui
2021-11-19 10:30 ` [PATCH v4 03/22] ACPI: CPPC: implement support for SystemIO registers Huang Rui
2021-11-19 10:30 ` [PATCH v4 04/22] ACPI: CPPC: Check present CPUs for determining _CPC is valid Huang Rui
2021-11-19 10:30 ` [PATCH v4 05/22] ACPI: CPPC: add cppc enable register function Huang Rui
2021-11-19 10:30 ` [PATCH v4 06/22] cpufreq: amd: introduce a new amd pstate driver to support future processors Huang Rui
2021-11-19 10:46 ` Peter Zijlstra
2021-11-19 11:16 ` Huang Rui [this message]
2021-11-19 12:58 ` Peter Zijlstra
2021-11-25 15:03 ` Giovanni Gherdovich
2021-11-26 9:44 ` Huang Rui
2021-11-19 10:30 ` [PATCH v4 07/22] cpufreq: amd: add fast switch function for amd-pstate Huang Rui
2021-11-19 10:30 ` [PATCH v4 08/22] cpufreq: amd: introduce the support for the processors with shared memory solution Huang Rui
2021-11-19 10:30 ` [PATCH v4 09/22] cpufreq: amd: add trace for amd-pstate module Huang Rui
2021-11-19 10:30 ` [PATCH v4 10/22] cpufreq: amd: add boost mode support for amd-pstate Huang Rui
2021-11-19 10:30 ` [PATCH v4 11/22] cpufreq: amd: add amd-pstate frequencies attributes Huang Rui
2021-11-19 10:30 ` [PATCH v4 12/22] cpufreq: amd: add amd-pstate performance attributes Huang Rui
2021-11-19 10:30 ` [PATCH v4 13/22] cpupower: add AMD P-state capability flag Huang Rui
2021-11-19 10:30 ` [PATCH v4 14/22] cpupower: add the function to check amd-pstate enabled Huang Rui
2021-11-19 10:30 ` [PATCH v4 15/22] cpupower: initial AMD P-state capability Huang Rui
2021-11-19 10:30 ` [PATCH v4 16/22] cpupower: add the function to get the sysfs value from specific table Huang Rui
2021-11-19 20:38 ` Nathan Fontenot
2021-11-19 22:19 ` Juuso Alasuutari
2021-11-22 2:41 ` Huang Rui
2021-11-19 10:30 ` [PATCH v4 17/22] cpupower: introduce acpi cppc library Huang Rui
2021-11-19 10:30 ` [PATCH v4 18/22] cpupower: add amd-pstate sysfs definition and access helper Huang Rui
2021-11-19 10:30 ` [PATCH v4 19/22] cpupower: enable boost state support for amd-pstate module Huang Rui
2021-11-19 10:31 ` [PATCH v4 20/22] cpupower: move print_speed function into misc helper Huang Rui
2021-11-19 10:31 ` [PATCH v4 21/22] cpupower: print amd-pstate information on cpupower Huang Rui
2021-11-19 10:31 ` [PATCH v4 22/22] Documentation: amd-pstate: add amd-pstate driver introduction Huang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZeHdVexjhXN45qn@hr-amd \
--to=ray.huang@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Deepak.Sharma@amd.com \
--cc=Jinzhou.Su@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Nathan.Fontenot@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=bp@suse.de \
--cc=ggherdovich@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=skhan@linuxfoundation.org \
--cc=steven@valvesoftware.com \
--cc=viresh.kumar@linaro.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox