From: Huang Rui <ray.huang@amd.com>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: "rafael@kernel.org" <rafael@kernel.org>,
"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] cpufreq: amd-pstate: Fix struct amd_cpudata kernel-doc comment
Date: Thu, 6 Jan 2022 14:19:32 +0800 [thread overview]
Message-ID: <YdaJ9GFoz4AlIgQv@amd.com> (raw)
In-Reply-To: <20220106021605.93341-1-yang.lee@linux.alibaba.com>
On Thu, Jan 06, 2022 at 10:16:05AM +0800, Yang Li wrote:
> Add the description of @req and @boost_supported in struct amd_cpudata
> kernel-doc comment to remove warnings found by running scripts/kernel-doc,
> which is caused by using 'make W=1'.
>
> drivers/cpufreq/amd-pstate.c:104: warning: Function parameter or member
> 'req' not described in 'amd_cpudata'
> drivers/cpufreq/amd-pstate.c:104: warning: Function parameter or member
> 'boost_supported' not described in 'amd_cpudata'
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Acked-by: Huang Rui <ray.huang@amd.com>
> ---
> drivers/cpufreq/amd-pstate.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 40ceb031abf5..9ce75ed11f8e 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -68,6 +68,7 @@ static struct cpufreq_driver amd_pstate_driver;
> /**
> * struct amd_cpudata - private CPU data for AMD P-State
> * @cpu: CPU number
> + * @req: constraint request to apply
> * @cppc_req_cached: cached performance request hints
> * @highest_perf: the maximum performance an individual processor may reach,
> * assuming ideal conditions
> @@ -80,6 +81,7 @@ static struct cpufreq_driver amd_pstate_driver;
> * @min_freq: the frequency that mapped to lowest_perf
> * @nominal_freq: the frequency that mapped to nominal_perf
> * @lowest_nonlinear_freq: the frequency that mapped to lowest_nonlinear_perf
> + * @boost_supported: check whether the Processor or SBIOS supports boost mode
> *
> * The amd_cpudata is key private data for each CPU thread in AMD P-State, and
> * represents all the attributes and goals that AMD P-State requests at runtime.
> --
> 2.20.1.7.g153144c
>
next prev parent reply other threads:[~2022-01-06 6:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 2:16 [PATCH -next] cpufreq: amd-pstate: Fix struct amd_cpudata kernel-doc comment Yang Li
2022-01-06 6:19 ` Huang Rui [this message]
2022-01-06 17:29 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdaJ9GFoz4AlIgQv@amd.com \
--to=ray.huang@amd.com \
--cc=abaci@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).