From: Rob Herring <robh@kernel.org>
To: Brian Norris <briannorris@chromium.org>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Lin Huang <hl@rock-chips.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Derek Basehore <dbasehore@chromium.org>,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v4 01/15] dt-bindings: devfreq: rk3399_dmc: Convert to YAML
Date: Thu, 10 Mar 2022 12:17:07 -0600 [thread overview]
Message-ID: <YipAo5zWp/MF0NW6@robh.at.kernel.org> (raw)
In-Reply-To: <20220308110825.v4.1.I875ab8f28c5155a7d2f103316191954d4b07ac13@changeid>
On Tue, 08 Mar 2022 11:08:47 -0800, Brian Norris wrote:
> I want to add, deprecate, and bugfix some properties, as well as add the
> first users. This is easier with a proper schema.
>
> The transformation is mostly straightforward, plus a few notable tweaks:
>
> * Renamed rockchip,dram_speed_bin to rockchip,ddr3_speed_bin. The
> driver code and the example matched, but the description was
> different. I went with the implementation. Note that this property is
> also slated for deprecation/deletion in the subsequent patches.
>
> * Drop upthreshold and downdifferential properties from the example.
> These were undocumented (so, wouldn't pass validation), but were
> representing software properties (governor tweaks). I drop them from
> the driver in subsequent patches.
>
> * Rename clock from pclk_ddr_mon to dmc_clk. The driver, DT example,
> and all downstream users matched -- the binding definition was the
> exception. Anyway, "dmc_clk" is a more appropriately generic name.
>
> * Choose a better filename and location (this is a memory controller).
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
>
> Changes in v4:
> * Update .yaml to use more "default" entries, instead of free-form text
> * s/phandle-array/phandle/
> * Move to .../memory-controllers, update filename
>
> Changes in v3:
> * Add |maxItems| for devfreq-events
> * Improve deprecation notes
>
> Changes in v2:
> * rename to 'memory-controller' in example
> * place 'required' after properties
> * drop superluous free-form references and repetitions of other
> bindings
> * fix for yamllint
>
> .../bindings/devfreq/rk3399_dmc.txt | 212 ------------
> .../rockchip,rk3399-dmc.yaml | 306 ++++++++++++++++++
> 2 files changed, 306 insertions(+), 212 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/devfreq/rk3399_dmc.txt
> create mode 100644 Documentation/devicetree/bindings/memory-controllers/rockchip,rk3399-dmc.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2022-03-10 18:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220308190916epcas1p1baf4361cc5f33a90b38b01be7ffa748d@epcas1p1.samsung.com>
2022-03-08 19:08 ` [PATCH v4 00/15] rk3399: Clean up and enable DDR DVFS Brian Norris
2022-03-08 19:08 ` [PATCH v4 01/15] dt-bindings: devfreq: rk3399_dmc: Convert to YAML Brian Norris
2022-03-09 9:34 ` Krzysztof Kozlowski
2022-03-10 18:17 ` Rob Herring [this message]
2022-03-08 19:08 ` [PATCH v4 02/15] dt-bindings: devfreq: rk3399_dmc: Deprecate unused/redundant properties Brian Norris
2022-03-08 19:08 ` [PATCH v4 03/15] dt-bindings: devfreq: rk3399_dmc: Fix Hz units Brian Norris
2022-03-08 19:08 ` [PATCH v4 04/15] dt-bindings: devfreq: rk3399_dmc: Specify idle params in nanoseconds Brian Norris
2022-03-08 19:08 ` [PATCH v4 05/15] dt-bindings: devfreq: rk3399_dmc: Add more disable-freq properties Brian Norris
2022-03-08 19:08 ` [PATCH v4 06/15] PM / devfreq: rk3399_dmc: Drop undocumented ondemand DT props Brian Norris
2022-03-08 19:08 ` [PATCH v4 07/15] PM / devfreq: rk3399_dmc: Drop excess timing properties Brian Norris
2022-03-08 19:08 ` [PATCH v4 08/15] PM / devfreq: rk3399_dmc: Use bitfield macro definitions for ODT_PD Brian Norris
2022-03-08 19:08 ` [PATCH v4 09/15] PM / devfreq: rk3399_dmc: Support new disable-freq properties Brian Norris
2022-03-08 19:08 ` [PATCH v4 10/15] PM / devfreq: rk3399_dmc: Support new *-ns properties Brian Norris
2022-03-08 19:08 ` [PATCH v4 11/15] arm64: dts: rk3399: Add dfi and dmc nodes Brian Norris
2022-03-08 19:08 ` [PATCH v4 12/15] arm64: dts: rockchip: Enable dmc and dfi nodes on gru Brian Norris
2022-03-08 19:08 ` [PATCH v4 13/15] PM / devfreq: rk3399_dmc: Disable edev on remove() Brian Norris
2022-03-08 19:09 ` [PATCH v4 14/15] PM / devfreq: rk3399_dmc: Use devm_pm_opp_of_add_table() Brian Norris
2022-03-08 19:09 ` [PATCH v4 15/15] PM / devfreq: rk3399_dmc: Avoid static (reused) profile Brian Norris
2022-03-21 3:39 ` [PATCH v4 00/15] rk3399: Clean up and enable DDR DVFS Chanwoo Choi
2022-04-10 17:12 ` (subset) " Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YipAo5zWp/MF0NW6@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=briannorris@chromium.org \
--cc=cw00.choi@samsung.com \
--cc=dbasehore@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=hl@rock-chips.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=myungjoo.ham@samsung.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).