From: Huang Rui <ray.huang@amd.com>
To: "Limonciello, Mario" <Mario.Limonciello@amd.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
"open list:AMD PSTATE DRIVER" <linux-pm@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] Improve usability for amd-pstate
Date: Sun, 27 Mar 2022 19:56:23 +0800 [thread overview]
Message-ID: <YkBQ548oCbCqd6lE@amd.com> (raw)
In-Reply-To: <20220325054228.5247-1-mario.limonciello@amd.com>
On Fri, Mar 25, 2022 at 01:42:25PM +0800, Limonciello, Mario wrote:
> There has recently been some news coverage about `amd-pstate` being in
> 5.17, but this news also mentioned that it's a bit difficult to use.
>
> You need to either block init calls, or compile the module into the kernel
> to force it to take precedence over acpi-cpufreq.
>
> This series aims to improve the usability of amd-pstate so that distros
> can compile as a module, but users can still use it (relatively) easily.
>
> A new module parameter is included that will force amd-pstate to take
> precedence and a module table to let it load automatically on such systems.
>
> With the patches in this series a user can make a file
> /etc/modprobe.d/amd-pstate.conf:
>
> options amd-pstate replace=1
Actually, because the amd-pstate is fairly new for current distos, we can
modify /etc/modules-load.d/modules.conf to add one line "amd_pstate" to
inform the system this module should be loaded at boot time.
But your method also looks fine for me as well, the amd-pstate can force to
replace the acpi-cpufreq. I am not sure whether anyone objects to this way.
Thanks,
Ray
>
> Then upon the next reboot amd-pstate should load automatically even if
> acpi-cpufreq was included on the system.
> Mario Limonciello (3):
> cpufreq: Allow passing NULL as the argument for unregistering a driver
> cpufreq: amd-pstate: Allow replacing existing cpufreq drivers when
> loaded
> cpufreq: amd-pstate: Add a module device table
>
> drivers/cpufreq/amd-pstate.c | 19 ++++++++++++++++---
> drivers/cpufreq/cpufreq.c | 4 ++--
> 2 files changed, 18 insertions(+), 5 deletions(-)
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2022-03-27 11:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 5:42 [PATCH 0/3] Improve usability for amd-pstate Mario Limonciello
2022-03-25 5:42 ` [PATCH 1/3] cpufreq: Allow passing NULL as the argument for unregistering a driver Mario Limonciello
2022-03-27 13:23 ` Huang Rui
2022-03-25 5:42 ` [PATCH 2/3] cpufreq: amd-pstate: Allow replacing existing cpufreq drivers when loaded Mario Limonciello
2022-03-25 5:42 ` [PATCH 3/3] cpufreq: amd-pstate: Add a module device table Mario Limonciello
2022-03-27 13:27 ` Huang Rui
2022-03-27 11:56 ` Huang Rui [this message]
2022-03-28 22:14 ` [PATCH 0/3] Improve usability for amd-pstate Limonciello, Mario
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkBQ548oCbCqd6lE@amd.com \
--to=ray.huang@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).