From: Huang Rui <ray.huang@amd.com>
To: "Limonciello, Mario" <Mario.Limonciello@amd.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
"open list:AMD PSTATE DRIVER" <linux-pm@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] cpufreq: Export acpu_cpufreq_exit for other drivers to call
Date: Tue, 29 Mar 2022 13:47:15 +0800 [thread overview]
Message-ID: <YkKdY38OalxYw1Mn@amd.com> (raw)
In-Reply-To: <20220329015947.565-2-mario.limonciello@amd.com>
On Tue, Mar 29, 2022 at 09:59:45AM +0800, Limonciello, Mario wrote:
> Currently, the only way to load an alternative cpufreq driver is to unload
> acpi-cpufreq first.
>
> Loosen that restriction to allow other kernel modules to unregister a
> registered driver.
>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Reviewed-by: Huang Rui <ray.huang@amd.com>
> ---
> v1->v2:
> * Export symbol instead of changing internals
>
> drivers/cpufreq/acpi-cpufreq.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
> index 3d514b82d055..92ac978c1c53 100644
> --- a/drivers/cpufreq/acpi-cpufreq.c
> +++ b/drivers/cpufreq/acpi-cpufreq.c
> @@ -1033,7 +1033,7 @@ static int __init acpi_cpufreq_init(void)
> return ret;
> }
>
> -static void __exit acpi_cpufreq_exit(void)
> +void __exit acpi_cpufreq_exit(void)
> {
> pr_debug("%s\n", __func__);
>
> @@ -1043,6 +1043,7 @@ static void __exit acpi_cpufreq_exit(void)
>
> free_acpi_perf_data();
> }
> +EXPORT_SYMBOL_GPL(acpi_cpufreq_exit);
>
> module_param(acpi_pstate_strict, uint, 0644);
> MODULE_PARM_DESC(acpi_pstate_strict,
> --
> 2.34.1
>
next prev parent reply other threads:[~2022-03-29 5:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 1:59 [PATCH v2 0/3] Improve usability for amd-pstate Mario Limonciello
2022-03-29 1:59 ` [PATCH v2 1/3] cpufreq: Export acpu_cpufreq_exit for other drivers to call Mario Limonciello
2022-03-29 5:47 ` Huang Rui [this message]
2022-03-29 6:22 ` kernel test robot
2022-03-29 6:32 ` kernel test robot
2022-03-29 1:59 ` [PATCH v2 2/3] cpufreq: amd-pstate: Allow replacing acpi-cpufreq when loaded Mario Limonciello
2022-03-29 5:56 ` Huang Rui
2022-03-29 1:59 ` [PATCH v2 3/3] cpufreq: amd-pstate: Add a module device table Mario Limonciello
2022-03-29 5:56 ` Huang Rui
2022-03-29 6:02 ` [PATCH v2 0/3] Improve usability for amd-pstate Huang Rui
2022-03-29 20:47 ` Limonciello, Mario
2022-03-30 9:54 ` Huang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkKdY38OalxYw1Mn@amd.com \
--to=ray.huang@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).