From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB9EFC433FE for ; Thu, 31 Mar 2022 18:27:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234362AbiCaS3B (ORCPT ); Thu, 31 Mar 2022 14:29:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233699AbiCaS3A (ORCPT ); Thu, 31 Mar 2022 14:29:00 -0400 Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7B1E13E85 for ; Thu, 31 Mar 2022 11:27:12 -0700 (PDT) Received: by mail-ot1-x32a.google.com with SMTP id i11-20020a9d4a8b000000b005cda3b9754aso447069otf.12 for ; Thu, 31 Mar 2022 11:27:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Ltc+KGlVJEt0ntKZaop9IdeQ3yCdm7349yM+jp+RRuo=; b=cc+ZVXQP7FDY5KQDGdKQs+rcUfhwNU0gAcxLBBu5/sff+pe5JZFIpnr6Vy3VnUuvMv MOWn+v9u9VxnGt9eHTUKDdznj6/gfE/pMTtKJFaKiCxa38VDUpEtEDjKYwSHZP+McZ5l ln4dlqg2Szf4TZzSRGgj35cBZI5oXiGkcBjWSmRI8jVtc5QBBd/gv5Zq26u8m6zv6hCU gRiN7olb58jRgBIeNF+3GlUftQrE7bFcbki3ohVi1kD/7U8QI0whJgPBzDHDa7Ei2iLA gJTNZ6z2nCDik7EYRMbfsznzKNhxYLmtEbN4iqfr2gGXC2Hgc0JWIm97MWRZS32kFOwP Rhlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ltc+KGlVJEt0ntKZaop9IdeQ3yCdm7349yM+jp+RRuo=; b=F21a51VlJM+c3yEF5czk0uLflY7KK56/dFSb6frmbQ78ZXhvVOMC/NZsdQh3Xjulug MJQFNN31pojOtm9db2P9KC/J/XQXZyeTsfN6cMVrBhO9qIXIuAq6du7N9nfqQy4cJ3z1 XApqioUQ4ckcUjdvVlgUnVpXOr2XyyV1nqT5UNJyhXdGTMNKSvGuHfdOFvJ05ZAunRGC rYVbQJP1QQbVX7aLbvgxDLxnnvqhsnxG0dl06gPk2XqjCZmKIXOJK+gsy9GSQqL/4M2w 5K/HYbHJK4QqpZCETZFisBxCH0Ct7+xN9mcE0Xl+H/PFGW1AjKobDOrvJVuBvFeSqZ9d 5MnQ== X-Gm-Message-State: AOAM533XKk5OxZP6NVnLamcQztNrEoe+vBRfVAW7WzuD5MHrIgorlLP8 xJfPokewrEUa/3euqVNH36JTIA== X-Google-Smtp-Source: ABdhPJxmPd6T+iUYe3N8/CWnkB5yv5mWnv0+Jkw8c0FJ7oHe8wR49ZXLNETemi0tJ5n3zoO2dRDFrQ== X-Received: by 2002:a05:6830:3112:b0:5cd:b92b:22ea with SMTP id b18-20020a056830311200b005cdb92b22eamr6228593ots.262.1648751232102; Thu, 31 Mar 2022 11:27:12 -0700 (PDT) Received: from ripper ([2600:1700:a0:3dc8:205:1bff:fec0:b9b3]) by smtp.gmail.com with ESMTPSA id l1-20020a056830268100b005c93e625b9dsm193004otu.46.2022.03.31.11.27.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Mar 2022 11:27:10 -0700 (PDT) Date: Thu, 31 Mar 2022 11:29:40 -0700 From: Bjorn Andersson To: Vladimir Zapolskiy Cc: Viresh Kumar , "Rafael J. Wysocki" , Andy Gross , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 1/2] cpufreq: qcom-cpufreq-hw: Clear dcvs interrupts Message-ID: References: <20220328112836.2464486-1-vladimir.zapolskiy@linaro.org> <20220328112836.2464486-2-vladimir.zapolskiy@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220328112836.2464486-2-vladimir.zapolskiy@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Mon 28 Mar 04:28 PDT 2022, Vladimir Zapolskiy wrote: > It's noted that dcvs interrupts are not self-clearing, thus an interrupt > handler runs constantly, which leads to a severe regression in runtime. > To fix the problem an explicit write to clear interrupt register is > required. > > Fixes: 275157b367f4 ("cpufreq: qcom-cpufreq-hw: Add dcvs interrupt support") > Signed-off-by: Vladimir Zapolskiy > --- > drivers/cpufreq/qcom-cpufreq-hw.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c b/drivers/cpufreq/qcom-cpufreq-hw.c > index f9d593ff4718..53954e5086e0 100644 > --- a/drivers/cpufreq/qcom-cpufreq-hw.c > +++ b/drivers/cpufreq/qcom-cpufreq-hw.c > @@ -24,6 +24,8 @@ > #define CLK_HW_DIV 2 > #define LUT_TURBO_IND 1 > > +#define GT_IRQ_STATUS BIT(2) > + > #define HZ_PER_KHZ 1000 > > struct qcom_cpufreq_soc_data { > @@ -31,6 +33,7 @@ struct qcom_cpufreq_soc_data { > u32 reg_dcvs_ctrl; > u32 reg_freq_lut; > u32 reg_volt_lut; > + u32 reg_intr_clr; > u32 reg_current_vote; > u32 reg_perf_state; > u8 lut_row_size; > @@ -350,6 +353,9 @@ static irqreturn_t qcom_lmh_dcvs_handle_irq(int irq, void *data) > disable_irq_nosync(c_data->throttle_irq); > schedule_delayed_work(&c_data->throttle_work, 0); > This should only be done if reg_intr_clr != 0 (as it is for OSM). Other than that, I think looks good. Regards, Bjorn > + writel_relaxed(GT_IRQ_STATUS, > + c_data->base + c_data->soc_data->reg_intr_clr); > + > return IRQ_HANDLED; > } > > @@ -368,6 +374,7 @@ static const struct qcom_cpufreq_soc_data epss_soc_data = { > .reg_dcvs_ctrl = 0xb0, > .reg_freq_lut = 0x100, > .reg_volt_lut = 0x200, > + .reg_intr_clr = 0x308, > .reg_perf_state = 0x320, > .lut_row_size = 4, > }; > -- > 2.33.0 >