From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 938DDC433F5 for ; Fri, 22 Apr 2022 19:15:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229649AbiDVTSP (ORCPT ); Fri, 22 Apr 2022 15:18:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229574AbiDVTSO (ORCPT ); Fri, 22 Apr 2022 15:18:14 -0400 Received: from mail-oa1-x36.google.com (mail-oa1-x36.google.com [IPv6:2001:4860:4864:20::36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C7CB23F34E for ; Fri, 22 Apr 2022 12:04:55 -0700 (PDT) Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-deb9295679so9558282fac.6 for ; Fri, 22 Apr 2022 12:04:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=U5kbOYIbw9W5idi/w7UWPQThlgNI5YFtm66gzqTVHwI=; b=EosFqLT95BxHAVUXgvmDMUV5Lz2xaMtfJWrbZhJGacLzWlPy34JcgfMzn6ruT8Jsx1 /k/R+WO/a7/sW8WbwMoxUHuURYkIbCwrSeHhuFoEIigjXEhwSnf7lnkTrpCrS9B9b3oE tysYeR6jkN+E5fSBIA12eW/xrV9n6zaAKHLeQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=U5kbOYIbw9W5idi/w7UWPQThlgNI5YFtm66gzqTVHwI=; b=0Af+pdhEoQStDHwpNvr7CGI11gelo8hvqCTodAcKi9a+qEgwzbHfSVw0z2/mAaADBN aomfw7dEng6OJvxeubF1dNt19rqrP+iX9bW3Glo2B54A5oauw77RAUcXeOKdBnoC/haZ h48pa6YFuAkCxIzMoPKg4FkPF7HRRx270tk6DPpeVv/xW8GdAUK1h3o7sKujmG7SGAbf AtEf3fsTEOy2JCFLkQt4cLXkzyw/p6sgEldbXgIFYnzQI5mzFBKKZxpBSrPrepWhxY2h QWLExgzDFEJsQz6OcZfASRvgWV/D4dKXRryVMwCE/JWeIgnnS8qCuH1VCAct0CenfoHe QzXg== X-Gm-Message-State: AOAM531VGJLrKjZy3BgEXHIcs7YSyJeNVOwsfTwjTMxh99Qb01PgwKGd 50oRj8IWZv+6eJg/OGqlJqeiB9sie3C2lw== X-Google-Smtp-Source: ABdhPJzJ07qszw6srRpsPHUiNVf7zbKYzJ5hu40DkMqn2j3wMFLmW5tnu/Ucr3LTdOXuZO2YX+YXlg== X-Received: by 2002:a17:90a:d0c5:b0:1c9:ec78:18e5 with SMTP id y5-20020a17090ad0c500b001c9ec7818e5mr17636056pjw.53.1650653079678; Fri, 22 Apr 2022 11:44:39 -0700 (PDT) Received: from localhost ([2620:15c:202:201:404c:8721:29:87a4]) by smtp.gmail.com with UTF8SMTPSA id ch10-20020a056a00288a00b0050a51a95e91sm3041025pfb.201.2022.04.22.11.44.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Apr 2022 11:44:38 -0700 (PDT) Date: Fri, 22 Apr 2022 11:44:36 -0700 From: Matthias Kaehlcke To: "Rafael J. Wysocki" Cc: Sandeep Maheswaram , Rob Herring , Andy Gross , Bjorn Andersson , Greg Kroah-Hartman , Felipe Balbi , Stephen Boyd , Doug Anderson , Mathias Nyman , Krzysztof Kozlowski , Len Brown , Pavel Machek , Linux PM , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-msm , "open list:ULTRA-WIDEBAND (UWB) SUBSYSTEM:" , Linux Kernel Mailing List , quic_pkondeti@quicinc.com, quic_ppratap@quicinc.com, quic_kriskura@quicinc.com, quic_vpulyala@quicinc.com Subject: Re: [PATCH v14 2/7] PM / wakeup: Add device_children_wakeup_capable() Message-ID: References: <1650395470-31333-1-git-send-email-quic_c_sanm@quicinc.com> <1650395470-31333-3-git-send-email-quic_c_sanm@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Fri, Apr 22, 2022 at 01:57:17PM +0200, Rafael J. Wysocki wrote: > On Tue, Apr 19, 2022 at 9:11 PM Sandeep Maheswaram > wrote: > > > > From: Matthias Kaehlcke > > > > Add device_children_wakeup_capable() which checks whether the device itself > > or one if its descendants is wakeup capable. > > device_wakeup_path() exists for a very similar purpose. > > Is it not usable for whatever you need the new function introduced here? I wasn't aware of it's function, there are no doc comments and the name isn't really self explanatory. In a quick test device_wakeup_path() returned inconsistent values for the root hub, sometimes true, others false when a wakeup capable USB device was connected.