From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Carlos Bilbao <carlos.bilbao@amd.com>
Cc: amitk@kernel.org, thara.gopinath@gmail.com, agross@kernel.org,
david.brown@linaro.org, linux-pm@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
bilbao@vt.edu, konrad.dybcio@somainline.org
Subject: Re: [PATCH] thermal/drivers/qcom: Code refactoring
Date: Wed, 13 Jul 2022 14:47:49 -0500 [thread overview]
Message-ID: <Ys8hZYB/exrovqoY@builder.lan> (raw)
In-Reply-To: <e871f27d-2bfe-62e3-a5fa-8e1fe52e856a@amd.com>
On Wed 13 Jul 09:10 CDT 2022, Carlos Bilbao wrote:
> On 7/12/22 23:30, Bjorn Andersson wrote:
>
> > On Tue 12 Jul 12:31 CDT 2022, Carlos Bilbao wrote:
[..]
> > > diff --git a/drivers/thermal/qcom/tsens.h b/drivers/thermal/qcom/tsens.h
> > > index 2fd94997245b..d2d78c7e20c8 100644
> > > --- a/drivers/thermal/qcom/tsens.h
> > > +++ b/drivers/thermal/qcom/tsens.h
> > > @@ -6,6 +6,7 @@
> > > #ifndef __QCOM_TSENS_H__
> > > #define __QCOM_TSENS_H__
> > > +#define MAX_NUM_SENSORS 11
> > This only seems to apply for the three cases you have listed here, e.g.
> > tsens-v2 (which also includes tsens.h) has max_sensors = 16.
>
> This should be an array with an enum for the versions.
>
As the numbers are used within each c-file, some defines at the top of
these would probably be a good idea.
Regards,
Bjorn
prev parent reply other threads:[~2022-07-13 19:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 17:31 [PATCH] thermal/drivers/qcom: Code refactoring Carlos Bilbao
2022-07-13 0:20 ` Konrad Dybcio
2022-07-13 4:30 ` Bjorn Andersson
2022-07-13 14:10 ` Carlos Bilbao
2022-07-13 19:47 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ys8hZYB/exrovqoY@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=amitk@kernel.org \
--cc=bilbao@vt.edu \
--cc=carlos.bilbao@amd.com \
--cc=david.brown@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=thara.gopinath@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).