From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF341C43334 for ; Wed, 13 Jul 2022 19:47:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236437AbiGMTry (ORCPT ); Wed, 13 Jul 2022 15:47:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232077AbiGMTrx (ORCPT ); Wed, 13 Jul 2022 15:47:53 -0400 Received: from mail-oa1-x2e.google.com (mail-oa1-x2e.google.com [IPv6:2001:4860:4864:20::2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16F8B20BF8 for ; Wed, 13 Jul 2022 12:47:52 -0700 (PDT) Received: by mail-oa1-x2e.google.com with SMTP id 586e51a60fabf-f2a4c51c45so15326274fac.9 for ; Wed, 13 Jul 2022 12:47:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8D95/yVq1YOPcWb/WH+y2oBHLQ7lhx2cc7uibhPQelU=; b=dH8hhAHOKfY4Js+RT7XzGfmxv9ffH4ZqgZ0Gj1n09yPcYZA72LaVZKIw5nHwp/l0/D 2VF2TEZCtUHVVdRpCzGGzO9qdD5nZ/NIUKiuDm1LE4lufnEaOQt6+jQ+MbKQFEcQfqEv Hd7UGwzzcsz8A95Bg/16g4AJvOhLT1EbzzR9ddEd4BvXFQxlY6DJpwLl6A+d2u+dJBH1 xbgrV9ucMHI8k9iwiyj9K+rPumk5LeGQf2IUX+DhxnWrLcUgkdVEBlJppzLBYmNaKrjm dMQRD8u9+/mZiaKxZZRF5yqLEVI6jnB+sxrv2XTIC7bNzvLvemoIT2nc284A6Lg2+nv+ hYHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8D95/yVq1YOPcWb/WH+y2oBHLQ7lhx2cc7uibhPQelU=; b=V+EaHLUxFSZBY2DBLB2wxpl+5ENKM+VkT9evmvRQ+quk9Cvuk5/Z9JMHLiWRBflfdu YuaMu+cZ9YOSD39HOJUqKQ16F/ds2Wc8Gi/NhmFKaDVcMV6BLw2/DQnE1wSlzXBWUaFE XH9kJwOlhq45eDZVH9LyfqoU80YB+g/bESwAeYU9ymRBmGFIKmST9PutkStPdJA9Mm2k o+a5qJUxgtZW9EzgB18QjTWFE1IRyJEpwPRiGLv6isoLJefnLXJKFEreSKdvd5xOfxva ateGEUl4Vo7E589TPLqzWE6AbYnIi/X5MhYARmdmn4lVHnFABly4fTCozfblIJu//kV1 OWrQ== X-Gm-Message-State: AJIora+SFAm9zHtjZA5c6ZidDYtwdWT6ZWYHkSXlx3JkdXXgZKYYGu+d tOSwaTO8FhidhPXnYR5+HBHweA== X-Google-Smtp-Source: AGRyM1uH/VRp/joNX/6VEBMrEKeWbVj0WND0pXItrY4oNfwPUuy3tkv8Jx3nhK5VMUAKTBfnmrCUgg== X-Received: by 2002:a05:6870:c58b:b0:10b:d21d:ad5e with SMTP id ba11-20020a056870c58b00b0010bd21dad5emr2693156oab.287.1657741671470; Wed, 13 Jul 2022 12:47:51 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id m20-20020a0568080f1400b0032e5d0b5d5fsm5703551oiw.58.2022.07.13.12.47.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jul 2022 12:47:50 -0700 (PDT) Date: Wed, 13 Jul 2022 14:47:49 -0500 From: Bjorn Andersson To: Carlos Bilbao Cc: amitk@kernel.org, thara.gopinath@gmail.com, agross@kernel.org, david.brown@linaro.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, bilbao@vt.edu, konrad.dybcio@somainline.org Subject: Re: [PATCH] thermal/drivers/qcom: Code refactoring Message-ID: References: <20220712173127.3677491-1-carlos.bilbao@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Wed 13 Jul 09:10 CDT 2022, Carlos Bilbao wrote: > On 7/12/22 23:30, Bjorn Andersson wrote: > > > On Tue 12 Jul 12:31 CDT 2022, Carlos Bilbao wrote: [..] > > > diff --git a/drivers/thermal/qcom/tsens.h b/drivers/thermal/qcom/tsens.h > > > index 2fd94997245b..d2d78c7e20c8 100644 > > > --- a/drivers/thermal/qcom/tsens.h > > > +++ b/drivers/thermal/qcom/tsens.h > > > @@ -6,6 +6,7 @@ > > > #ifndef __QCOM_TSENS_H__ > > > #define __QCOM_TSENS_H__ > > > +#define MAX_NUM_SENSORS 11 > > This only seems to apply for the three cases you have listed here, e.g. > > tsens-v2 (which also includes tsens.h) has max_sensors = 16. > > This should be an array with an enum for the versions. > As the numbers are used within each c-file, some defines at the top of these would probably be a good idea. Regards, Bjorn