From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71044C25B0E for ; Tue, 16 Aug 2022 11:12:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235437AbiHPLM0 (ORCPT ); Tue, 16 Aug 2022 07:12:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234524AbiHPLMH (ORCPT ); Tue, 16 Aug 2022 07:12:07 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0B5110D3 for ; Tue, 16 Aug 2022 02:01:11 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id a9so13921296lfm.12 for ; Tue, 16 Aug 2022 02:01:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech-se.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc; bh=q+bgDPRgPRHSxrHtdS3PxKXnrSqyZcY4lba+sAly1/w=; b=XBVexQTwUHJ5vuvI5fwHlQzDP8BSNOYEEWzB2HwtcIdr9VgldN+f6gjCzgLc5YRghT bDTws6K01yYvmFxi+URd10lUW+EO+knrJSEUzk3wMm9S4Bxy/P9BjkJPyxwm5gVg/mLa Er83nwuGoQWKtrGCfqjk0once47DoY/L5U0f7CIw0OhZYPalN9hVk5KZV2tsROVueKwb hEhE+2ttmNq06MgugEwnbklerttW2i5JUUE29lvYheBllvPnrkYA1VfCjWsWIaC50yZZ i7Kj0FeFYQMKNs3MrBQyi5LxndolnW6WiN082esUuUgZgqe0vV0iZ3Jigi8cbdAMnAqz d9ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc; bh=q+bgDPRgPRHSxrHtdS3PxKXnrSqyZcY4lba+sAly1/w=; b=500kDaEtl7Ahs0CMK/vgaOuCNxg49rnujXIjUZp90AHh+Ugk6omBC+xutFkhIYP+2L ENax5uXbKrFnTYzeJ5JNvmpdNCajjPC8+L7/6Sjh8HTff6nUAsqW7fSZRDIgXihcSpqJ R3s/u57AZ1798cCzkvyaqB9osUYOgCqizMdmvJ40NTp2mfrHv2w03WFhMx19ynkbzgU9 Gpk6eEYLhcnhZZ8A1XwmeUhvhVI5khz6kTCbvwe1ioG3caoJ/NlHkTdIdPGqe3oOtAbx s/ooEuocN3/BnlFwExKHzq4uZY+lBC89lZIFzVahB2oO/6sBvUsxqY+V5fXVxjxALlgv 4DuA== X-Gm-Message-State: ACgBeo3Ij440eZ095bS3o0QhaVsKhbalU2nC5e0ECdN/b78EGMLwX9IV EFh5n7Q+3ZYVw5+4uYwsccQSpw== X-Google-Smtp-Source: AA6agR4Rrs4sw4cWiTGLXoKhr6OEFnD9GHLxlEK0MF5jg4T84VBOnAh9FVPk2fjCu0Ybz5mk/e5WJg== X-Received: by 2002:a05:6512:3d8e:b0:48a:eff4:6b03 with SMTP id k14-20020a0565123d8e00b0048aeff46b03mr6570827lfv.49.1660640470377; Tue, 16 Aug 2022 02:01:10 -0700 (PDT) Received: from localhost (h-46-59-89-207.A463.priv.bahnhof.se. [46.59.89.207]) by smtp.gmail.com with ESMTPSA id p10-20020a05651211ea00b0048b04d494c6sm1323538lfs.51.2022.08.16.02.01.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Aug 2022 02:01:09 -0700 (PDT) Date: Tue, 16 Aug 2022 11:01:09 +0200 From: Niklas =?iso-8859-1?Q?S=F6derlund?= To: Daniel Lezcano Cc: rafael@kernel.org, rui.zhang@intel.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Amit Kucheria , "open list:RENESAS R-CAR THERMAL DRIVERS" Subject: Re: [PATCH v2 15/26] thermal/drivers/rcar_gen3: Use the generic function to get the number of trips Message-ID: References: <20220809220436.711020-1-daniel.lezcano@linaro.org> <20220809220436.711020-16-daniel.lezcano@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220809220436.711020-16-daniel.lezcano@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hello Daniel, Thanks for your work. On 2022-08-10 00:04:25 +0200, Daniel Lezcano wrote: > The thermal core framework allows to get the number of thermal trips, > use it instead of visiting the thermal core structure internals. > > Signed-off-by: Daniel Lezcano Reviewed-by: Niklas Söderlund > --- > drivers/thermal/rcar_gen3_thermal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c > index 40ec63ad0a1b..6a6aaad2bcac 100644 > --- a/drivers/thermal/rcar_gen3_thermal.c > +++ b/drivers/thermal/rcar_gen3_thermal.c > @@ -525,7 +525,7 @@ static int rcar_gen3_thermal_probe(struct platform_device *pdev) > if (ret) > goto error_unregister; > > - ret = of_thermal_get_ntrips(tsc->zone); > + ret = thermal_zone_get_num_trips(tsc->zone); > if (ret < 0) > goto error_unregister; > > -- > 2.34.1 > -- Kind Regards, Niklas Söderlund