From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB73EC28D13 for ; Sun, 21 Aug 2022 14:02:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230462AbiHUOCK (ORCPT ); Sun, 21 Aug 2022 10:02:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231186AbiHUOBv (ORCPT ); Sun, 21 Aug 2022 10:01:51 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED8AA24968; Sun, 21 Aug 2022 07:01:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7E80260ED3; Sun, 21 Aug 2022 14:01:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33A1AC433C1; Sun, 21 Aug 2022 14:01:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1661090466; bh=0k2zh45ukdQfjSibWwXrqGwdFRWofhv4XHMJZjqOtp8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c/6VFKEhJiCIvysZjWrhxXgpSXUVwFwFrosz10dp4vugPPHye5D6Te45gL1BkGzJ8 MAPQiKLK0MjEZ9PtJMp+Hq5+OV3IP6KyumZxXVon8ALJS16rN2Iv2m0VFfueaD2fm8 iaMDQOe7h5qz0yue3hSt1Bfs6T1i5RP7qd5V0GtU= Date: Sun, 21 Aug 2022 16:01:03 +0200 From: Greg KH To: Vimal Kumar Cc: chinmoyghosh2001@gmail.com, Mintu Patel , Vishal Badole , "Rafael J. Wysocki" , Pavel Machek , Len Brown , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] PM: runtime: Add support to disable wakeup sources Message-ID: References: <20220821134533.22901-1-vimal.kumar32@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220821134533.22901-1-vimal.kumar32@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Sun, Aug 21, 2022 at 07:15:32PM +0530, Vimal Kumar wrote: > User could find many wakeup sources available in the bsp, which > they won't be using. Currently users can only get the status and > list of enabled wakeup sources, but users can't disable it runtime. > It's very difficult to find the driver for each wakeup sources from > where it's getting enabled and make the changes for disabling it. > > This will help users to disable any wakeup sources at runtime, > avoiding any code change and re-compilation. A new class attribute > "disable_ws" will be added in the wakeup calss. If user want to disable > any wakeup sources, user need to find the wakeup dev node associated > with the particular wakeup source and write the devnode name to the > class attribute "disable_ws". > > Example: > Need to disable the wakeup source '1c08000.qcom,pcie'. The dev node > associated with this wakeup source is: > cat /sys/class/wakeup3/name ==> "1c08000.qcom,pcie", then for disabling > this wakeup source : > echo wakeup3 > /sys/class/wakeup/disable_ws > > Co-developed-by: Mintu Patel > Signed-off-by: Mintu Patel > Co-developed-by: Vishal Badole > Signed-off-by: Vishal Badole > Signed-off-by: Vimal Kumar That's a lot of gmail accounts, no "company" accounts? :) > --- > drivers/base/power/wakeup_stats.c | 63 ++++++++++++++++++++++++++++++- You need a Documentation/ABI/ entry for any new sysfs file so we can properly review this and support it over time. thanks, greg k-h