From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5002CC00140 for ; Wed, 24 Aug 2022 06:49:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234437AbiHXGtG (ORCPT ); Wed, 24 Aug 2022 02:49:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229674AbiHXGtF (ORCPT ); Wed, 24 Aug 2022 02:49:05 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD8A285FA3; Tue, 23 Aug 2022 23:49:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fcsY3Qh6TepPJ/4fx7/kuX9sdRrqVQM7ufFixq4/Q+E=; b=kxy9aSUz9kdXYUN5Ynyv0t2iIt ibpo4uc1JSMGQnjJJrpLwO94fmA83Qo5rs0NKIKXlIDt8xSznFk+dSiyhigynBdCZxbnojbFjTSnM o3fiHR6jwULnEf02P2pw2mlEG2gcBWbGLgUbwBYsioEejnchueJ1YMdjaqTUnBB2gYXL6qm8HTg61 12IzadzuCA7drwHrIAEeRhUBQdgsoWaAZ8mTNxHMNRb9lBQ2VTxT+mU2vowFXkqVXyI/6+MD1JYy5 rZFXoccGQK9rzs9ceIYt+VRuj56IeNgX1TMxXlNPrg5JgCseS7yBUZctydRoycXiHOgzRRUXJ4wF1 vnEeqVKQ==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=worktop.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQkBm-005cJK-Ma; Wed, 24 Aug 2022 06:48:36 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 2FF42980403; Wed, 24 Aug 2022 08:48:33 +0200 (CEST) Date: Wed, 24 Aug 2022 08:48:33 +0200 From: Peter Zijlstra To: FirstName LastName Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Jacob Pan , Len Brown , Michael Roth , Alexei Starovoitov , Josh Poimboeuf , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH] x86/msr: add idle version of wrmsr trace Message-ID: References: <20220823234353.937002-1-pshier@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220823234353.937002-1-pshier@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Dear FirstName LastName, pleae fix your MUA. On Tue, Aug 23, 2022 at 04:43:53PM -0700, FirstName LastName wrote: > From: Peter Shier > > With commit bf5835bcdb963 ("intel_idle: Disable IBRS during long idle"), > enabling wrmsr trace with CONFIG_LOCKDEP causes "suspicious > rcu_dereference_check() usage" warning because do_trace_write_msr does not > use trace_write_msr_rcuidle. > No, the right thing here is to not do tracing at all. *sigh* I should go finish this series: https://lore.kernel.org/lkml/20220608142723.103523089@infradead.org/ --- diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c index 3e101719689a..6e82b2df29cb 100644 --- a/drivers/idle/intel_idle.c +++ b/drivers/idle/intel_idle.c @@ -187,12 +187,12 @@ static __cpuidle int intel_idle_ibrs(struct cpuidle_device *dev, int ret; if (smt_active) - wrmsrl(MSR_IA32_SPEC_CTRL, 0); + __native_wrmsr(MSR_IA32_SPEC_CTRL, 0); ret = __intel_idle(dev, drv, index); if (smt_active) - wrmsrl(MSR_IA32_SPEC_CTRL, spec_ctrl); + __native_wrmsr(MSR_IA32_SPEC_CTRL, spec_ctrl); return ret; }