From: Peter Zijlstra <peterz@infradead.org>
To: FirstName LastName <pshier@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
Len Brown <lenb@kernel.org>, Michael Roth <michael.roth@amd.com>,
Alexei Starovoitov <ast@kernel.org>,
Josh Poimboeuf <jpoimboe@kernel.org>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH] x86/msr: add idle version of wrmsr trace
Date: Wed, 24 Aug 2022 09:22:09 +0200 [thread overview]
Message-ID: <YwXRoUfI87HYOnTd@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <YwXJwTOFWRFPilOy@worktop.programming.kicks-ass.net>
On Wed, Aug 24, 2022 at 08:48:33AM +0200, Peter Zijlstra wrote:
> diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
> index 3e101719689a..6e82b2df29cb 100644
> --- a/drivers/idle/intel_idle.c
> +++ b/drivers/idle/intel_idle.c
> @@ -187,12 +187,12 @@ static __cpuidle int intel_idle_ibrs(struct cpuidle_device *dev,
> int ret;
>
> if (smt_active)
> - wrmsrl(MSR_IA32_SPEC_CTRL, 0);
> + __native_wrmsr(MSR_IA32_SPEC_CTRL, 0);
>
> ret = __intel_idle(dev, drv, index);
>
> if (smt_active)
> - wrmsrl(MSR_IA32_SPEC_CTRL, spec_ctrl);
> + __native_wrmsr(MSR_IA32_SPEC_CTRL, spec_ctrl);
>
> return ret;
> }
Clearly I should not be sending email before having wake-up-juice.. that
should of course be native_wrmsr(SPEC_CTRL, val, 0) etc..
prev parent reply other threads:[~2022-08-24 7:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 23:43 [PATCH] x86/msr: add idle version of wrmsr trace FirstName LastName
2022-08-24 6:48 ` Peter Zijlstra
2022-08-24 7:22 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwXRoUfI87HYOnTd@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ast@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=jpoimboe@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=michael.roth@amd.com \
--cc=mingo@redhat.com \
--cc=pshier@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox