From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8598C04AA5 for ; Thu, 25 Aug 2022 08:41:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238070AbiHYIli (ORCPT ); Thu, 25 Aug 2022 04:41:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237962AbiHYIle (ORCPT ); Thu, 25 Aug 2022 04:41:34 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E2B1A74DD; Thu, 25 Aug 2022 01:41:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FdDKwLQIFF3XT7VdsHerVnHoM6og2GUoRewPRYo5YL0=; b=mm/qZb7Wpfja18NPet6+fdXPOz X89v/raFb0p3jtXBJQktL3E7bObQ+eRFEpIk4fzBUS3X39e4/wqs68cMsXx4A9E/hKM8CE2ZiWPEh nEvK0J4V5nzc/f0vmIou2Jnj4jM4LYXpeRss2kxPzVKL4THxieMykYtUpu8XQamTzdFJVhAUOoRxz 35V+x3IgtW5xNvNWdsSfAvE0IJgbrhCGsoFQKdhqY5OnI4uVEokdyvbbBSm4mKc5C+VNtcgPVLKBy 1wa6v1N6LKux+7sH/By4faExAk30UCjYkrnomwS6mdmFCziDdde1GwtP5BM0fQRuXwUm4pGnh+uK8 TQ6VhGdg==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=worktop.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oR8QA-005xma-Fc; Thu, 25 Aug 2022 08:41:02 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 7236598014D; Thu, 25 Aug 2022 10:41:01 +0200 (CEST) Date: Thu, 25 Aug 2022 10:41:01 +0200 From: Peter Zijlstra To: Peter Shier Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Jacob Pan , Len Brown , Michael Roth , Alexei Starovoitov , Josh Poimboeuf , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v2] intel_idle: avoid tracing MSR writes while idling Message-ID: References: <20220824234211.1625026-1-pshier@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220824234211.1625026-1-pshier@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Wed, Aug 24, 2022 at 04:42:11PM -0700, Peter Shier wrote: > With commit bf5835bcdb963 ("intel_idle: Disable IBRS during long idle"), > enabling wrmsr trace with CONFIG_LOCKDEP causes "suspicious > rcu_dereference_check() usage" warning because do_trace_write_msr does not > use trace_write_msr_rcuidle. > > Change intel_idle_ibrs to use native_wrmsr to avoid tracing > > Signed-off-by: Peter Shier > --- Acked-by: Peter Zijlstra (Intel) > drivers/idle/intel_idle.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c > index 3e101719689a..df129c73786f 100644 > --- a/drivers/idle/intel_idle.c > +++ b/drivers/idle/intel_idle.c > @@ -187,12 +187,12 @@ static __cpuidle int intel_idle_ibrs(struct cpuidle_device *dev, > int ret; > > if (smt_active) > - wrmsrl(MSR_IA32_SPEC_CTRL, 0); > + native_wrmsr(MSR_IA32_SPEC_CTRL, 0); > > ret = __intel_idle(dev, drv, index); > > if (smt_active) > - wrmsrl(MSR_IA32_SPEC_CTRL, spec_ctrl); > + native_wrmsr(MSR_IA32_SPEC_CTRL, spec_ctrl); > > return ret; > } > --