From: Greg KH <gregkh@linuxfoundation.org>
To: Vimal Kumar <vimal.kumar32@gmail.com>
Cc: chinmoyghosh2001@gmail.com, Mintu Patel <mintupatel89@gmail.com>,
Vishal Badole <badolevishal1116@gmail.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] PM: runtime: Add support to disable wakeup sources
Date: Thu, 1 Sep 2022 17:56:50 +0200 [thread overview]
Message-ID: <YxDWQjMlEGQH4yz3@kroah.com> (raw)
In-Reply-To: <20220827114028.GA258@DESKTOP-KA7F9LU.localdomain>
On Sat, Aug 27, 2022 at 05:10:28PM +0530, Vimal Kumar wrote:
> On Sun, Aug 21, 2022 at 04:03:40PM +0200, Greg KH wrote:
> > On Sun, Aug 21, 2022 at 07:15:32PM +0530, Vimal Kumar wrote:
> > > User could find many wakeup sources available in the bsp, which
> > > they won't be using. Currently users can only get the status and
> > > list of enabled wakeup sources, but users can't disable it runtime.
> > > It's very difficult to find the driver for each wakeup sources from
> > > where it's getting enabled and make the changes for disabling it.
> > >
> > > This will help users to disable any wakeup sources at runtime,
> > > avoiding any code change and re-compilation. A new class attribute
> > > "disable_ws" will be added in the wakeup calss. If user want to disable
> > > any wakeup sources, user need to find the wakeup dev node associated
> > > with the particular wakeup source and write the devnode name to the
> > > class attribute "disable_ws".
What userspace tool will use this new interface?
Who is supposed to interact with it? Why is this even needed? Who
would disable this dynamically, shouldn't the kernel handle this all
automatically with no need for usersapce to get involved?
What is the root problem here you are trying to solve?
thanks,
greg k-h
next prev parent reply other threads:[~2022-09-01 15:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-21 13:45 [PATCH v1] PM: runtime: Add support to disable wakeup sources Vimal Kumar
2022-08-21 14:01 ` Greg KH
2022-08-21 14:03 ` Greg KH
2022-08-27 11:40 ` Vimal Kumar
2022-09-01 15:56 ` Greg KH [this message]
2022-08-21 20:06 ` kernel test robot
2022-08-21 20:17 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxDWQjMlEGQH4yz3@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=badolevishal1116@gmail.com \
--cc=chinmoyghosh2001@gmail.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mintupatel89@gmail.com \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=vimal.kumar32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox