From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 999DB7F9; Mon, 17 Feb 2025 12:31:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739795515; cv=none; b=MJ+49WQheyc3UPkXqL/3Mra02dF6FXFx4T1isxwAGN5+CZx/JPX+6Iia3PhsgmwZDvw4b805KjVOGDCiYvRZyTwirdmX6L54uttsJRgrRPwm1BHWhTbMAitENkdlLeaPjAI97llOUy7uueTiBQjj3TsVd04zghooRb+IUcsmDAk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739795515; c=relaxed/simple; bh=mLoswGq4ee6hpNyl8OOh6wrbHYc6wwRA6DU8avtw+Tw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=O7yxuRDRQtbItJauivYBZMKv3yOX1PjSGmiCrnvOtPbYJzLp/OBP7kG3HEObcRFpRAX0VQM/oAE8reUdXGNFB56q86fz1iqDePz1CxMOtgaZHLwI3Zgjvf4KzkvfcN0ZeBahvr8I4giXFrAxL6iXW7Orwj9qPWhOkysM0b3lmj8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 16C171692; Mon, 17 Feb 2025 04:32:12 -0800 (PST) Received: from bogus (e133711.arm.com [10.1.196.55]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 198303F5A1; Mon, 17 Feb 2025 04:31:49 -0800 (PST) Date: Mon, 17 Feb 2025 12:31:47 +0000 From: Sudeep Holla To: "Rafael J. Wysocki" Cc: Keita Morisaki , Ulf Hansson , lpieralisi@kernel.org, linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, linux-trace-kernel@vger.kernel.org, aarontian@google.com, Sudeep Holla , yimingtseng@google.com, Dhruva Gole , Kevin Hilman Subject: Re: [PATCH v5 RESEND] cpuidle: psci: Add trace for PSCI domain idle Message-ID: References: <20250210055828.1875372-1-keyz@google.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Feb 17, 2025 at 12:57:07PM +0100, Rafael J. Wysocki wrote: > +Ulf > > On Mon, Feb 10, 2025 at 6:58 AM Keita Morisaki wrote: > > > > The trace event cpu_idle provides insufficient information for debugging > > PSCI requests due to lacking access to determined PSCI domain idle > > states. The cpu_idle usually only shows -1, 0, or 1 regardless how many > > idle states the power domain has. > > > > Add new trace events namely psci_domain_idle_enter and > > psci_domain_idle_exit to trace enter and exit events with a determined > > idle state. > > > > These new trace events will help developers debug CPUidle issues on ARM > > systems using PSCI by providing more detailed information about the > > requested idle states. > > > > Signed-off-by: Keita Morisaki > > Reviewed-by: Steven Rostedt (Google) > > Reviewed-by: Dhruva Gole > > Tested-by: Kevin Hilman > > --- > > v1->v2: Split the ftrace event into two (psci_domain_idle_(enter|exit)) > > and rephrase the commit message accordingly. Rebased onto the latest. > > v2->v3: Add "Reviewed-by: Steven Rostedt" > > v3->v4: Add the Tested-by label > > v4->v5: Add "Reviewed-by: Dhruva Gole" > > > > Hopefully this patch gets attention from maintainers of > > drivers/cpuidle/cpuidle-psci.c too. > > Lorenzo, Sudeep, Ulf, any comments? > Looks good to me. I left it to Ulf, FWIW: Acked-by: Sudeep Holla -- Regards, Sudeep