public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Sicelo <absicsz@gmail.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Sebastian Reichel <sre@kernel.org>,
	pali@kernel.org, linux-pm@vger.kernel.org,
	maemo-leste@lists.dyne.org, phone-devel@vger.kernel.org,
	Discussions about the Letux Kernel <letux-kernel@openphoenux.org>,
	akemnade@kernel.org
Subject: Re: [PATCH] power: supply: bq27xxx: do not report bogus zero values
Date: Wed, 12 Mar 2025 14:28:10 +0200	[thread overview]
Message-ID: <Z9F92vGJbyUSFgxa@tp440p.steeds.sam> (raw)
In-Reply-To: <4D7D3E00-59C6-42F6-AE96-F04970D60E8D@goldelico.com>

Hi Nikolaus

On Fri, Feb 28, 2025 at 11:01:35AM +0100, H. Nikolaus Schaller wrote:
> > 
> > Thanks for the review. I will do more thorough testing over the weekend
> > and send the patch.

I have made a follow-up patch [0], which produces the following values
on the N900:

bq27200 in 'normal' state:

   DEVTYPE=power_supply
   OF_NAME=bq27200
   OF_FULLNAME=/ocp@68000000/i2c@48072000/bq27200@55
   OF_COMPATIBLE_0=ti,bq27200
   OF_COMPATIBLE_N=1
   POWER_SUPPLY_NAME=bq27200-0
   POWER_SUPPLY_TYPE=Battery
   POWER_SUPPLY_STATUS=Discharging
   POWER_SUPPLY_HEALTH=Calibration required
   POWER_SUPPLY_PRESENT=1
   POWER_SUPPLY_TECHNOLOGY=Li-ion
   POWER_SUPPLY_CYCLE_COUNT=0
   POWER_SUPPLY_VOLTAGE_MAX_DESIGN=4064000
   POWER_SUPPLY_VOLTAGE_MIN_DESIGN=3000000
   POWER_SUPPLY_VOLTAGE_NOW=3536000
   POWER_SUPPLY_CURRENT_NOW=-432327
   POWER_SUPPLY_POWER_AVG=1146100
   POWER_SUPPLY_CHARGE_FULL_DESIGN=2056320
   POWER_SUPPLY_CHARGE_FULL=2050560
   POWER_SUPPLY_CHARGE_NOW=366680
   POWER_SUPPLY_ENERGY_NOW=1207420
   POWER_SUPPLY_CAPACITY=18
   POWER_SUPPLY_CAPACITY_LEVEL=Normal
   POWER_SUPPLY_TEMP=316
   POWER_SUPPLY_TIME_TO_EMPTY_NOW=4140
   POWER_SUPPLY_TIME_TO_EMPTY_AVG=3780
   POWER_SUPPLY_TYPE=Battery
   POWER_SUPPLY_MANUFACTURER=Texas Instruments

bq27200 in 'broken' state:

   DEVTYPE=power_supply
   OF_NAME=bq27200
   OF_FULLNAME=/ocp@68000000/i2c@48072000/bq27200@55
   OF_COMPATIBLE_0=ti,bq27200
   OF_COMPATIBLE_N=1
   POWER_SUPPLY_NAME=bq27200-0
   POWER_SUPPLY_TYPE=Battery
   POWER_SUPPLY_STATUS=Discharging
   POWER_SUPPLY_HEALTH=Calibration required
   POWER_SUPPLY_PRESENT=1
   POWER_SUPPLY_TECHNOLOGY=Li-ion
   POWER_SUPPLY_CYCLE_COUNT=0
   POWER_SUPPLY_VOLTAGE_MAX_DESIGN=4064000
   POWER_SUPPLY_VOLTAGE_MIN_DESIGN=3000000
   POWER_SUPPLY_VOLTAGE_NOW=3633000
   POWER_SUPPLY_CURRENT_NOW=-397341
   POWER_SUPPLY_POWER_AVG=1432260
   POWER_SUPPLY_CHARGE_FULL_DESIGN=2056320
   POWER_SUPPLY_CHARGE_FULL=2050560
   POWER_SUPPLY_CAPACITY_LEVEL=Normal
   POWER_SUPPLY_TEMP=299
   POWER_SUPPLY_TYPE=Battery
   POWER_SUPPLY_MANUFACTURER=Texas Instruments


Hope this also works fine on your devices.

Thanks and Regards
Sicelo



[0] https://lore.kernel.org/linux-pm/20250312121712.146109-1-absicsz@gmail.com/T/#t

  parent reply	other threads:[~2025-03-12 12:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-07 21:51 [PATCH] power: supply: bq27xxx: do not report bogus zero values Sicelo A. Mhlongo
2025-02-27 17:14 ` H. Nikolaus Schaller
2025-02-27 17:48   ` H. Nikolaus Schaller
2025-02-28  8:02     ` Sicelo
2025-02-28  8:27       ` H. Nikolaus Schaller
2025-02-28  9:54         ` Sicelo
2025-02-28 10:01           ` H. Nikolaus Schaller
2025-03-10 17:26             ` Sicelo
2025-03-12  7:19               ` Sebastian Reichel
2025-03-12 12:20                 ` Sicelo
2025-03-12 12:28             ` Sicelo [this message]
2025-03-13  7:28               ` H. Nikolaus Schaller
2025-03-13  7:42                 ` Andreas Kemnade

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z9F92vGJbyUSFgxa@tp440p.steeds.sam \
    --to=absicsz@gmail.com \
    --cc=akemnade@kernel.org \
    --cc=hns@goldelico.com \
    --cc=letux-kernel@openphoenux.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=maemo-leste@lists.dyne.org \
    --cc=pali@kernel.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox