Re: [PATCH] thermal: core: Restore behavior regarding invalid trip points

[Ido Schimmel <idosch@nvidia.com>]

Hi Rafael,

On Tue, Mar 14, 2023 at 07:03:07PM +0100, Rafael J. Wysocki wrote:
> What if the temperature is negative?  I think that you'd still want to
> disable the trip in that case, wouldn't you?

Personally, no. This patch merely restores the behavior that was
inadvertently removed by 7c3d5c20dc16. Specifically by this hunk:

```
@@ -1252,9 +1319,10 @@ thermal_zone_device_register_with_trips(const char *type, struct thermal_trip *t
 		goto release_device;
 
 	for (count = 0; count < num_trips; count++) {
-		if (tz->ops->get_trip_type(tz, count, &trip_type) ||
-		    tz->ops->get_trip_temp(tz, count, &trip_temp) ||
-		    !trip_temp)
+		struct thermal_trip trip;
+
+		result = thermal_zone_get_trip(tz, count, &trip);
+		if (result)
 			set_bit(count, &tz->trips_disabled);
 	}
```

> Daniel, what's your take on this?

Discussed this with Daniel yesterday:
https://lore.kernel.org/linux-pm/ZA8TPDpEVanOpjEp@shredder/

We agreed to rework mlxsw to not rely on the fact that trip points with
a zero temperature are disabled, but it's not rc material, unlike this
patch.

Thanks