public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Chen Yu <yu.c.chen@intel.com>
To: Pavan Kondeti <quic_pkondeti@quicinc.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <len.brown@intel.com>, Ye Bin <yebin10@huawei.com>,
	<linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/2] Fix test_resume failure by openning swap device non-exclusively
Date: Wed, 12 Apr 2023 09:13:55 +0800	[thread overview]
Message-ID: <ZDYF0xjpz7+b/Rmj@chenyu5-mobl1> (raw)
In-Reply-To: <20230411053050.GA4099424@hu-pkondeti-hyd.qualcomm.com>

On 2023-04-11 at 11:00:50 +0530, Pavan Kondeti wrote:
> On Tue, Apr 11, 2023 at 08:18:43PM +0800, Chen Yu wrote:
> > test_resume does not work in current kernel when using swapfile for hibernation.
> > This is because the swap device should be openned non-exclusively in test_resume mode.
> > 
> > Patch 1 is a preparation for patch 2 and it turns snapshot_test into a global variable.
> > Patch 2 opens swap device non-exclusively for test_resume mode, and exclusively for manual
> > hibernation resume.
> > 
> > Change since v1:
> > Turn snapshot_test into global variable and do not introduce parameters for swsusp_check()
> > nor load_image_and_restore().
> > 
> > 
> > Chen Yu (2):
> >   PM: hibernate: Turn snapshot_test into global variable
> >   PM: hibernate: Do not get block device exclusively in test_resume mode
> > 
> >  kernel/power/hibernate.c | 12 +++++++++---
> >  kernel/power/power.h     |  1 +
> >  kernel/power/swap.c      |  5 +++--
> >  3 files changed, 13 insertions(+), 5 deletions(-)
> > 
> Looks good to me.
> 
> I have verified test_resume on QEMU arm64 and it worked fine with
> these two patches included.
>
Thanks, can I add your Tested-by tag?

thanks,
Chenyu 
> Thanks,
> Pavan

  reply	other threads:[~2023-04-12  1:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-11 12:18 [PATCH v2 0/2] Fix test_resume failure by openning swap device non-exclusively Chen Yu
2023-04-11  5:30 ` Pavan Kondeti
2023-04-12  1:13   ` Chen Yu [this message]
2023-04-12  4:36     ` Pavan Kondeti
2023-04-11 12:18 ` [PATCH v2 1/2] PM: hibernate: Turn snapshot_test into global variable Chen Yu
2023-04-11 12:19 ` [PATCH v2 2/2] PM: hibernate: Do not get block device exclusively in test_resume mode Chen Yu
2023-04-11 16:21   ` Rafael J. Wysocki
2023-04-12  1:17     ` Chen Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZDYF0xjpz7+b/Rmj@chenyu5-mobl1 \
    --to=yu.c.chen@intel.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=quic_pkondeti@quicinc.com \
    --cc=rafael@kernel.org \
    --cc=yebin10@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox