From: Wolfram Sang <wsa@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Tony Lindgren <tony@atomide.com>,
Andreas Kemnade <andreas@kemnade.info>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Janusz Krzysztofik <jmkrzyszt@gmail.com>,
Vignesh R <vigneshr@ti.com>,
linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org,
kernel@pengutronix.de, "Rafael J. Wysocki" <rafael@kernel.org>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH] i2c: omap: Improve error reporting for problems during .remove()
Date: Thu, 13 Apr 2023 18:49:06 +0200 [thread overview]
Message-ID: <ZDgygggnMLfqn86W@sai> (raw)
In-Reply-To: <20230406082354.jwchbl5ir6p4gjw7@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 613 bytes --]
On Thu, Apr 06, 2023 at 10:23:54AM +0200, Uwe Kleine-König wrote:
> If pm_runtime_get() fails in .remove() the driver used to return the
> error to the driver core. The only effect of this (compared to returning
> zero) is a generic warning that the error value is ignored.
>
> So emit a better warning and return zero to suppress the generic (and
> little helpful) message. Also disable runtime PM in the error case.
>
> This prepares changing platform device remove callbacks to return void.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-04-13 16:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-02 10:55 [PATCH] i2c: omap: Don't do pm_runtime_resume in .remove() Uwe Kleine-König
2023-04-02 20:50 ` Andreas Kemnade
2023-04-03 5:48 ` Uwe Kleine-König
2023-04-03 6:04 ` Tony Lindgren
2023-04-06 6:44 ` Wolfram Sang
2023-04-06 8:23 ` [PATCH] i2c: omap: Improve error reporting for problems during .remove() Uwe Kleine-König
2023-04-13 5:12 ` Tony Lindgren
2023-04-13 6:24 ` Uwe Kleine-König
2023-04-13 6:39 ` Tony Lindgren
2023-04-13 7:07 ` Uwe Kleine-König
2023-04-13 7:11 ` Tony Lindgren
2023-04-13 7:37 ` Uwe Kleine-König
2023-04-13 7:40 ` Tony Lindgren
2023-04-13 16:49 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDgygggnMLfqn86W@sai \
--to=wsa@kernel.org \
--cc=aaro.koskinen@iki.fi \
--cc=andreas@kemnade.info \
--cc=jmkrzyszt@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=tony@atomide.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).