From: andy.shevchenko@gmail.com
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: rafael@kernel.org, hdegoede@redhat.com, linus.walleij@linaro.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, platform-driver-x86@vger.kernel.org,
linux-pm@vger.kernel.org, Shyam-sundar.S-k@amd.com,
Basavaraj.Natikar@amd.com
Subject: Re: [PATCH v2 3/4] pinctrl: amd: Use pm_pr_dbg to show debugging messages
Date: Tue, 23 May 2023 19:55:37 +0300 [thread overview]
Message-ID: <ZGzwCdTO2LptPeQs@surfacebook> (raw)
In-Reply-To: <20230522200033.2605-3-mario.limonciello@amd.com>
Mon, May 22, 2023 at 03:00:32PM -0500, Mario Limonciello kirjoitti:
> To make the GPIO tracking around suspend easier for end users to
> use, link it with pm_debug_messages. This will make discovering
> sources of spurious GPIOs around suspend easier.
Unfortunatelly this has two regressions.
...
> - dev_dbg(&gpio_dev->pdev->dev,
> - "GPIO %d is active: 0x%x",
> - irqnr + i, regval);
> + pm_pr_dbg("GPIO %d is active: 0x%x",
> + irqnr + i, regval);
Regression 1: The device is now omitted from the output.
Regression 2: See https://stackoverflow.com/a/43957671/2511795
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-05-23 16:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 20:00 [PATCH v2 1/4] include/linux/suspend.h: Only show pm_pr_dbg messages at suspend/resume Mario Limonciello
2023-05-22 20:00 ` [PATCH v2 2/4] ACPI: x86: Add pm_debug_messages for LPS0 _DSM state tracking Mario Limonciello
2023-05-23 16:49 ` andy.shevchenko
2023-05-22 20:00 ` [PATCH v2 3/4] pinctrl: amd: Use pm_pr_dbg to show debugging messages Mario Limonciello
2023-05-23 16:55 ` andy.shevchenko [this message]
2023-05-24 18:28 ` Rafael J. Wysocki
2023-05-24 19:57 ` Andy Shevchenko
2023-05-24 20:25 ` Limonciello, Mario
2023-05-22 20:00 ` [PATCH v2 4/4] platform/x86/amd: pmc: Use pm_pr_dbg() for suspend related messages Mario Limonciello
2023-05-23 11:07 ` Hans de Goede
2023-05-23 16:21 ` Limonciello, Mario
2023-05-25 10:13 ` Hans de Goede
2023-05-25 12:06 ` Rafael J. Wysocki
2023-05-23 16:56 ` andy.shevchenko
2023-05-25 12:02 ` [PATCH v2 1/4] include/linux/suspend.h: Only show pm_pr_dbg messages at suspend/resume Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGzwCdTO2LptPeQs@surfacebook \
--to=andy.shevchenko@gmail.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=hdegoede@redhat.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).