From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7737BC7EE23 for ; Tue, 23 May 2023 16:55:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232592AbjEWQzp (ORCPT ); Tue, 23 May 2023 12:55:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237698AbjEWQzn (ORCPT ); Tue, 23 May 2023 12:55:43 -0400 Received: from fgw21-7.mail.saunalahti.fi (fgw21-7.mail.saunalahti.fi [62.142.5.82]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28E2611A for ; Tue, 23 May 2023 09:55:40 -0700 (PDT) Received: from localhost (88-113-26-95.elisa-laajakaista.fi [88.113.26.95]) by fgw21.mail.saunalahti.fi (Halon) with ESMTP id a4647b55-f98a-11ed-abf4-005056bdd08f; Tue, 23 May 2023 19:55:38 +0300 (EEST) From: andy.shevchenko@gmail.com Date: Tue, 23 May 2023 19:55:37 +0300 To: Mario Limonciello Cc: rafael@kernel.org, hdegoede@redhat.com, linus.walleij@linaro.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-pm@vger.kernel.org, Shyam-sundar.S-k@amd.com, Basavaraj.Natikar@amd.com Subject: Re: [PATCH v2 3/4] pinctrl: amd: Use pm_pr_dbg to show debugging messages Message-ID: References: <20230522200033.2605-1-mario.limonciello@amd.com> <20230522200033.2605-3-mario.limonciello@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230522200033.2605-3-mario.limonciello@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Mon, May 22, 2023 at 03:00:32PM -0500, Mario Limonciello kirjoitti: > To make the GPIO tracking around suspend easier for end users to > use, link it with pm_debug_messages. This will make discovering > sources of spurious GPIOs around suspend easier. Unfortunatelly this has two regressions. ... > - dev_dbg(&gpio_dev->pdev->dev, > - "GPIO %d is active: 0x%x", > - irqnr + i, regval); > + pm_pr_dbg("GPIO %d is active: 0x%x", > + irqnr + i, regval); Regression 1: The device is now omitted from the output. Regression 2: See https://stackoverflow.com/a/43957671/2511795 -- With Best Regards, Andy Shevchenko