linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Huang Rui <ray.huang@amd.com>
To: "Karny, Wyes" <Wyes.Karny@amd.com>
Cc: "trenn@suse.com" <trenn@suse.com>,
	"shuah@kernel.org" <shuah@kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"rafael@kernel.org" <rafael@kernel.org>,
	"Shenoy, Gautham Ranjal" <gautham.shenoy@amd.com>,
	"Limonciello, Mario" <Mario.Limonciello@amd.com>,
	"Yuan, Perry" <Perry.Yuan@amd.com>
Subject: Re: [PATCH v3 2/5] cpupower: Add is_valid_path API
Date: Tue, 20 Jun 2023 20:59:00 +0800	[thread overview]
Message-ID: <ZJGilObVcAMhPNF4@amd.com> (raw)
In-Reply-To: <20230619190503.4061-3-wyes.karny@amd.com>

On Tue, Jun 20, 2023 at 03:05:00AM +0800, Karny, Wyes wrote:
> Add is_valid_path API to check whether the sysfs file is present or not.
> 
> Suggested-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> Signed-off-by: Wyes Karny <wyes.karny@amd.com>

Acked-by: Huang Rui <ray.huang@amd.com>

> ---
>  tools/power/cpupower/lib/cpupower.c        | 7 +++++++
>  tools/power/cpupower/lib/cpupower_intern.h | 1 +
>  2 files changed, 8 insertions(+)
> 
> diff --git a/tools/power/cpupower/lib/cpupower.c b/tools/power/cpupower/lib/cpupower.c
> index 3f7d0c0c5067..7a2ef691b20e 100644
> --- a/tools/power/cpupower/lib/cpupower.c
> +++ b/tools/power/cpupower/lib/cpupower.c
> @@ -14,6 +14,13 @@
>  #include "cpupower.h"
>  #include "cpupower_intern.h"
>  
> +int is_valid_path(const char *path)
> +{
> +	if (access(path, F_OK) == -1)
> +		return 0;
> +	return 1;
> +}
> +
>  unsigned int cpupower_read_sysfs(const char *path, char *buf, size_t buflen)
>  {
>  	ssize_t numread;
> diff --git a/tools/power/cpupower/lib/cpupower_intern.h b/tools/power/cpupower/lib/cpupower_intern.h
> index ac1112b956ec..5fdb8620d41b 100644
> --- a/tools/power/cpupower/lib/cpupower_intern.h
> +++ b/tools/power/cpupower/lib/cpupower_intern.h
> @@ -7,5 +7,6 @@
>  
>  #define SYSFS_PATH_MAX 255
>  
> +int is_valid_path(const char *path);
>  unsigned int cpupower_read_sysfs(const char *path, char *buf, size_t buflen);
>  unsigned int cpupower_write_sysfs(const char *path, char *buf, size_t buflen);
> -- 
> 2.34.1
> 

  parent reply	other threads:[~2023-06-20 12:59 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-19 19:04 [PATCH v3 0/5] cpupower: Add various feature control support for amd_pstate Wyes Karny
2023-06-19 19:04 ` [PATCH v3 1/5] cpupower: Recognise amd-pstate active mode driver Wyes Karny
2023-06-19 19:08   ` Limonciello, Mario
2023-06-20  3:10   ` Yuan, Perry
2023-06-20 12:49   ` Huang Rui
2023-06-19 19:05 ` [PATCH v3 2/5] cpupower: Add is_valid_path API Wyes Karny
2023-06-20  3:09   ` Yuan, Perry
2023-06-20 12:59   ` Huang Rui [this message]
2023-06-19 19:05 ` [PATCH v3 3/5] cpupower: Add EPP value change support Wyes Karny
2023-06-20  3:08   ` Yuan, Perry
2023-06-20 12:59   ` Huang Rui
2023-06-19 19:05 ` [PATCH v3 4/5] cpupower: Add support for amd_pstate mode change Wyes Karny
2023-06-20  3:08   ` Yuan, Perry
2023-06-19 19:05 ` [PATCH v3 5/5] cpupower: Add turbo-boost support in cpupower Wyes Karny
2023-06-20  3:07   ` Yuan, Perry
2023-06-20  4:49     ` Wyes Karny
2023-07-14 11:19 ` [PATCH v3 0/5] cpupower: Add various feature control support for amd_pstate Thomas Renninger
2023-07-18 22:17   ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZJGilObVcAMhPNF4@amd.com \
    --to=ray.huang@amd.com \
    --cc=Mario.Limonciello@amd.com \
    --cc=Perry.Yuan@amd.com \
    --cc=Wyes.Karny@amd.com \
    --cc=gautham.shenoy@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=shuah@kernel.org \
    --cc=trenn@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).