From: Mark Brown <broonie@kernel.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Icenowy Zheng <uwu@icenowy.me>,
Vasily Khoruzhick <anarsoul@gmail.com>,
Yangtao Li <tiny.windzz@gmail.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Hugh Dickins <hughd@google.com>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thermal/drivers/sun8i: Don't fail probe due to zone registration failure
Date: Sun, 23 Jul 2023 15:41:07 +0100 [thread overview]
Message-ID: <ZL08A8J7fLJ3bJsl@finisterre.sirena.org.uk> (raw)
In-Reply-To: <17dc1961-c629-e09f-8979-1e6cbc92534e@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 777 bytes --]
On Sun, Jul 23, 2023 at 11:40:34AM +0200, Daniel Lezcano wrote:
> On 22/07/2023 18:46, Mark Brown wrote:
> > It did seem to be a bit of an excessively strict requirement, I was
> > going to poke at that myself. It does seem worthwhile doing the change
> > in the sun8i driver anyway, there might be some other issue that causes
> > registration to fail which would have the same issue.
> Why do you want a thermal zone if there is no trip point ?
It at least allows you to see what the hardware is monitoring. It's not
terribly useful for thermal management (unless you're doing to try to do
something in userspace I guess) but it seems more helpful than
completely failing to register, especially given the knock on effects
when a single device registers multiple zones.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2023-07-23 14:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 15:04 [PATCH] thermal/drivers/sun8i: Don't fail probe due to zone registration failure Mark Brown
2023-07-18 16:50 ` Vasily Khoruzhick
2023-07-19 20:24 ` Jernej Škrabec
2023-07-22 12:11 ` Icenowy Zheng
2023-07-22 16:46 ` Mark Brown
2023-07-23 9:40 ` Daniel Lezcano
2023-07-23 14:41 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZL08A8J7fLJ3bJsl@finisterre.sirena.org.uk \
--to=broonie@kernel.org \
--cc=amitk@kernel.org \
--cc=anarsoul@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=hughd@google.com \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=samuel@sholland.org \
--cc=tiny.windzz@gmail.com \
--cc=uwu@icenowy.me \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox