* [PATCH] interconnect: qcom: icc-rpm: Initialize ret variable to fix smatch error
@ 2023-07-17 7:34 djakov
2023-07-17 10:52 ` Stephan Gerhold
0 siblings, 1 reply; 4+ messages in thread
From: djakov @ 2023-07-17 7:34 UTC (permalink / raw)
To: djakov, konrad.dybcio, andersson
Cc: stephan, linux-arm-msm, linux-pm, linux-kernel
From: Georgi Djakov <djakov@kernel.org>
Fix the following smatch error:
drivers/interconnect/qcom/icc-rpm.c:243 qcom_icc_rpm_set() error: uninitialized symbol 'ret'.
Fixes: 32846c4a8f2a ("interconnect: qcom: icc-rpm: Set bandwidth on both contexts")
Signed-off-by: Georgi Djakov <djakov@kernel.org>
---
drivers/interconnect/qcom/icc-rpm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qcom/icc-rpm.c
index 612390b9eb18..6718cc648d75 100644
--- a/drivers/interconnect/qcom/icc-rpm.c
+++ b/drivers/interconnect/qcom/icc-rpm.c
@@ -206,7 +206,7 @@ static int qcom_icc_qos_set(struct icc_node *node)
static int qcom_icc_rpm_set(struct qcom_icc_node *qn, u64 *bw)
{
- int ret, rpm_ctx = 0;
+ int ret = 0, rpm_ctx = 0;
u64 bw_bps;
if (qn->qos.ap_owned)
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] interconnect: qcom: icc-rpm: Initialize ret variable to fix smatch error
2023-07-17 7:34 [PATCH] interconnect: qcom: icc-rpm: Initialize ret variable to fix smatch error djakov
@ 2023-07-17 10:52 ` Stephan Gerhold
2023-07-17 12:55 ` [PATCH v2] interconnect: qcom: icc-rpm: Explicitly return 0 at the end of the function djakov
0 siblings, 1 reply; 4+ messages in thread
From: Stephan Gerhold @ 2023-07-17 10:52 UTC (permalink / raw)
To: djakov; +Cc: konrad.dybcio, andersson, linux-arm-msm, linux-pm, linux-kernel
On Mon, Jul 17, 2023 at 10:34:29AM +0300, djakov@kernel.org wrote:
> From: Georgi Djakov <djakov@kernel.org>
>
> Fix the following smatch error:
> drivers/interconnect/qcom/icc-rpm.c:243 qcom_icc_rpm_set() error: uninitialized symbol 'ret'.
>
> Fixes: 32846c4a8f2a ("interconnect: qcom: icc-rpm: Set bandwidth on both contexts")
> Signed-off-by: Georgi Djakov <djakov@kernel.org>
Thanks for spotting this!
> ---
> drivers/interconnect/qcom/icc-rpm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qcom/icc-rpm.c
> index 612390b9eb18..6718cc648d75 100644
> --- a/drivers/interconnect/qcom/icc-rpm.c
> +++ b/drivers/interconnect/qcom/icc-rpm.c
> @@ -206,7 +206,7 @@ static int qcom_icc_qos_set(struct icc_node *node)
>
> static int qcom_icc_rpm_set(struct qcom_icc_node *qn, u64 *bw)
> {
> - int ret, rpm_ctx = 0;
> + int ret = 0, rpm_ctx = 0;
> u64 bw_bps;
>
> if (qn->qos.ap_owned)
I think it would be a bit clearer to change the "return ret;" at the end
of the function to "return 0;". The ret variable is only used inside the
for loop and always handled there, so we always want to return 0 when
reaching the end of the function.
Thanks,
Stephan
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2] interconnect: qcom: icc-rpm: Explicitly return 0 at the end of the function
2023-07-17 10:52 ` Stephan Gerhold
@ 2023-07-17 12:55 ` djakov
2023-07-17 13:04 ` Stephan Gerhold
0 siblings, 1 reply; 4+ messages in thread
From: djakov @ 2023-07-17 12:55 UTC (permalink / raw)
To: djakov, konrad.dybcio, andersson, stephan
Cc: linux-arm-msm, linux-pm, linux-kernel
From: Georgi Djakov <djakov@kernel.org>
Fix the following smatch error:
drivers/interconnect/qcom/icc-rpm.c:243 qcom_icc_rpm_set() error: uninitialized symbol 'ret'.
Fixes: 32846c4a8f2a ("interconnect: qcom: icc-rpm: Set bandwidth on both contexts")
Signed-off-by: Georgi Djakov <djakov@kernel.org>
---
v2: Just return 0 when reaching the end of the function. (Thanks Stephan!)
v1: https://lore.kernel.org/r/20230717073429.2115015-1-djakov@kernel.org
drivers/interconnect/qcom/icc-rpm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qcom/icc-rpm.c
index 612390b9eb18..2c16917ba1fd 100644
--- a/drivers/interconnect/qcom/icc-rpm.c
+++ b/drivers/interconnect/qcom/icc-rpm.c
@@ -240,7 +240,7 @@ static int qcom_icc_rpm_set(struct qcom_icc_node *qn, u64 *bw)
}
}
- return ret;
+ return 0;
}
/**
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] interconnect: qcom: icc-rpm: Explicitly return 0 at the end of the function
2023-07-17 12:55 ` [PATCH v2] interconnect: qcom: icc-rpm: Explicitly return 0 at the end of the function djakov
@ 2023-07-17 13:04 ` Stephan Gerhold
0 siblings, 0 replies; 4+ messages in thread
From: Stephan Gerhold @ 2023-07-17 13:04 UTC (permalink / raw)
To: djakov; +Cc: konrad.dybcio, andersson, linux-arm-msm, linux-pm, linux-kernel
On Mon, Jul 17, 2023 at 03:55:34PM +0300, djakov@kernel.org wrote:
> From: Georgi Djakov <djakov@kernel.org>
>
> Fix the following smatch error:
> drivers/interconnect/qcom/icc-rpm.c:243 qcom_icc_rpm_set() error: uninitialized symbol 'ret'.
>
> Fixes: 32846c4a8f2a ("interconnect: qcom: icc-rpm: Set bandwidth on both contexts")
> Signed-off-by: Georgi Djakov <djakov@kernel.org>
> ---
> v2: Just return 0 when reaching the end of the function. (Thanks Stephan!)
> v1: https://lore.kernel.org/r/20230717073429.2115015-1-djakov@kernel.org
>
> drivers/interconnect/qcom/icc-rpm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qcom/icc-rpm.c
> index 612390b9eb18..2c16917ba1fd 100644
> --- a/drivers/interconnect/qcom/icc-rpm.c
> +++ b/drivers/interconnect/qcom/icc-rpm.c
> @@ -240,7 +240,7 @@ static int qcom_icc_rpm_set(struct qcom_icc_node *qn, u64 *bw)
> }
> }
>
> - return ret;
> + return 0;
> }
>
> /**
Thanks!
Reviewed-by: Stephan Gerhold <stephan@gerhold.net>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-17 13:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-17 7:34 [PATCH] interconnect: qcom: icc-rpm: Initialize ret variable to fix smatch error djakov
2023-07-17 10:52 ` Stephan Gerhold
2023-07-17 12:55 ` [PATCH v2] interconnect: qcom: icc-rpm: Explicitly return 0 at the end of the function djakov
2023-07-17 13:04 ` Stephan Gerhold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).