From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29B59EB64DC for ; Tue, 18 Jul 2023 13:51:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231384AbjGRNvu (ORCPT ); Tue, 18 Jul 2023 09:51:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231179AbjGRNvt (ORCPT ); Tue, 18 Jul 2023 09:51:49 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAA93E5; Tue, 18 Jul 2023 06:51:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689688308; x=1721224308; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=/ek4HQDqASP1346ScIwRLDWKoFoS68Rokb5r5BxIupU=; b=D9pzTJmiotiBgdPXEw+LM9Hoo0YTi4nWzttl9/AS+vDDdb9jgfZpzWlx KC0A5O7oeAkDP9eptyFwDuTFh9lB+yPa8X5wRr26lF/J3tdxkuVpNMDJt lhPNJ1JsXqjH80ZULlvU0FwWQd/0i6bQQe1o82p0EMUbTlglujlXXM0w2 LBxjqx7B6HoE1Hf9QDMCoNT7VD1c4CrfHPGLPtJyX3nKfK/XzyGVFuT81 dAV/5PCmZhFGOZ5G2AHYGEtl+Rv5v7RsGQzulo9KDOAWSXPB63CSd82UM KhlpsTnFxv+Qo8PmkqGTT2DzFFdiPSUbUMRzRIdhDi5Ajc3VQpF101Zlw w==; X-IronPort-AV: E=McAfee;i="6600,9927,10775"; a="345803138" X-IronPort-AV: E=Sophos;i="6.01,214,1684825200"; d="scan'208";a="345803138" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2023 06:51:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10775"; a="847707771" X-IronPort-AV: E=Sophos;i="6.01,214,1684825200"; d="scan'208";a="847707771" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga004.jf.intel.com with ESMTP; 18 Jul 2023 06:51:41 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qLl74-00FrDv-32; Tue, 18 Jul 2023 16:51:38 +0300 Date: Tue, 18 Jul 2023 16:51:38 +0300 From: Andy Shevchenko To: Jonathan Cameron Cc: Mika Westerberg , Linus Walleij , Balsam CHIHI , Claudiu Beznea , Geert Uytterhoeven , Wolfram Sang , Thierry Reding , Paul Cercueil , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, Andrew Lunn , Alexandre Belloni , Len Brown , "Rafael J. Wysocki" , Gregory Clement , Sean Wang , Jonathan Hunter , Ludovic Desroches , Pavel Machek , Matthias Brugger , Sebastian Hesselbarth , AngeloGioacchino Del Regno Subject: Re: [PATCH v2 03/10] pinctrl: cherryview: Switch to use DEFINE_NOIRQ_DEV_PM_OPS() helper Message-ID: References: <20230717172821.62827-1-andriy.shevchenko@linux.intel.com> <20230717172821.62827-4-andriy.shevchenko@linux.intel.com> <20230718105453.00004dc3@Huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230718105453.00004dc3@Huawei.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Tue, Jul 18, 2023 at 10:54:53AM +0100, Jonathan Cameron wrote: > On Mon, 17 Jul 2023 20:28:14 +0300 > Andy Shevchenko wrote: ... > Reviewed-by: Jonathan Cameron Thanks! ... > > + static DEFINE_NOIRQ_DEV_PM_OPS(chv_pinctrl_pm_ops, chv_pinctrl_suspend_noirq, chv_pinctrl_resume_noirq); > > Very long line and readability not hurt by breaking it. Sure. -- With Best Regards, Andy Shevchenko