From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED44CEB64DC for ; Tue, 18 Jul 2023 13:50:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232775AbjGRNux (ORCPT ); Tue, 18 Jul 2023 09:50:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232124AbjGRNuw (ORCPT ); Tue, 18 Jul 2023 09:50:52 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EB558F; Tue, 18 Jul 2023 06:50:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689688252; x=1721224252; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Z280C0QnfRU4Fge1sZLeOEz0ioQaTHytM42PyAGyTZA=; b=CPgUsO2C2X6Be+69E+9fgmCRM4Shwl1YLxLpGy5gCO2wuCC48S2h/ZFw wcoS+WGABOgElMUwzfgPxU6B46imKmc6Hlv0saUTMmren1l+1VYb3/gyq fnfWr48s1VJhWTuULURRXaEuZ4cwE6JJRlIcSjlL7W6qxmO+dKsDy0OqO P9LtqPglKP/VI5Q22JcNVY2LZ6/O2l9D2eZQ+O9V/Gh57GTrLZiwI0lY8 3qlpzl6un0ZALGgLDZzrWhKI8IzGlbnxciEpuf9Mm1L+aQSObp2DNidEI l1u2QJHdeUSZ1OYsRzeqW6WtyRDJMZhnFa7JMtbjmln5QvdVXAXvapMZ9 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10775"; a="365087309" X-IronPort-AV: E=Sophos;i="6.01,214,1684825200"; d="scan'208";a="365087309" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2023 06:50:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10775"; a="700903622" X-IronPort-AV: E=Sophos;i="6.01,214,1684825200"; d="scan'208";a="700903622" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga006.jf.intel.com with ESMTP; 18 Jul 2023 06:50:45 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qLl6A-00Fp8w-0P; Tue, 18 Jul 2023 16:50:42 +0300 Date: Tue, 18 Jul 2023 16:50:41 +0300 From: Andy Shevchenko To: Jonathan Cameron Cc: Mika Westerberg , Linus Walleij , Balsam CHIHI , Claudiu Beznea , Geert Uytterhoeven , Wolfram Sang , Thierry Reding , Paul Cercueil , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, Andrew Lunn , Alexandre Belloni , Len Brown , "Rafael J. Wysocki" , Gregory Clement , Sean Wang , Jonathan Hunter , Ludovic Desroches , Pavel Machek , Matthias Brugger , Sebastian Hesselbarth , AngeloGioacchino Del Regno Subject: Re: [PATCH v2 02/10] pinctrl: baytrail: Make use of pm_ptr() Message-ID: References: <20230717172821.62827-1-andriy.shevchenko@linux.intel.com> <20230717172821.62827-3-andriy.shevchenko@linux.intel.com> <20230718105322.000074ca@Huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230718105322.000074ca@Huawei.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Tue, Jul 18, 2023 at 10:53:22AM +0100, Jonathan Cameron wrote: > On Mon, 17 Jul 2023 20:28:13 +0300 > Andy Shevchenko wrote: > > > Cleaning up the driver to use pm_ptr() and *_PM_OPS() macros that > > make it simpler and allows the compiler to remove those functions > > if built without CONFIG_PM and CONFIG_PM_SLEEP support. > > > > Signed-off-by: Andy Shevchenko > > LGTM but why is it in a set that claims to be about NOIRQ PM helper? Have you chance to read a cover letter? I explained that I added them as they are "kinda" to the topic (PM related). I can apply them and drop for next version. Thank you for the review! -- With Best Regards, Andy Shevchenko