From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23552EB64DD for ; Tue, 18 Jul 2023 13:53:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232929AbjGRNxo (ORCPT ); Tue, 18 Jul 2023 09:53:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232921AbjGRNxm (ORCPT ); Tue, 18 Jul 2023 09:53:42 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C251D99; Tue, 18 Jul 2023 06:53:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689688419; x=1721224419; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=9ophA10kUFzoNAqizRgztDPJPsGfNIY1vmJXIIYiDlc=; b=Y8YvhyqVPA1qHR0TnpJUsZPlfS/Dd9z2AnZMrJblXfFFm3Iqwrb6pU9l WkPMHCN56uK0gyw6B2wVRoV2Q3rLPPzSI/xrpqI+BhQQUv8GnZT65HXOX JKt2Dajs03neBM+4dCXxeXBpfEBY3fidyl1SArrQJc2oGVbKl70XLY+F+ WGlTTHueeI7if3U3Evz8DZ58k4i5wkBQ/jQ3pYA+SNxHTCfI/7jfjmvX2 vWRpyNwMm/q73Ay4UpzzItnZ+LFXHFw6Nam58SxFZGZNTD47Y+HfAvRVt FNrabsyTfCiLI3SkDoir3sBSs6XOauXzKmeVyA1zyLWYLN4A9iWSFLcEX w==; X-IronPort-AV: E=McAfee;i="6600,9927,10775"; a="345803481" X-IronPort-AV: E=Sophos;i="6.01,214,1684825200"; d="scan'208";a="345803481" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2023 06:53:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10775"; a="847708035" X-IronPort-AV: E=Sophos;i="6.01,214,1684825200"; d="scan'208";a="847708035" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga004.jf.intel.com with ESMTP; 18 Jul 2023 06:53:32 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qLl8r-00Fuul-36; Tue, 18 Jul 2023 16:53:29 +0300 Date: Tue, 18 Jul 2023 16:53:29 +0300 From: Andy Shevchenko To: Jonathan Cameron Cc: Mika Westerberg , Linus Walleij , Balsam CHIHI , Claudiu Beznea , Geert Uytterhoeven , Wolfram Sang , Thierry Reding , Paul Cercueil , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, Andrew Lunn , Alexandre Belloni , Len Brown , "Rafael J. Wysocki" , Gregory Clement , Sean Wang , Jonathan Hunter , Ludovic Desroches , Pavel Machek , Matthias Brugger , Sebastian Hesselbarth , AngeloGioacchino Del Regno Subject: Re: [PATCH v2 04/10] pinctrl: intel: Switch to use DEFINE_NOIRQ_DEV_PM_OPS() helper Message-ID: References: <20230717172821.62827-1-andriy.shevchenko@linux.intel.com> <20230717172821.62827-5-andriy.shevchenko@linux.intel.com> <20230718110451.00001227@Huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230718110451.00001227@Huawei.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Tue, Jul 18, 2023 at 11:04:51AM +0100, Jonathan Cameron wrote: > On Mon, 17 Jul 2023 20:28:15 +0300 > Andy Shevchenko wrote: ... > > EXPORT_SYMBOL_GPL(intel_pinctrl_resume_noirq); > > Can you check if this is successfully removed? I think it won't be. > Not immediately obvious how to tidy that up given these are used > in a macro called from lots of drivers. That's what Paul noticed I think with his proposal to export only the ops variable and make these to be static. > Maybe just leaving the ifdef is best we can do here. See above. -- With Best Regards, Andy Shevchenko