From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01D40C04A94 for ; Mon, 31 Jul 2023 20:27:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230285AbjGaU1i (ORCPT ); Mon, 31 Jul 2023 16:27:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230188AbjGaU1i (ORCPT ); Mon, 31 Jul 2023 16:27:38 -0400 Received: from mgamail.intel.com (unknown [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5C111723; Mon, 31 Jul 2023 13:27:36 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="369124347" X-IronPort-AV: E=Sophos;i="6.01,245,1684825200"; d="scan'208";a="369124347" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jul 2023 13:27:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="678449692" X-IronPort-AV: E=Sophos;i="6.01,245,1684825200"; d="scan'208";a="678449692" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga003.jf.intel.com with ESMTP; 31 Jul 2023 13:27:34 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qQZUL-004oIS-0k; Mon, 31 Jul 2023 23:27:33 +0300 Date: Mon, 31 Jul 2023 23:27:32 +0300 From: Andy Shevchenko To: Nikita Shubin Cc: Sebastian Reichel , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 14/42] power: reset: Add a driver for the ep93xx reset Message-ID: References: <20230605-ep93xx-v3-0-3d63a5f1103e@maquefel.me> <20230605-ep93xx-v3-14-3d63a5f1103e@maquefel.me> <7788b12515f7e00b4bb0a04da30fc7fd0fdb8d51.camel@maquefel.me> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7788b12515f7e00b4bb0a04da30fc7fd0fdb8d51.camel@maquefel.me> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Fri, Jul 28, 2023 at 04:53:19PM +0300, Nikita Shubin wrote: > On Fri, 2023-07-21 at 19:37 +0300, Andy Shevchenko wrote: > > On Thu, Jul 20, 2023 at 02:29:14PM +0300, Nikita Shubin via B4 Relay > > wrote: ... > > > +// SPDX-License-Identifier: (GPL-2.0) > > > > Are you sure this is correct form?  > > Should it be // SPDX-License-Identifier: GPL-2.0+ ? I don't know, ask your Legal department or your lawyer. (note that the 2.0-only and 2.0-or-later are different) I'm talking only about the form, not about the licence itself. > > Have you checked your patches? > > Could you please be more specific: > $ scripts/checkpatch.pl -f drivers/power/reset/ep93xx-restart.c > total: 0 errors, 0 warnings, 86 lines checked > > $ git format-patch -1 51f03c64b8fde79fb16b146d87769b7508b6d114 --stdout > | scripts/checkpatch.pl - > WARNING: please write a help paragraph that fully describes the config > symbol > ... > WARNING: added, moved or deleted file(s), does MAINTAINERS need > updating? > > I don't see any license complains... checkpatch is not the ideal tool... > checkpatch.pl is working as intented as: > > $ scripts/checkpatch.pl -f drivers/power/reset/ep93xx-restart.c > WARNING: 'SPDX-License-Identifier: (FOOOO)' is not supported in > LICENSES/... > #1: FILE: drivers/power/reset/ep93xx-restart.c:1: > +// SPDX-License-Identifier: (FOOOO) https://kernel.org/doc/html/latest/process/license-rules.html doesn't mention your format. -- With Best Regards, Andy Shevchenko